{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":259463685,"defaultBranch":"trunk","name":"carbon-lang","ownerLogin":"carbon-language","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-04-27T21:45:16.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/63681715?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717219020.0","currentOid":""},"activityList":{"items":[{"before":"e34e2402633e2d3113385f242258666eeb8bfeed","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-3995-0d37095ec62e5ce82a82d4146a072ea8417fc5a3","pushedAt":"2024-06-01T05:25:54.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"0d37095ec62e5ce82a82d4146a072ea8417fc5a3","after":"e34e2402633e2d3113385f242258666eeb8bfeed","ref":"refs/heads/trunk","pushedAt":"2024-06-01T05:25:53.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Move the core standard library to the installation. (#3995)\n\nThis removes the `data_dir` from the driver favoring the installation\nabstraction for the both locating the prelude and linking utilities.\n\nWith this, an installed toolchain should also be able to compile and\nlink Carbon successfully, and the build of the examples should exercise\nthis path almost exactly. (The only difference is using the driver\n`cc_binary` directly rather than relying on the symlink from inside the\ninstall tree.)","shortMessageHtmlLink":"Move the core standard library to the installation. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2318246613\" data-permission-text=\"Title is private\" data-url=\"https://github.com/carbon-language/carbon-lang/issues/3995\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/carbon-language/carbon-lang/pull/3995/hovercard\" href=\"https://github.com/carbon-language/carbon-lang/pull/3995\">#3995</a>)"}},{"before":null,"after":"e34e2402633e2d3113385f242258666eeb8bfeed","ref":"refs/heads/gh-readonly-queue/trunk/pr-3995-0d37095ec62e5ce82a82d4146a072ea8417fc5a3","pushedAt":"2024-06-01T05:17:00.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Move the core standard library to the installation. (#3995)\n\nThis removes the `data_dir` from the driver favoring the installation\nabstraction for the both locating the prelude and linking utilities.\n\nWith this, an installed toolchain should also be able to compile and\nlink Carbon successfully, and the build of the examples should exercise\nthis path almost exactly. (The only difference is using the driver\n`cc_binary` directly rather than relying on the symlink from inside the\ninstall tree.)","shortMessageHtmlLink":"Move the core standard library to the installation. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2318246613\" data-permission-text=\"Title is private\" data-url=\"https://github.com/carbon-language/carbon-lang/issues/3995\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/carbon-language/carbon-lang/pull/3995/hovercard\" href=\"https://github.com/carbon-language/carbon-lang/pull/3995\">#3995</a>)"}},{"before":"0d37095ec62e5ce82a82d4146a072ea8417fc5a3","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-3994-d3a5b0eee7195267440749a5554a68c8761e2dfd","pushedAt":"2024-06-01T04:28:24.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"d3a5b0eee7195267440749a5554a68c8761e2dfd","after":"0d37095ec62e5ce82a82d4146a072ea8417fc5a3","ref":"refs/heads/trunk","pushedAt":"2024-06-01T04:28:23.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Add very minimal support for packaging the toolchain. (#3994)\n\nThis takes the installation layout and replicates it using `rules_pkg`\nto build either a tarball or a zip file of the toolchain. Correctly\nmanages file permissions and symlinks, etc.\n\nThere are some big remaining things here:\n\n- Figure out how we want to test this. We can add shell tests maybe?\n  A bit awkward. Nicer would be to make the `//examples` tree build\n  using this rather than the more native-bazel install data, however\n  building these is quite slow and it seems bad to pay that cost\n  constantly so dedicated testing is probably better. For now, I've\n  tested these manually.\n\n- Need to add versions to the toolchain and then thread them through\n  here so they install properly as a versioned release.\n\nBut my primary goal for now is just to be able to validate that the\ninstall tree is working outside of Bazel and this does enough for that.\nThe above will be longer-term things.","shortMessageHtmlLink":"Add very minimal support for packaging the toolchain. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2318010346\" data-permission-text=\"Title is private\" data-url=\"https://github.com/carbon-language/carbon-lang/issues/3994\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/carbon-language/carbon-lang/pull/3994/hovercard\" href=\"https://github.com/carbon-language/carbon-lang/pull/3994\">#3994</a>)"}},{"before":null,"after":"0d37095ec62e5ce82a82d4146a072ea8417fc5a3","ref":"refs/heads/gh-readonly-queue/trunk/pr-3994-d3a5b0eee7195267440749a5554a68c8761e2dfd","pushedAt":"2024-06-01T04:24:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Add very minimal support for packaging the toolchain. (#3994)\n\nThis takes the installation layout and replicates it using `rules_pkg`\nto build either a tarball or a zip file of the toolchain. Correctly\nmanages file permissions and symlinks, etc.\n\nThere are some big remaining things here:\n\n- Figure out how we want to test this. We can add shell tests maybe?\n  A bit awkward. Nicer would be to make the `//examples` tree build\n  using this rather than the more native-bazel install data, however\n  building these is quite slow and it seems bad to pay that cost\n  constantly so dedicated testing is probably better. For now, I've\n  tested these manually.\n\n- Need to add versions to the toolchain and then thread them through\n  here so they install properly as a versioned release.\n\nBut my primary goal for now is just to be able to validate that the\ninstall tree is working outside of Bazel and this does enough for that.\nThe above will be longer-term things.","shortMessageHtmlLink":"Add very minimal support for packaging the toolchain. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2318010346\" data-permission-text=\"Title is private\" data-url=\"https://github.com/carbon-language/carbon-lang/issues/3994\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/carbon-language/carbon-lang/pull/3994/hovercard\" href=\"https://github.com/carbon-language/carbon-lang/pull/3994\">#3994</a>)"}},{"before":"d3a5b0eee7195267440749a5554a68c8761e2dfd","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-3993-d0c848317547af46bd96c54cd1c93a60933ffe07","pushedAt":"2024-06-01T03:36:38.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"d0c848317547af46bd96c54cd1c93a60933ffe07","after":"d3a5b0eee7195267440749a5554a68c8761e2dfd","ref":"refs/heads/trunk","pushedAt":"2024-06-01T03:36:37.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Add utilities for managing a toolchain install, and install and use LLD. (#3993)\n\nThe install directory contains the BUILD logic for creating an\ninstallable tree of data files and executables for the toolchain, and\na library to facilitate toolchain code accessing the paths to their data\nwithin this installation.\n\nThen adds an installation of LLD in a synthetic LLVM installation, and\nteaches the Clang runner to configure this and use it for linking\ninstead of the system linker.\n\nCurrently, the install paths only really manage access to the LLVM\nbinaries installed and used by the Clang runner for linking, but\neventually other data files like the prelude and runtime libraries will\nbe fleshed out as well. There are TODOs for moving more things over here\nsuch as the prelude.\n\nOne interesting aspect of this is where to put helpers like parts of\nLLVM in our install. This PR suggests nesting those files under\n`lib/carbon`. While using a `lib` subdirectory isn't a perfect fit for\nthe FHS (Filesystem Hierarchy Standard), having a single location where\nprivate data is collected is significantly superior to spreading them\nacross the system. This also matches similar patterns used by Clang\nitself and several other language toolchains and standard libraries.\n\nThe install directory also provides a natural place for us to build out\npackaging rules to create installable packages in various formats, but\nthat remains future work.\n\n---------\n\nCo-authored-by: Jon Ross-Perkins <jperkins@google.com>","shortMessageHtmlLink":"Add utilities for managing a toolchain install, and install and use L…"}},{"before":null,"after":"d3a5b0eee7195267440749a5554a68c8761e2dfd","ref":"refs/heads/gh-readonly-queue/trunk/pr-3993-d0c848317547af46bd96c54cd1c93a60933ffe07","pushedAt":"2024-06-01T03:20:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Add utilities for managing a toolchain install, and install and use LLD. (#3993)\n\nThe install directory contains the BUILD logic for creating an\ninstallable tree of data files and executables for the toolchain, and\na library to facilitate toolchain code accessing the paths to their data\nwithin this installation.\n\nThen adds an installation of LLD in a synthetic LLVM installation, and\nteaches the Clang runner to configure this and use it for linking\ninstead of the system linker.\n\nCurrently, the install paths only really manage access to the LLVM\nbinaries installed and used by the Clang runner for linking, but\neventually other data files like the prelude and runtime libraries will\nbe fleshed out as well. There are TODOs for moving more things over here\nsuch as the prelude.\n\nOne interesting aspect of this is where to put helpers like parts of\nLLVM in our install. This PR suggests nesting those files under\n`lib/carbon`. While using a `lib` subdirectory isn't a perfect fit for\nthe FHS (Filesystem Hierarchy Standard), having a single location where\nprivate data is collected is significantly superior to spreading them\nacross the system. This also matches similar patterns used by Clang\nitself and several other language toolchains and standard libraries.\n\nThe install directory also provides a natural place for us to build out\npackaging rules to create installable packages in various formats, but\nthat remains future work.\n\n---------\n\nCo-authored-by: Jon Ross-Perkins <jperkins@google.com>","shortMessageHtmlLink":"Add utilities for managing a toolchain install, and install and use L…"}},{"before":"d0c848317547af46bd96c54cd1c93a60933ffe07","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4014-517a416852c0f70111d8a2fe25a78035735ad93c","pushedAt":"2024-05-31T23:40:06.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"517a416852c0f70111d8a2fe25a78035735ad93c","after":"d0c848317547af46bd96c54cd1c93a60933ffe07","ref":"refs/heads/trunk","pushedAt":"2024-05-31T23:40:05.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Switch init style in import_ref.cpp (#4014)\n\nThis file has a cluster of struct inits, so splitting apart from other\nedits related to #4009.","shortMessageHtmlLink":"Switch init style in import_ref.cpp (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2328623200\" data-permission-text=\"Title is private\" data-url=\"https://github.com/carbon-language/carbon-lang/issues/4014\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/carbon-language/carbon-lang/pull/4014/hovercard\" href=\"https://github.com/carbon-language/carbon-lang/pull/4014\">#4014</a>)"}},{"before":"517a416852c0f70111d8a2fe25a78035735ad93c","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4013-3c01ee69ed13185f0477c75189283aaebe68ab17","pushedAt":"2024-05-31T23:33:09.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":null,"after":"d0c848317547af46bd96c54cd1c93a60933ffe07","ref":"refs/heads/gh-readonly-queue/trunk/pr-4014-517a416852c0f70111d8a2fe25a78035735ad93c","pushedAt":"2024-05-31T23:33:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Switch init style in import_ref.cpp (#4014)\n\nThis file has a cluster of struct inits, so splitting apart from other\nedits related to #4009.","shortMessageHtmlLink":"Switch init style in import_ref.cpp (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2328623200\" data-permission-text=\"Title is private\" data-url=\"https://github.com/carbon-language/carbon-lang/issues/4014\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/carbon-language/carbon-lang/pull/4014/hovercard\" href=\"https://github.com/carbon-language/carbon-lang/pull/4014\">#4014</a>)"}},{"before":"3c01ee69ed13185f0477c75189283aaebe68ab17","after":"517a416852c0f70111d8a2fe25a78035735ad93c","ref":"refs/heads/trunk","pushedAt":"2024-05-31T23:33:08.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Clean up some misc toolchain braced inits. (#4013)\n\nFollowing up on #4012 and #4009, clean scattered cases which could be\nmaking better use of designated initializers.","shortMessageHtmlLink":"Clean up some misc toolchain braced inits. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2328385286\" data-permission-text=\"Title is private\" data-url=\"https://github.com/carbon-language/carbon-lang/issues/4013\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/carbon-language/carbon-lang/pull/4013/hovercard\" href=\"https://github.com/carbon-language/carbon-lang/pull/4013\">#4013</a>)"}},{"before":null,"after":"517a416852c0f70111d8a2fe25a78035735ad93c","ref":"refs/heads/gh-readonly-queue/trunk/pr-4013-3c01ee69ed13185f0477c75189283aaebe68ab17","pushedAt":"2024-05-31T23:24:02.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Clean up some misc toolchain braced inits. (#4013)\n\nFollowing up on #4012 and #4009, clean scattered cases which could be\nmaking better use of designated initializers.","shortMessageHtmlLink":"Clean up some misc toolchain braced inits. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2328385286\" data-permission-text=\"Title is private\" data-url=\"https://github.com/carbon-language/carbon-lang/issues/4013\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/carbon-language/carbon-lang/pull/4013/hovercard\" href=\"https://github.com/carbon-language/carbon-lang/pull/4013\">#4013</a>)"}},{"before":"3c01ee69ed13185f0477c75189283aaebe68ab17","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4001-5bb318cae6d64beb6802f7047ca2190ae7206f70","pushedAt":"2024-05-31T23:23:47.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"5bb318cae6d64beb6802f7047ca2190ae7206f70","after":"3c01ee69ed13185f0477c75189283aaebe68ab17","ref":"refs/heads/trunk","pushedAt":"2024-05-31T23:23:46.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Move information on the token associated with a parse node from the `.def` file into the typed node. (#4001)\n\nInstead of tracking the token associated with a parse node in the `.def`\nfile macro, track it on the typed node instead. List the token as a\nfield inside the node structure to show the order of the token relative\nto the other components of the grammar production, and to allow the\ntoken index to be accessed when the node is extracted.\n\nRemove the corresponding information from the `.def` file, leaving\nbehind just a list of parse node kinds in the majority of cases.\n\nThis also removes the checking of the token kind associated with a parse\nnode in the case where the parse node has errors. Previously we had a\nflag on the node kind to indicate whether we should check this, but per\n[discord\ndiscussion](https://discord.com/channels/655572317891461132/655578254970716160/1246214418979881052),\nwe have decided to remove this.\n\n---------\n\nCo-authored-by: Jon Ross-Perkins <jperkins@google.com>","shortMessageHtmlLink":"Move information on the token associated with a parse node from the `…"}},{"before":null,"after":"3c01ee69ed13185f0477c75189283aaebe68ab17","ref":"refs/heads/gh-readonly-queue/trunk/pr-4001-5bb318cae6d64beb6802f7047ca2190ae7206f70","pushedAt":"2024-05-31T23:12:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Move information on the token associated with a parse node from the `.def` file into the typed node. (#4001)\n\nInstead of tracking the token associated with a parse node in the `.def`\nfile macro, track it on the typed node instead. List the token as a\nfield inside the node structure to show the order of the token relative\nto the other components of the grammar production, and to allow the\ntoken index to be accessed when the node is extracted.\n\nRemove the corresponding information from the `.def` file, leaving\nbehind just a list of parse node kinds in the majority of cases.\n\nThis also removes the checking of the token kind associated with a parse\nnode in the case where the parse node has errors. Previously we had a\nflag on the node kind to indicate whether we should check this, but per\n[discord\ndiscussion](https://discord.com/channels/655572317891461132/655578254970716160/1246214418979881052),\nwe have decided to remove this.\n\n---------\n\nCo-authored-by: Jon Ross-Perkins <jperkins@google.com>","shortMessageHtmlLink":"Move information on the token associated with a parse node from the `…"}},{"before":"5bb318cae6d64beb6802f7047ca2190ae7206f70","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4012-6e9d0b15c83915b7fc1bfa3f4fd3d4c227fa6f9b","pushedAt":"2024-05-31T23:00:33.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"6e9d0b15c83915b7fc1bfa3f4fd3d4c227fa6f9b","after":"5bb318cae6d64beb6802f7047ca2190ae7206f70","ref":"refs/heads/trunk","pushedAt":"2024-05-31T23:00:32.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Switch AddInst struct init style. (#4012)\n\nTrying to conform with #4009. Changes SemIR::LocIdAndInst construction\nto root out struct init cases with AddInst and related functions. I'm\nusing templating of AddInst functions in order to avoid `AddInst(loc_id,\nInstName{...})` and instead have `AddInst<InstName>(loc_id, {...})` with\nI think similar readability results. There are a couple cases where inst\nconstruction is templated and so designated initializers couldn't be\nused, so this may be better for those in particular due to the extra\ntype enforcement.\n\nThis probably doesn't clean up every last case, but I was trying to get\nthe bulk at once without bleeding over into less related changes.\n\n---------\n\nCo-authored-by: Richard Smith <richard@metafoo.co.uk>","shortMessageHtmlLink":"Switch AddInst struct init style. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2328341519\" data-permission-text=\"Title is private\" data-url=\"https://github.com/carbon-language/carbon-lang/issues/4012\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/carbon-language/carbon-lang/pull/4012/hovercard\" href=\"https://github.com/carbon-language/carbon-lang/pull/4012\">#4012</a>)"}},{"before":null,"after":"5bb318cae6d64beb6802f7047ca2190ae7206f70","ref":"refs/heads/gh-readonly-queue/trunk/pr-4012-6e9d0b15c83915b7fc1bfa3f4fd3d4c227fa6f9b","pushedAt":"2024-05-31T22:50:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Switch AddInst struct init style. (#4012)\n\nTrying to conform with #4009. Changes SemIR::LocIdAndInst construction\nto root out struct init cases with AddInst and related functions. I'm\nusing templating of AddInst functions in order to avoid `AddInst(loc_id,\nInstName{...})` and instead have `AddInst<InstName>(loc_id, {...})` with\nI think similar readability results. There are a couple cases where inst\nconstruction is templated and so designated initializers couldn't be\nused, so this may be better for those in particular due to the extra\ntype enforcement.\n\nThis probably doesn't clean up every last case, but I was trying to get\nthe bulk at once without bleeding over into less related changes.\n\n---------\n\nCo-authored-by: Richard Smith <richard@metafoo.co.uk>","shortMessageHtmlLink":"Switch AddInst struct init style. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2328341519\" data-permission-text=\"Title is private\" data-url=\"https://github.com/carbon-language/carbon-lang/issues/4012\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/carbon-language/carbon-lang/pull/4012/hovercard\" href=\"https://github.com/carbon-language/carbon-lang/pull/4012\">#4012</a>)"}},{"before":"6e9d0b15c83915b7fc1bfa3f4fd3d4c227fa6f9b","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4011-97d6446babffc30ed8080ad77a5d415cd8d6ba51","pushedAt":"2024-05-31T22:40:31.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"97d6446babffc30ed8080ad77a5d415cd8d6ba51","after":"6e9d0b15c83915b7fc1bfa3f4fd3d4c227fa6f9b","ref":"refs/heads/trunk","pushedAt":"2024-05-31T22:40:30.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Switch eval.cpp struct init style. (#4011)\n\nAdding designators in general consistent with #4009\n\nWith MakeConstantResult, leaning towards keeping\n`SemIR::BoolLiteral{...}` rather than templating `MakeConstantResult` in\norder to avoid having multiple `MakeConstantResult` implementations\nstamped out. But with `TypedInt`, removing the name since it's not\nnecessary for compile.\n\nNote, will be updating other files separately, just starting here since\nMakeConstantResult might be a bit of an edge case (with AddInst, I might\ngo slightly more for a wrapper).","shortMessageHtmlLink":"Switch eval.cpp struct init style. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2328215264\" data-permission-text=\"Title is private\" data-url=\"https://github.com/carbon-language/carbon-lang/issues/4011\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/carbon-language/carbon-lang/pull/4011/hovercard\" href=\"https://github.com/carbon-language/carbon-lang/pull/4011\">#4011</a>)"}},{"before":null,"after":"6e9d0b15c83915b7fc1bfa3f4fd3d4c227fa6f9b","ref":"refs/heads/gh-readonly-queue/trunk/pr-4011-97d6446babffc30ed8080ad77a5d415cd8d6ba51","pushedAt":"2024-05-31T22:35:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Switch eval.cpp struct init style. (#4011)\n\nAdding designators in general consistent with #4009\n\nWith MakeConstantResult, leaning towards keeping\n`SemIR::BoolLiteral{...}` rather than templating `MakeConstantResult` in\norder to avoid having multiple `MakeConstantResult` implementations\nstamped out. But with `TypedInt`, removing the name since it's not\nnecessary for compile.\n\nNote, will be updating other files separately, just starting here since\nMakeConstantResult might be a bit of an edge case (with AddInst, I might\ngo slightly more for a wrapper).","shortMessageHtmlLink":"Switch eval.cpp struct init style. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2328215264\" data-permission-text=\"Title is private\" data-url=\"https://github.com/carbon-language/carbon-lang/issues/4011\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/carbon-language/carbon-lang/pull/4011/hovercard\" href=\"https://github.com/carbon-language/carbon-lang/pull/4011\">#4011</a>)"}},{"before":"97d6446babffc30ed8080ad77a5d415cd8d6ba51","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4015-cdc0ca14ec113ed7da05340a37155a4ddd477720","pushedAt":"2024-05-31T22:11:57.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"cdc0ca14ec113ed7da05340a37155a4ddd477720","after":"97d6446babffc30ed8080ad77a5d415cd8d6ba51","ref":"refs/heads/trunk","pushedAt":"2024-05-31T22:11:56.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Clean up struct init for the TokenizedBuffer test. (#4015)\n\nMostly structs, but note one fix for StringRef init. This is rooted in\n#4009","shortMessageHtmlLink":"Clean up struct init for the TokenizedBuffer test. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2328626083\" data-permission-text=\"Title is private\" data-url=\"https://github.com/carbon-language/carbon-lang/issues/4015\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/carbon-language/carbon-lang/pull/4015/hovercard\" href=\"https://github.com/carbon-language/carbon-lang/pull/4015\">#4015</a>)"}},{"before":null,"after":"97d6446babffc30ed8080ad77a5d415cd8d6ba51","ref":"refs/heads/gh-readonly-queue/trunk/pr-4015-cdc0ca14ec113ed7da05340a37155a4ddd477720","pushedAt":"2024-05-31T22:07:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Clean up struct init for the TokenizedBuffer test. (#4015)\n\nMostly structs, but note one fix for StringRef init. This is rooted in\n#4009","shortMessageHtmlLink":"Clean up struct init for the TokenizedBuffer test. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2328626083\" data-permission-text=\"Title is private\" data-url=\"https://github.com/carbon-language/carbon-lang/issues/4015\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/carbon-language/carbon-lang/pull/4015/hovercard\" href=\"https://github.com/carbon-language/carbon-lang/pull/4015\">#4015</a>)"}},{"before":"cdc0ca14ec113ed7da05340a37155a4ddd477720","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4009-7e81c1710e75ef6baaeb95b544d0a3936b818f3e","pushedAt":"2024-05-31T16:26:22.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"7e81c1710e75ef6baaeb95b544d0a3936b818f3e","after":"cdc0ca14ec113ed7da05340a37155a4ddd477720","ref":"refs/heads/trunk","pushedAt":"2024-05-31T16:26:21.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Be a little more prescriptive about {} initialization in style. (#4009)\n\nFollowing discussions around #3958, try to provide more specific\nsemantics. Note we currently don't follow this everywhere, particularly\nin AddInst calls, but the intent is to shift. Per discussion, designated\ninitializers are preferred when possible. And the\n`google-readability-casting` diagnostics are poor, but with this may\nprimarily flag cases which should be using a different constructor\nsyntax, so are just a rocky way to get there.\n\n---------\n\nCo-authored-by: Richard Smith <richard@metafoo.co.uk>","shortMessageHtmlLink":"Be a little more prescriptive about {} initialization in style. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2326631324\" data-permission-text=\"Title is private\" data-url=\"https://github.com/carbon-language/carbon-lang/issues/4009\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/carbon-language/carbon-lang/pull/4009/hovercard\" href=\"https://github.com/carbon-language/carbon-lang/pull/4009\">#4009</a>)"}},{"before":null,"after":"cdc0ca14ec113ed7da05340a37155a4ddd477720","ref":"refs/heads/gh-readonly-queue/trunk/pr-4009-7e81c1710e75ef6baaeb95b544d0a3936b818f3e","pushedAt":"2024-05-31T16:22:41.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Be a little more prescriptive about {} initialization in style. (#4009)\n\nFollowing discussions around #3958, try to provide more specific\nsemantics. Note we currently don't follow this everywhere, particularly\nin AddInst calls, but the intent is to shift. Per discussion, designated\ninitializers are preferred when possible. And the\n`google-readability-casting` diagnostics are poor, but with this may\nprimarily flag cases which should be using a different constructor\nsyntax, so are just a rocky way to get there.\n\n---------\n\nCo-authored-by: Richard Smith <richard@metafoo.co.uk>","shortMessageHtmlLink":"Be a little more prescriptive about {} initialization in style. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2326631324\" data-permission-text=\"Title is private\" data-url=\"https://github.com/carbon-language/carbon-lang/issues/4009\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/carbon-language/carbon-lang/pull/4009/hovercard\" href=\"https://github.com/carbon-language/carbon-lang/pull/4009\">#4009</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWZOIFgA","startCursor":null,"endCursor":null}},"title":"Activity · carbon-language/carbon-lang"}