{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":1181927,"defaultBranch":"master","name":"bitcoin","ownerLogin":"bitcoin","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-12-19T15:16:43.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/528860?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716978741.0","currentOid":""},"activityList":{"items":[{"before":"2ad6e8efa3b4bc828ecca982e5a9f0e4470b5098","after":"a44b0f771f2130b89b608f39055a355693c91a8c","ref":"refs/heads/master","pushedAt":"2024-06-08T08:33:53.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30238: json-rpc 2.0 followups: docs, tests, cli\n\n1f6ab1215bbb1f8a5f1743c3c413b95ad08090df minor: remove unnecessary semicolons from RPC content type examples (Matthew Zipkin)\nb22529529823c0cb5916ac318c8536e9107b7e78 test: use json-rpc 2.0 in all functional tests by default (Matthew Zipkin)\n391843b0297db03d71a8d88ab77609e2ad230bf2 bitcoin-cli: use json-rpc 2.0 (Matthew Zipkin)\nd39bdf339772166a5545ae811e58b7764af093a8 test: remove unused variable in interface_rpc.py (Matthew Zipkin)\n0ead71df8c83a2f9eae1220544ec84dcf38a0326 doc: update and link for JSON-RPC 2.0 (Matthew Zipkin)\n\nPull request description:\n\n This is a follow-up to #27101.\n\n - Addresses [post-merge comments ](https://github.com/bitcoin/bitcoin/pull/27101#discussion_r1606723428)\n - bitcoin-cli uses JSON-RPC 2.0\n - functional tests use JSON-RPC 2.0 by default (exceptions are in the regression tests added by #27101)\n\nACKs for top commit:\n tdb3:\n ACK 1f6ab1215bbb1f8a5f1743c3c413b95ad08090df\n cbergqvist:\n ACK 1f6ab1215bbb1f8a5f1743c3c413b95ad08090df\n\nTree-SHA512: 49bf14c70464081280216ece538a2f5ec810bac80a86a83ad3284f0f1b017edf755a1a74a45be279effe00218170cafde7c2de58aed07097a95c2c6b837a6b6c","shortMessageHtmlLink":"Merge #30238: json-rpc 2.0 followups: docs, tests, cli"}},{"before":"6e4d18f37f42894fe9a0d7948c1da3f061fc6b60","after":"2ad6e8efa3b4bc828ecca982e5a9f0e4470b5098","ref":"refs/heads/master","pushedAt":"2024-06-08T08:29:44.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30231: guix: bump time-machine to f0bb724211872cd6158fce6162e0b8c73efed126\n\n2599655c1fb8e7d0b8407d2be249977372cb73ff guix: bump time-machine to f0bb724211872cd6158fce6162e0b8c73efed126 (fanquake)\n\nPull request description:\n\n Includes:\n LLVM 18.1.x (#30201)\n GCC 13.x (#29881)\n\n git-minimal 2.41.0 -> 2.45.1\n Kernel Headers 6.1.80 -> 6.1.92\n moreutils 0.68 -> 0.69\n\n Commits like https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7b0f145802f0c2c785014293d748721678fef824, which should improve the bootstrap situation (#30042). This can somewhat be visualised by comparing the (simplified) dependencies of guix itself, between the two time-machines.\n\n Master:\n \n\n PR:\n \n\n Note that in the case of this PR, we are better off, no-longer having to build a number of tex packages, ruby, cairo, graphics libs, openssl 1.x etc.\n\nACKs for top commit:\n TheCharlatan:\n ACK 2599655c1fb8e7d0b8407d2be249977372cb73ff\n\nTree-SHA512: 9c5675a5d563c17744c89c8a392bc7865aa1c9e71a5e3044c23f31e51458dac28c0c238d2055c86dc732df595dae60bcbc8b85266b23b7991c4c770d56f7d23a","shortMessageHtmlLink":"Merge #30231: guix: bump time-machine to f0bb724211872cd6158fce6162e0…"}},{"before":"feab35189bc00bc4cf15e9dcb5cf6b34ff3a1e91","after":"6e4d18f37f42894fe9a0d7948c1da3f061fc6b60","ref":"refs/heads/master","pushedAt":"2024-06-07T16:30:55.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29496: policy: bump TX_MAX_STANDARD_VERSION to 3\n\n30a01134cdec37e7467fcd6eee8b0ae3890a131c [doc] update bips.md for 431 (glozow)\n9dbe6a03f0d6e70ccdf8e8715f888c0c17216bee [test] wallet uses CURRENT_VERSION which is 2 (glozow)\n539404fe0fc0346b3aa77c330b38a5a0ad6565b2 [policy] make v3 transactions standard (glozow)\n052ede75aff5c9f3a0a422ef413852eabeecc665 [refactor] use TRUC_VERSION in place of 3 (glozow)\n\nPull request description:\n\n Make `nVersion=3` (which is currently nonstandard on mainnet) standard.\n\n Note that we will treat these transactions as Topologically Restricted Until Confirmation (TRUC). Spec is in BIP 431 and implementation is in #28948, #29306, and #29873\n\n See #27463 for overall project tracking, and #29319 for information about relevance to cluster mempool.\n\nACKs for top commit:\n sdaftuar:\n utACK 30a01134c\n achow101:\n ACK 30a01134cdec37e7467fcd6eee8b0ae3890a131c\n instagibbs:\n utACK 30a01134cdec37e7467fcd6eee8b0ae3890a131c\n murchandamus:\n ACK 30a01134cdec37e7467fcd6eee8b0ae3890a131c\n ismaelsadeeq:\n ACK 30a01134cdec37e7467fcd6eee8b0ae3890a131c 🛰️\n\nTree-SHA512: 2a4aec0442c860e792a061d83e36483c1f1b426f946efbdf664c8db97a596e498b535707e1d3a900218429486ea69fd4552e3d476526a6883cbd5556c6534b48","shortMessageHtmlLink":"Merge #29496: policy: bump TX_MAX_STANDARD_VERSION to 3"}},{"before":"4a020ca443ba370bf41583962d16aa8551876f53","after":"feab35189bc00bc4cf15e9dcb5cf6b34ff3a1e91","ref":"refs/heads/master","pushedAt":"2024-06-07T13:33:19.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"glozow","name":"Gloria Zhao","path":"/glozow","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25183001?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30161: util: add VecDeque\n\n7b8eea067f188c0b0e52ef21b01aedd37667a237 tests: add fuzz tests for VecDeque (Pieter Wuille)\n62fd24af6a3fe1569662c2802f59bb68a0172087 util: add VecDeque (Pieter Wuille)\n\nPull request description:\n\n Extracted from #30126.\n\n This adds a `VecDeque` data type, inspired by `std::deque`, but backed by a single allocated memory region used as a ring buffer instead of a linked list of arrays. This gives better memory locality and less allocation overhead, plus better guarantees (some C++ standard library implementations, though not libstdc++ and libc++, use a separate allocation per element in a deque).\n\n It is intended for the candidate set search queue in #30126, but may be useful as a replacement for `std::deque` in other places too. It's not a full drop-in replacement, as I did not add iteration support which is unnecessary for the intended use case, but nothing prevents adding that if needed.\n\n Everything is tested through a simulation-based fuzz test that compares the behavior with normal `std::deque` equivalent operations, both for trivially-copyable/destructible types and others.\n\nACKs for top commit:\n instagibbs:\n reACK https://github.com/bitcoin/bitcoin/pull/30161/commits/7b8eea067f188c0b0e52ef21b01aedd37667a237\n cbergqvist:\n re-ACK 7b8eea067f188c0b0e52ef21b01aedd37667a237\n hebasto:\n re-ACK 7b8eea067f188c0b0e52ef21b01aedd37667a237, I've verified changes since my recent [review](https://github.com/bitcoin/bitcoin/pull/30161#pullrequestreview-2103018546) with\n glozow:\n ACK 7b8eea067f\n\nTree-SHA512: 1b62f3ba1a43a1293d8c9de047e2399442e74c46de2df81406151fe27538716ce265f35fb6779ee56d77a39cddf8fb4b4e15bda8f04ebf3b149e2f05fa55cb21","shortMessageHtmlLink":"Merge #30161: util: add VecDeque"}},{"before":"1040a1fc807ed984020eeaa6e90b5bf070b61b05","after":"4a020ca443ba370bf41583962d16aa8551876f53","ref":"refs/heads/master","pushedAt":"2024-06-06T23:19:06.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29401: test: Remove struct.pack from almost all places\n\nfa52e13ee81fcc7543890dbd6986fcb55168583f test: Remove struct.pack from almost all places (MarcoFalke)\nfa826db477a981b48bff53021f9695a5f6682dc0 scripted-diff: test: Use int.to_bytes over struct packing (MarcoFalke)\nfaf2a975ad46799d075e3a70c699da0d8182aab9 test: Use int.to_bytes over struct packing (MarcoFalke)\nfaf3cd659a72473a1aa73c4367a145f4ec64f146 test: Normalize struct.pack format (MarcoFalke)\n\nPull request description:\n\n `struct.pack` has many issues:\n\n * The format string consists of characters that may be confusing and may need to be looked up in the documentation, as opposed to using easy to understand self-documenting code.\n\n This lead to many test bugs, which weren't hit, which is fine, but still confusing. Ref: https://github.com/bitcoin/bitcoin/pull/29400, https://github.com/bitcoin/bitcoin/pull/29399, https://github.com/bitcoin/bitcoin/pull/29363, fa3886b7c69cbbe564478f30bb2c35e9e6b1cffa, ...\n\n Fix all issues by using the built-in `int` helpers `to_bytes` via a scripted diff.\n\n Review notes:\n\n * For `struct.pack` and `int.to_bytes` the error behavior is the same, although the error messages are not identical.\n * Two `struct.pack` remain. One for float serialization in a C++ code comment, and one for native serialization.\n\nACKs for top commit:\n achow101:\n ACK fa52e13ee81fcc7543890dbd6986fcb55168583f\n rkrux:\n tACK [fa52e13](https://github.com/bitcoin/bitcoin/pull/29401/commits/fa52e13ee81fcc7543890dbd6986fcb55168583f)\n theStack:\n Code-review ACK fa52e13ee81fcc7543890dbd6986fcb55168583f\n\nTree-SHA512: ee80d935b68ae43d1654b047e84ceb80abbd20306df35cca848b3f7874634b518560ddcbc7e714e2e7a19241e153dee64556dc4701287ae811e26e4f8c57fe3e","shortMessageHtmlLink":"Merge #29401: test: Remove struct.pack from almost all places"}},{"before":"f47cd649e970b37fcd1fc31bbadaebf49566ee73","after":"1040a1fc807ed984020eeaa6e90b5bf070b61b05","ref":"refs/heads/master","pushedAt":"2024-06-06T09:59:31.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30228: build: no-longer allow GCC-10 in C++20 check\n\n232928b58a82e3f15307deba1ae921ae2960ccc8 build: no-longer allow GCC-10 in C++20 check (fanquake)\n\nPull request description:\n\n Reverts part of fa67f096bdea9db59dd20c470c9e32f3dac5be94, now that we require a minimum of GCC 11.\n\n See also:\n https://github.com/bitcoin/bitcoin/pull/28349#issuecomment-1745143612.\n\nACKs for top commit:\n maflcko:\n utACK 232928b58a82e3f15307deba1ae921ae2960ccc8\n theuni:\n utACK 232928b58a82e3f15307deba1ae921ae2960ccc8\n\nTree-SHA512: 10e0adac2dd6e455aaf97ebfe73c7586430349fc27ac435bc6c0d99a4934a380398d14467aacd9cedf371345da291366b3ab2c3be7db5d97e21ad6212b2c7890","shortMessageHtmlLink":"Merge #30228: build: no-longer allow GCC-10 in C++20 check"}},{"before":"ff7d2054c4f1d7ff98078b9695e7c36e79a476c6","after":"f47cd649e970b37fcd1fc31bbadaebf49566ee73","ref":"refs/heads/master","pushedAt":"2024-06-06T09:49:41.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30236: build: re-enable deprecated warning copy\n\nc3a5e8a0639ff2505adb4a4e7776db87d5ebafd3 build: re-enable deprecated warning copy (Cory Fields)\n\nPull request description:\n\n Noticed while looking at the `-wno-*` flags in #30235.\n\n This was disabled in #18738 due to the combo of old gcc and qt. We no longer support the affected gcc, and the old qt should no longer be relevant to us anyway.\n\n See old fixes in:\n https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88136\n and\n https://bugreports.qt.io/browse/QTBUG-75210\n and\n https://codereview.qt-project.org/c/qt/qtbase/+/245434\n\nACKs for top commit:\n maflcko:\n ACK c3a5e8a0639ff2505adb4a4e7776db87d5ebafd3\n fanquake:\n ACK c3a5e8a0639ff2505adb4a4e7776db87d5ebafd3 - this is in `-Wextra` for Clang and GCC.\n\nTree-SHA512: bd008dc50134d15ca3bb0c4f78d910db5b7a0ee98b04c159122a6f13a24b18827806492f053293d9cc1f1528ba60dea6d9ed31a366f63840ccb7c55f002d263b","shortMessageHtmlLink":"Merge #30236: build: re-enable deprecated warning copy"}},{"before":"74dc8585b38df405ab78018a4faaa4a25f8fc7a4","after":"ff7d2054c4f1d7ff98078b9695e7c36e79a476c6","ref":"refs/heads/master","pushedAt":"2024-06-05T10:40:52.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30185: guix: show `*_FLAGS` variables in pre-build output\n\n5f2c1d84e37697f4f8a20e3c12f37bba71b3c2a6 guix: show *_FLAGS variables in pre-build output (fanquake)\n\nPull request description:\n\n For example:\n ```bash\n # ADDITIONAL_GUIX_COMMON_FLAGS set in the ENV\n ADDITIONAL_GUIX_ENVIRONMENT_FLAGS=\"--emulate-fhs\" ./contrib/guix/guix-build\n \n INFO: Building f751991 for platform triple x86_64-linux-gnu:\n ...using reference timestamp: 1716905119\n ...running at most 10 jobs\n ...from worktree directory: '/bitcoin'\n ...bind-mounted in container to: '/bitcoin'\n ...in build directory: '/bitcoin/guix-build-f75199182133/distsrc-f75199182133-x86_64-linux-gnu'\n ...bind-mounted in container to: '/distsrc-base/distsrc-f75199182133-x86_64-linux-gnu'\n ...outputting in: '/bitcoin/guix-build-f75199182133/output/x86_64-linux-gnu'\n ...bind-mounted in container to: '/outdir-base/x86_64-linux-gnu'\n ADDITIONAL FLAGS (if set)\n ADDITIONAL_GUIX_COMMON_FLAGS: --no-substitutes\n ADDITIONAL_GUIX_ENVIRONMENT_FLAGS: --emulate-fhs\n ADDITIONAL_GUIX_TIMEMACHINE_FLAGS:\n ```\n\nACKs for top commit:\n hebasto:\n ACK 5f2c1d84e37697f4f8a20e3c12f37bba71b3c2a6.\n\nTree-SHA512: 85a6d508499b4ec1d6166343a1707b682d327b2fcfb2fb438571894478aac0062d21e1239b5092091ff98711c5c747151973c4f325a7a7c447d0e807166fcb07","shortMessageHtmlLink":"Merge #30185: guix: show *_FLAGS variables in pre-build output"}},{"before":"23b3dc2dd13dc9bf13790a87b046a64cbbfccc43","after":"74dc8585b38df405ab78018a4faaa4a25f8fc7a4","ref":"refs/heads/master","pushedAt":"2024-06-05T10:37:20.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30174: test: Set mocktime in p2p_disconnect_ban.py to avoid intermittent test failure\n\n4444de152f01368e603f2b089679a86eae02e34a test: Set mocktime in p2p_disconnect_ban.py to avoid intermittent test failure (MarcoFalke)\nfa6aa4027cecd819c1210d6959af364d5bf9f608 test: Fix typos and use names args (MarcoFalke)\n\nPull request description:\n\n Otherwise, the test may fail on slow hardware when running in valgrind.\n\n Also, use named args for the absolute timepoint, while touching this file.\n\nACKs for top commit:\n tdb3:\n ACK for 4444de152f01368e603f2b089679a86eae02e34a\n AngusP:\n re-ACK 4444de152f01368e603f2b089679a86eae02e34a\n\nTree-SHA512: 660269c8dd18887d69b284f38656899caf028159ce83ddf921f3e9c080a5d0e663989f0e42b4baf4c4939f20f34da0e7e844dff9b7c91d0cab570c60958bd0e1","shortMessageHtmlLink":"Merge #30174: test: Set mocktime in p2p_disconnect_ban.py to avoid in…"}},{"before":"c29314ecfcc09db4f3d3656a825c13158974578c","after":"23b3dc2dd13dc9bf13790a87b046a64cbbfccc43","ref":"refs/heads/master","pushedAt":"2024-06-05T01:57:52.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30218: refactor: remove unused `CKey::Negate` method\n\n8801e319d51209fe3a3b06e2aab5f96ceead290d refactor: remove unused `CKey::Negate` method (Sebastian Falbesoner)\n\nPull request description:\n\n This method was introduced as a pre-requirement for the v2 transport protocol back then (see PR #14047, commit 463921bb), when it was still BIP151. With the replacement BIP324, this is not needed anymore, and it's also unlikely that for any other proposal we'd ever need to negate private keys at this abstraction level. I'd argue that this operation is usually something that should happen within a secp256k1 module (like e.g. done in MuSig2, Silent Payments...).\n\n (If there is really demand in the future, it's also trivial to reintroduce the method.)\n\nACKs for top commit:\n laanwj:\n ACK 8801e319d51209fe3a3b06e2aab5f96ceead290d\n sipa:\n ACK 8801e319d51209fe3a3b06e2aab5f96ceead290d\n achow101:\n ACK 8801e319d51209fe3a3b06e2aab5f96ceead290d\n\nTree-SHA512: 7bc1566399635c5c6e4940a2724c865d5443eb190024379099330c023c516f1e4f423ed9e8c42bc93413b723a5464ec79d3f879f58c0e598fe24f495238df4ec","shortMessageHtmlLink":"Merge #30218: refactor: remove unused CKey::Negate method"}},{"before":"76a33be21d4243f9e8f18c164f776adf7c99a56c","after":"c29314ecfcc09db4f3d3656a825c13158974578c","ref":"refs/heads/master","pushedAt":"2024-06-05T01:47:31.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29998: functional test: ensure confirmed utxo being sourced for 2nd chain\n\n07aba8dd215b23b06853b1a9fe04ac8b08f62932 functional test: ensure confirmed utxo being sourced for 2nd chain (Greg Sanders)\n\nPull request description:\n\n The test could fail/stop testing what we want if non-confirmed utxos become sourced through some internal change to `MiniWallet`; better to just fetch confirmed explicitly.\n\nACKs for top commit:\n achow101:\n ACK 07aba8dd215b23b06853b1a9fe04ac8b08f62932\n ismaelsadeeq:\n utACK 07aba8dd215b23b06853b1a9fe04ac8b08f62932\n theStack:\n ACK 07aba8dd215b23b06853b1a9fe04ac8b08f62932\n\nTree-SHA512: 66795fdf881139ed91bde0f8239a46bd9bc70bb311fa97c0e2b5537e1fd2a1fd36bf3a225fc77b9695deb835a9d6d29879aa1e05ea5054b9a33a400e199da014","shortMessageHtmlLink":"Merge #29998: functional test: ensure confirmed utxo being sourced fo…"}},{"before":"b3a61bd7b10211124613d18a524ec86781a30e9e","after":"76a33be21d4243f9e8f18c164f776adf7c99a56c","ref":"refs/heads/master","pushedAt":"2024-06-05T01:40:04.000Z","pushType":"push","commitsCount":11,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#28307: rpc, wallet: fix incorrect segwit redeem script size limit\n\n2451a217dd2c21b6d2f2b2699ceddd0bf9073019 test: addmultisigaddress, coverage for script size limits (furszy)\n53302a09817e5b799d345dfea432546a55a9d727 bugfix: addmultisigaddress, add unsupported operation for redeem scripts over 520 bytes (furszy)\n9be6065cc03f2408f290a332b203eef9c9cebf24 test: coverage for 16-20 segwit multisig scripts (furszy)\n9d9a91c4ea6b3bb32ef4131bca86f1d6683fc901 rpc: bugfix, incorrect segwit redeem script size used in signrawtransactionwithkey (furszy)\n0c9fedfc45fa7cbd6801ca5fd756863ec9a6911c fix incorrect multisig redeem script size limit for segwit (furszy)\nf7a173b5785cda460470df9a74a0e0f94d7f9a18 test: rpc_createmultisig, decouple 'test_sortedmulti_descriptors_bip67' (furszy)\n4f33dbd8f8c0e29f37b04e6af6d2c7905ecceaf6 test: rpc_createmultisig, decouple 'test_mixing_uncompressed_and_compressed_keys' (furszy)\n25a81705d376e8c96dad45436ae3fca975b3daf5 test: rpc_createmultisig, remove unnecessary checkbalances() (furszy)\nb5a328943362cfac6e90fd4e1b167c357d53b7d4 test: refactor, multiple cleanups in rpc_createmultisig.py (furszy)\n3635d432681847313c098f9827483372a840e70f test: rpc_createmultisig, remove manual wallet initialization (furszy)\n\nPull request description:\n\n Fixing https://github.com/bitcoin/bitcoin/issues/28250#issuecomment-1674830104 and more.\n\n Currently, redeem scripts longer than 520 bytes, which are technically valid under segwit rules, have flaws in the following processes:\n 1) The multisig creation process fails to deduce the output descriptor, resulting in the generation of an incorrect descriptor. Additionally, the accompanying user warning is also inaccurate.\n 2) The `signrawtransactionwithkey` RPC command fail to sign them.\n 3) The legacy wallet `addmultisigaddress` wrongly discards them.\n\n The issue arises because most of these flows are utilizing the legacy spkm keystore, which imposes\n the [p2sh max redeem script size rule](https://github.com/bitcoin/bitcoin/blob/ded687334031f4790ef6a36b999fb30a79dcf7b3/src/script/signingprovider.cpp#L160) on all scripts. Which blocks segwit redeem scripts longer than\n the max element size in all the previously mentioned processes (`createmultisig`, `addmultisigaddress`, and\n `signrawtransactionwithkey`).\n\n This PR fixes the problem, enabling the creation of multisig output descriptors involving more than 15 keys and\n allowing the signing of these scripts, along with other post-segwit redeem scripts that surpass the 520-byte\n p2sh limit.\n\n Important note:\n Instead of adding support for these longer redeem scripts in the legacy wallet, an \"unsupported operation\"\n error has been added. The reasons behind this decision are:\n\n 1) The introduction of this feature brings about a compatibility-breaking change that requires downgrade\n protection; older wallets would be unable to interact with these \"new\" legacy wallets.\n\n 2) Considering the ongoing deprecation of the legacy spkm, this issue provides another compelling\n reason to transition towards descriptors.\n\n Testing notes:\n To easily verify each of the fixes, I decoupled the tests into standalone commits. So they can be\n cherry-picked on top of master. Where `rpc_createmultisig.py` (with and without the `--legacy-wallet`\n arg) will fail without the bugs fixes commits.\n\n Extra note:\n The initial commits improves the `rpc_createmultisig.py` test in many ways. I found this test very\n antiquated, screaming for an update and cleanup.\n\nACKs for top commit:\n pinheadmz:\n ACK 2451a217dd2c21b6d2f2b2699ceddd0bf9073019\n theStack:\n Code-review ACK 2451a217dd2c21b6d2f2b2699ceddd0bf9073019\n achow101:\n ACK 2451a217dd2c21b6d2f2b2699ceddd0bf9073019\n\nTree-SHA512: 71794533cbd46b3a1079fb4e9d190d3ea3b615de0cbfa443466e14f05e4616ca90e12ce2bf07113515ea8113e64a560ad572bb9ea9d4835b6fb67b6ae596167f","shortMessageHtmlLink":"Merge #28307: rpc, wallet: fix incorrect segwit redeem script size limit"}},{"before":"55cf34a5c30f1aee0737b48fa2814996359eca89","after":"b3a61bd7b10211124613d18a524ec86781a30e9e","ref":"refs/heads/master","pushedAt":"2024-06-05T01:26:58.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#28074: fuzz: wallet, add target for `Crypter`\n\nd7290d662f494503f28e087dd728b492c0bb2c5f fuzz: wallet, add target for Crypter (Ayush Singh)\n\nPull request description:\n\n This PR adds fuzz coverage for `wallet/crypter`.\n\n Motivation: Issue [27272](https://github.com/bitcoin/bitcoin/issues/27272#issue-1628327906)\n\n I ran this for a long time with Sanitizers on and had no crashes; the average `exec/sec` also looks good to me. However, I would really appreciate it if some of the reviewers could try it on their machines too, and give their feedback.\n\nACKs for top commit:\n maflcko:\n utACK d7290d662f494503f28e087dd728b492c0bb2c5f\n achow101:\n ACK d7290d662f494503f28e087dd728b492c0bb2c5f\n brunoerg:\n utACK d7290d662f494503f28e087dd728b492c0bb2c5f\n\nTree-SHA512: f5c496cabdd3263a7e1ad49eeff702725336f76bf19a82e5dbbead082e990889dd43c851d0d2d6ab740f44b8ec2aa06defd9ff6b02be68b5f8b4eaf963f88599","shortMessageHtmlLink":"Merge #28074: fuzz: wallet, add target for Crypter"}},{"before":"09fe1435d9cae5d32fa4e24042d7a862b7c7bf22","after":"55cf34a5c30f1aee0737b48fa2814996359eca89","ref":"refs/heads/master","pushedAt":"2024-06-05T00:32:41.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30047: refactor: Model the bech32 charlimit as an Enum\n\n7f3f6c6dc80247e6dfb0d406dc53bc8198f029fd refactor: replace hardcoded numbers (Lőrinc)\n5676aec1e1a6d2c6fd3099e120e263a0a7def089 refactor: Model the bech32 charlimit as an Enum (josibake)\n\nPull request description:\n\n Broken out from #28122\n\n ---\n\n Bech32(m) was defined with a 90 character limit so that certain guarantees for error detection could be made for segwit addresses (see https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki#checksum-design).\n\n However, there is nothing about the encoding scheme itself that requires a limit of 90 and in practice bech32(m) is being used without the 90 char limit (e.g. lightning invoices, silent payments). Further, increasing the character limit doesn't do away with error detection, it simply changes the guarantee.\n\n The primary motivation for this change is for being able to parse BIP352 v0 silent payment addresses (see https://github.com/bitcoin/bitcoin/pull/28122/commits/622c7a98b9f08177a3cfb601306daabb101af1fd), which require up to 118 characters. In addition to BIP352, modeling the character limit as an enum allows us to easily support new address types that use bech32m and specify their own character limit.\n\nACKs for top commit:\n paplorinc:\n re-ACK 7f3f6c6dc80247e6dfb0d406dc53bc8198f029fd\n achow101:\n ACK 7f3f6c6dc80247e6dfb0d406dc53bc8198f029fd\n theuni:\n utACK 7f3f6c6dc80247e6dfb0d406dc53bc8198f029fd\n\nTree-SHA512: 9c793d657448c1f795093b9f7d4d6dfa431598f48d54e1c899a69fb2f43aeb68b40ca2ff08864eefeeb6627d4171877234b5df0056ff2a2b84415bc3558bd280","shortMessageHtmlLink":"Merge #30047: refactor: Model the bech32 charlimit as an Enum"}},{"before":"56ea8ed3d325f42ac501cbbf536c2c642366e743","after":"09fe1435d9cae5d32fa4e24042d7a862b7c7bf22","ref":"refs/heads/master","pushedAt":"2024-06-05T00:12:22.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29997: rpc: Remove index-based Arg accessor\n\nfa3169b0732d7eb4b9166e7ecc6b7cfb669a9b54 rpc: Remove index-based Arg accessor (MarcoFalke)\n\nPull request description:\n\n The index-based Arg accessor is redundant with the name-based one. It does not provide any benefit to the code reader, or otherwise, so remove it.\n\nACKs for top commit:\n stickies-v:\n re-ACK fa3169b0732d7eb4b9166e7ecc6b7cfb669a9b54, addressed doc nits\n achow101:\n ACK fa3169b0732d7eb4b9166e7ecc6b7cfb669a9b54\n ryanofsky:\n Code review ACK fa3169b0732d7eb4b9166e7ecc6b7cfb669a9b54. One changes since last review are some documentation improvements\n\nTree-SHA512: f9da1c049dbf38c3b47a8caf8d24d195c2d4b88c7ec45a9ccfb78f1e39f29cb86869f84b308f6e49856b074c06604ab634c90eb89c9c93d2a8169e070aa1bd40","shortMessageHtmlLink":"Merge #29997: rpc: Remove index-based Arg accessor"}},{"before":"a937458904aea50f96ab64ded7adb3ddff316efe","after":"56ea8ed3d325f42ac501cbbf536c2c642366e743","ref":"refs/heads/master","pushedAt":"2024-06-04T23:13:21.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29428: test: Assumeutxo: snapshots with less work should not be loaded\n\ndf6dc2aaaeffc664006b86ee8c8797dc484ec40e test: Assumeutxo: snapshots with less work should not be loaded (Hernan Marino)\n\nPull request description:\n\n This PR adds a test which checks that snapshots with less accumulated work than the node's active chain, should not be loaded and return with an error. Although in a different context of discussion the missing test was detect in a thread in https://github.com/bitcoin/bitcoin/pull/29394 (see https://github.com/bitcoin/bitcoin/pull/29394#discussion_r1484122214)\n\nACKs for top commit:\n maflcko:\n utACK df6dc2aaaeffc664006b86ee8c8797dc484ec40e\n kevkevinpal:\n utACK [df6dc2a](https://github.com/bitcoin/bitcoin/pull/29428/commits/df6dc2aaaeffc664006b86ee8c8797dc484ec40e)\n achow101:\n ACK df6dc2aaaeffc664006b86ee8c8797dc484ec40e\n alfonsoromanz:\n Re ACK df6dc2aaaeffc664006b86ee8c8797dc484ec40e. Make is successful and the test passes.\n\nTree-SHA512: 07a394b4b288cc8ad3f66ed4e70dcda468db18113e9442eb7215cf491768432d55efaaa5b79d633094917e05475a30f0c5e4f64f8f2da293ba306891b4485560","shortMessageHtmlLink":"Merge #29428: test: Assumeutxo: snapshots with less work should not b…"}},{"before":"e54c392356c4ff4a3b658f816793231a1285f655","after":"a937458904aea50f96ab64ded7adb3ddff316efe","ref":"refs/heads/master","pushedAt":"2024-06-04T23:01:20.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30154: doc: update mention of generating bitcoin.conf\n\n9013e2b97e8f50d2be63ce740c42d0b0e0b9b7f2 Link to gen-bitcoin-conf.sh instead of bitcoin.conf placeholder (Epic Curious)\n\nPull request description:\n\n Closes #30153.\n\n This PR updates `doc/init.md` to mention generating an example bitcoin.conf instead of referencing the placeholder `share/examples/bitcoin.conf`. Also changes the code-formatted text to a markdown link.\n\n ## Background\n\n - Two years ago, `share/examples/bitcoin.conf` was replaced with [a placeholder file](https://github.com/bitcoin/bitcoin/commit/b483084d866c16d97a34251ae652bac94f85f61d). To see an example `bitcoin.conf`, the user now runs the `contrib/devtools/gen-bitcoin-conf.sh` script, which replaces the placeholder file with the parsed contents of `bitcoind --help`.\n\n - The instructions in `init.md` about an example `bitcoin.conf` haven't changed significantly since they were [added almost 10 years ago](https://github.com/bitcoin/bitcoin/blame/234bfbf6a5fcba37e510e9cb6c1f2a629cd0290e/doc/init.md#L39). They should be updated to improve clarity.\n\nACKs for top commit:\n edilmedeiros:\n ACK 9013e2b97e8f50d2be63ce740c42d0b0e0b9b7f2\n kevkevinpal:\n reACK [9013e2b](https://github.com/bitcoin/bitcoin/pull/30154/commits/9013e2b97e8f50d2be63ce740c42d0b0e0b9b7f2)\n achow101:\n ACK 9013e2b97e8f50d2be63ce740c42d0b0e0b9b7f2\n stickies-v:\n ACK 9013e2b97e8f50d2be63ce740c42d0b0e0b9b7f2\n tdb3:\n ACK for 9013e2b97e8f50d2be63ce740c42d0b0e0b9b7f2\n\nTree-SHA512: 5ac5ad672ad181d574e19e29c3727fb9e5373282444fae09b42d113d5c8915cb2829d496212638cdc4b70540b7e1794a751fcdc9539f956a594cddd70c8fd747","shortMessageHtmlLink":"Merge #30154: doc: update mention of generating bitcoin.conf"}},{"before":"701b0cf2f33c65961374bb0e13e4481cfc0f3d01","after":"e54c392356c4ff4a3b658f816793231a1285f655","ref":"refs/heads/master","pushedAt":"2024-06-04T22:47:08.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#28979: wallet, rpc: document and update `sendall` behavior around unconfirmed inputs\n\n71aae72e1fc998b2629d68a7301d85dc1b65641e test: test sendall does ancestor aware funding (ishaanam)\n36757941a05b65c2b61a83820afdf5effd8fc9a2 wallet, rpc: implement ancestor aware funding for sendall (ishaanam)\n544131f3fba9ea07fee29f9d3ee0116cd5d8a5b2 rpc, test: test sendall spends unconfirmed change and unconfirmed inputs when specified (ishaanam)\n\nPull request description:\n\n This PR:\n - Adds a functional test that `sendall` spends unconfirmed change\n - Adds a functional test that `sendall` spends regular unconfirmed inputs when specified by user\n - Adds ancestor aware funding to `sendall` by using `calculateCombinedBumpFee` and adjusting the effective value accordingly\n - Adds a functional test for ancestor aware funding in `sendall`\n\nACKs for top commit:\n S3RK:\n ACK 71aae72e1fc998b2629d68a7301d85dc1b65641e\n achow101:\n ACK 71aae72e1fc998b2629d68a7301d85dc1b65641e\n furszy:\n ACK 71aae72e1f\n\nTree-SHA512: acaeb7c65166ce53123a1d6cb5012197202246acc02ef9f37a28154cc93afdbd77c25e840ab79bdc7e0b88904014a43ab1ddea79d5337dc310ea210634ab61f0","shortMessageHtmlLink":"Merge #28979: wallet, rpc: document and update sendall behavior aro…"}},{"before":"d39f15a8a5b06d68070a3434a81c6840d4f87715","after":"701b0cf2f33c65961374bb0e13e4481cfc0f3d01","ref":"refs/heads/master","pushedAt":"2024-06-04T22:37:37.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#28366: Fix waste calculation in SelectionResult\n\nbd34dd85e7b8b4cc26d2173d84bbeda2e9c27624 Use `exact_target` shorthand in coinselector_tests (Murch)\n7aa7e30441fe77bf8e8092916e36b004bbbfe2a7 Fold GetSelectionWaste() into ComputeAndSetWaste() (Murch)\n\nPull request description:\n\n PR #26152 moved waste calculation into SelectionResult to be able to correct the waste score on basis of the bump_fee_group_discount for overlapping ancestries. This left two functions with largely overlapping purpose, where one was simply a wrapper of the other. This PR cleans up the overlap, and fixes the double-meaning of `change_cost` where the `GetChange()` function assumed that no change was created when `change_cost` was set to 0. This behavior was exploited in a bunch of tests, but is problematic, because a `change_cost` of 0 is permitted with custom settings for feerate and discard_feerate (i.e. when they’re both 0).\n\nACKs for top commit:\n achow101:\n ACK bd34dd85e7b8b4cc26d2173d84bbeda2e9c27624\n furszy:\n Code ACK bd34dd85e7b8b4cc26d2173d84bbeda2e9c27624\n ismaelsadeeq:\n Code Review ACK bd34dd85e7b8b4cc26d2173d84bbeda2e9c27624\n\nTree-SHA512: 83a2688d45d719dc61a64b5180fe136107faccf401a59df65245c05d701748a03e85ed56fde8c9b7ef39a3ab54374dd3718c559bda5b3f55dafedfd7fed25161","shortMessageHtmlLink":"Merge #28366: Fix waste calculation in SelectionResult"}},{"before":"9efc2af3be5817972d9899893c343fc4deab7df5","after":"d39f15a8a5b06d68070a3434a81c6840d4f87715","ref":"refs/heads/master","pushedAt":"2024-06-04T13:56:52.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30211: fuzz: Make FuzzedSock fuzz friendlier\n\n22d0f1a27ef7733b51b3c2138a8d01713df8f248 [fuzz] Avoid endless waiting in FuzzedSock::{Wait,WaitMany} (marcofleon)\na7fceda68bb62fe3d9060fcf52e33b2f64a2acf9 [fuzz] Make peeking through FuzzedSock::Recv fuzzer friendly (dergoegge)\n865cdf3692590bc6b1121524fe1bee188788b791 [fuzz] Use fuzzer friendly ConsumeRandomLengthByteVector in FuzzedSock::Recv (dergoegge)\n\nPull request description:\n\n `FuzzedSock` has a few issues that block a fuzzer from making progress. See commit messages for details.\n\nACKs for top commit:\n marcofleon:\n Tested ACK 22d0f1a27ef7733b51b3c2138a8d01713df8f248\n brunoerg:\n utACK 22d0f1a27ef7733b51b3c2138a8d01713df8f248\n\nTree-SHA512: 2d66fc94ba58b6652ae234bd1dcd33b7d685b5054fe83e0cd624b053dd51519c23148f43a865ab8c8bc5fc2dc25e701952831b99159687474978a90348faa4c5","shortMessageHtmlLink":"Merge #30211: fuzz: Make FuzzedSock fuzz friendlier"}},{"before":"f7a6d3444973421bfd35815fabe552874f462467","after":"9efc2af3be5817972d9899893c343fc4deab7df5","ref":"refs/heads/master","pushedAt":"2024-06-04T08:11:54.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30217: depends: Update Boost download link\n\nffbc173ca1ed6b93de8bf3f88b8aed0743f4916c depends: Update Boost download link (Hennadii Stepanov)\n\nPull request description:\n\n The Boost has [migrated](https://github.com/boostorg/boost-tasks/pull/3) their downloads from from boostorg.jfrog.io to archives.boost.io.\n\n So do we.\n\n FWIW, the download speed at my location is much better :)\n\nACKs for top commit:\n maflcko:\n ACK ffbc173ca1ed6b93de8bf3f88b8aed0743f4916c\n\nTree-SHA512: 3f66675c390510ecfdacf2ac8af4a0a6bdbdf6fbfe01ed66fbe1b11bc9e935709e5492a754711cd788352c5853738fce755afd0c0480f36d0f8af31fcc108263","shortMessageHtmlLink":"Merge #30217: depends: Update Boost download link"}},{"before":"c065ae84695de811716cb4fc89357346d7decc8f","after":"f7a6d3444973421bfd35815fabe552874f462467","ref":"refs/heads/master","pushedAt":"2024-06-03T13:41:38.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30215: doc: JSON-RPC request Content-Type is application/json\n\n3c08e11c3ea4499e8d20609e2417cac859b3e98e doc: JSON-RPC request Content-Type is application/json (Luke Dashjr)\n\nPull request description:\n\n Specify json content type in RPC examples.\n\n Picks up #29946. Which needed rebasing and the commit message fixing,\n\nACKs for top commit:\n laanwj:\n ACK 3c08e11c3ea4499e8d20609e2417cac859b3e98e\n tdb3:\n ACK for 3c08e11c3ea4499e8d20609e2417cac859b3e98e\n\nTree-SHA512: 770bbbc0fb324cb63628980b13583cabf02e75079851850170587fb6eca41a70b01dcedaf1926bb6488eb9816a3cc6616fe8cee8c4b7e09aa39b7df5834ca0ec","shortMessageHtmlLink":"Merge #30215: doc: JSON-RPC request Content-Type is application/json"}},{"before":"e40df5468d1187a608f3821a23f37939e24804a1","after":"c065ae84695de811716cb4fc89357346d7decc8f","ref":"refs/heads/master","pushedAt":"2024-06-03T13:01:51.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30134: fuzz: add more coverage for `ScriptPubKeyMan`\n\ne3249f21111f1dd4beb66f10af933c34a36c30ac fuzz: add more coverage for `ScriptPubKeyMan` (brunoerg)\n\nPull request description:\n\n This PR adds more coverage for `ScriptPubKeyMan`:\n\n - Check `GetKey` and `HasPrivKey` after adding descriptor key.\n - Cover `GetEndRange` and `GetKeyPoolSize`.\n - Cover `MarkUnusedAddresses` with the scripts from ScriptPubKeys and `GetMetadata` with the destinations from them.\n\nACKs for top commit:\n marcofleon:\n Tested ACK e3249f21111f1dd4beb66f10af933c34a36c30ac. I ran the updated harness for ~9 hours on an empty corpus, generated a coverage report, and checked that the new functions mentioned were hit. Coverage of `scriptpubkeyman.cpp` increased.\n murchandamus:\n Tested ACK e3249f21111f1dd4beb66f10af933c34a36c30ac\n\nTree-SHA512: cfab91f6c8401174842e79209c0e9225c08f011fe9b41d0a58bcec716ae4545eaf803867f899ed7b5fbcefea45711f91894e36df082ba19732dd310cd9e61a79","shortMessageHtmlLink":"Merge #30134: fuzz: add more coverage for ScriptPubKeyMan"}},{"before":"80bdd4b6beb878c95478b5623c9f9ff0b948ad57","after":"e40df5468d1187a608f3821a23f37939e24804a1","ref":"refs/heads/master","pushedAt":"2024-06-03T11:44:10.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30216: build: Fix building `fuzz` binary on on SunOS / illumos\n\n3299abce948f205bb1354993614b669189f9b89f build: Fix building `fuzz` binary on on SunOS / illumos (Hennadii Stepanov)\n\nPull request description:\n\n On master branch @ 457e1846d2bf6ef9d54b9ba1a330ba8bbff13091, building the `fuzz` binary fails:\n ```\n $ ./autogen.sh\n $ ./configure\n $ gmake -C src test/fuzz/fuzz\n < snip >\n CXX test/fuzz/fuzz-http_request.o\n test/fuzz/http_request.cpp:13:10: fatal error: event2/buffer.h: No such file or directory\n 13 | #include \n | ^~~~~~~~~~~~~~~~~\n compilation terminated.\n gmake: *** [Makefile:17138: test/fuzz/fuzz-http_request.o] Error 1\n gmake: Leaving directory '/export/home/hebasto/git/bitcoin/src'\n ```\n\n The testing system:\n ```\n $ uname -a\n SunOS openindiana 5.11 illumos-82079dec87 i86pc i386 i86pc\n ```\n\n This PR fixes this issue.\n\nACKs for top commit:\n maflcko:\n ACK 3299abce948f205bb1354993614b669189f9b89f\n\nTree-SHA512: 43048cf0d3db47d71263da179e07225afd901ed2039ee4d17314ff7b581ab36f41282fde3b1210926cecda546320dc573937c564520f61fbb236c2b9914ed0d4","shortMessageHtmlLink":"Merge #30216: build: Fix building fuzz binary on on SunOS / illumos"}},{"before":"f7c0ddff466508b863b420770dc3257a178cc208","after":"80bdd4b6beb878c95478b5623c9f9ff0b948ad57","ref":"refs/heads/master","pushedAt":"2024-06-03T09:29:19.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30167: doc, rpc: Release notes and follow-ups for #29612\n\nefc1b5be8a4696c0db19ba18316b2d4ed09e10f2 test: Add coverage for txid coins count check when loading snapshot (Fabian Jahr)\n6b6084850b8c2ebcdbeecdb406e8732adaa6d23c assumeutxo: Add network magic ctor param to SnapshotMetadata (Fabian Jahr)\n1f1f9984555d49f07ae20cb3a8153a177c546beb assumeutxo: Deserialize trailing byte instead of Txid (Fabian Jahr)\n359967e310794e0bbdbe2bca38ee440a88bc4f43 doc: Add release notes for #29612 (Fabian Jahr)\n\nPull request description:\n\n This adds release notes for #29612 and addresses post-merge review comments.\n\nACKs for top commit:\n maflcko:\n utACK efc1b5be8a4696c0db19ba18316b2d4ed09e10f2\n theStack:\n utACK efc1b5be8a4696c0db19ba18316b2d4ed09e10f2\n\nTree-SHA512: 3b270202e4f7b2576090ef1d970fd54a6840d96fc3621dddd28e888fb8696a97ff69af2e000bcee3b364316ca3f6e2a9b2f1694c6184f0e704dc487823127ce4","shortMessageHtmlLink":"Merge #30167: doc, rpc: Release notes and follow-ups for #29612"}},{"before":"e18accc5f518e229471f79d191196604abad254a","after":"f7c0ddff466508b863b420770dc3257a178cc208","ref":"refs/heads/master","pushedAt":"2024-06-03T09:06:21.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30192: build: remove `--enable-lcov-branch-coverage`\n\ncbd4640ede92a1a5d7b7c1367eb7c00a9f476c62 build: remove --enable-lcov-branch-coverage (fanquake)\n\nPull request description:\n\n This supports lcov `2.x` in the sense that we are no-longer hardcoding version specific options, and instead will use the `LCOV_OPTS` variable (which is the more flexible thing to do in any case). It's also quite likely that devs are already having to pass extra options to lcov `2.x`, given it's more stringent in terms of coverage generation and error checking. See this thread for an example: https://github.com/linux-test-project/lcov/issues/238.\n\n Tested on one machine (LCOV 2.0, gcc 13.2) with:\n ```bash\n ./autogen.sh\n ./configure --enable-lcov CXXFLAGS=\"-fprofile-update=prefer-atomic\" LCOV_OPTS=\"--rc branch_coverage=1 --ignore-errors mismatch\"\n make\n make cov\n \n Processing file src/netaddress.cpp\n lines=521 hit=480 functions=72 hit=72 branches=675 hit=499\n Overall coverage rate:\n lines......: 81.8% (79362 of 97002 lines)\n functions......: 77.8% (10356 of 13310 functions)\n branches......: 49.6% (130628 of 263196 branches)\n ```\n\n and another machine (LCOV 2.1, Clang 18.1.3) with:\n ```bash\n ./autogen.sh\n ./configure --enable-lcov CC=clang CXX=clang++ LCOV_OPTS=\"--rc branch_coverage=1 --ignore-errors mismatch,inconsistent\"\n make\n make cov\n \n Processing file src/util/strencodings.cpp\n lines=315 hit=311 functions=38 hit=38 branches=425 hit=357\n Overall coverage rate:\n source files: 622\n lines.......: 79.8% (70311 of 88132 lines)\n functions...: 78.1% (13968 of 17881 functions)\n branches....: 44.5% (157551 of 354317 branches)\n Message summary:\n 101 warning messages:\n count: 1\n inconsistent: 100\n 3528 ignore messages:\n inconsistent: 3528\n ```\n\n Related to #28468.\n\nACKs for top commit:\n theuni:\n utACK cbd4640ede92a1a5d7b7c1367eb7c00a9f476c62\n hebasto:\n ACK cbd4640ede92a1a5d7b7c1367eb7c00a9f476c62, tested on Ubuntu 22.04.\n\nTree-SHA512: 94eb01e0e236a480052749f6107b1d0d2e4f6f70a8eefd55fa9ba3d2f72996c9e8a0f28340698b7ac82e7a71e9cf799b7a53ddb6e435e5e9795f5f98a18820f7","shortMessageHtmlLink":"Merge #30192: build: remove --enable-lcov-branch-coverage"}},{"before":"457e1846d2bf6ef9d54b9ba1a330ba8bbff13091","after":"e18accc5f518e229471f79d191196604abad254a","ref":"refs/heads/master","pushedAt":"2024-06-03T08:59:58.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30186: fuzz: increase `txorphan` harness stability\n\n8defc182a31d828ad0f53ebf7e3be9e9cfc42d09 scripted-diff: Replace nNextSweep with m_next_sweep (marcofleon)\n0048680467e15037023ceae44bc2dc8309f82f39 increase txorphan harness stability (marcofleon)\n\nPull request description:\n\n This moves `nNextSweep` from being a static variable in `LimitOrphans` to being a member of the `TxOrphanage` class. This improves the stability of the `txorphan` fuzz harness, as each orphanage (created every iteration) now has its own value for `nNextSweep`.\n\nACKs for top commit:\n maflcko:\n utACK 8defc182a31d828ad0f53ebf7e3be9e9cfc42d09\n dergoegge:\n Code review ACK 8defc182a31d828ad0f53ebf7e3be9e9cfc42d09\n glozow:\n utACK 8defc182a31d828ad0f53ebf7e3be9e9cfc42d09, I can rebase on this pretty easily\n\nTree-SHA512: 54d4a5074def764f6c895308b94e417662d2f21f157925421131745f22743907df59971f4ce545063658cd74ec133792cdd8df96ae3e69af8314e9b0ff899d48","shortMessageHtmlLink":"Merge #30186: fuzz: increase txorphan harness stability"}},{"before":"3ac1465cd9da8d328972a67d4c623a012a276e81","after":"457e1846d2bf6ef9d54b9ba1a330ba8bbff13091","ref":"refs/heads/master","pushedAt":"2024-05-31T14:30:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30204: depends: consolidate dependency docs\n\na27e1ceb9f9c9239af9b0a151c84a57573ea646a depends: consolidate dependency docs (fanquake)\n\nPull request description:\n\n Adds missing `g++` for macOS. This is needed by Qt:\n ```bash\n Configuring qt...\n Creating qmake...\n gmake[1]: Entering directory '/bitcoin/depends/work/build/arm64-apple-darwin/qt/5.15.14-4bca24c8f89/qtbase/qmake'\n gmake[1]: g++: No such file or directory\n gmake[1]: *** [Makefile:250: main.o] Error 127\n ```\n\n `xz-utils` was also missing (but generally already installed), and is needed for the `.tar.xz` tarballs.\n\n Remove `bsdmainutils`, as this is only needed by the main build system (for tests), and isn't needed to complete a depends build.\n\nACKs for top commit:\n maflcko:\n ACK a27e1ceb9f9c9239af9b0a151c84a57573ea646a\n\nTree-SHA512: 720c31d4d4c9b86fda4aace405d528193714dd3e526f38d5b8a83e4b676a433b9c891f01d86d673be9ac848458eda8a89b0981003a42eaa6d97bacc2e914396a","shortMessageHtmlLink":"Merge #30204: depends: consolidate dependency docs"}},{"before":"62f7f59ff495fbcbfc10c25e97bb0dc032647abf","after":"3ac1465cd9da8d328972a67d4c623a012a276e81","ref":"refs/heads/master","pushedAt":"2024-05-31T14:28:37.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30198: depends: qt 5.15.14 and fix macOS build with Clang 18\n\n0a3631fc352eda849290db940844e5ef723436df depends: fix Qt macOS build with Clang 18 (fanquake)\nb018bd779dd9b2d46c10254a1cf5b819ae8e027c depends: qt 5.15.14 (fanquake)\n\nPull request description:\n\n Also adds a patch to Qts internal libpng, to fix compilation using Clang 18, when targetting macOS. I'd like to get this patched, so we can continue working on removing `FORCE_USE_SYSTEM_CLANG` (#30201); otherwise builds will be broken using the default Clang (`18`) on the current Ubuntu LTS (`24.04`).\n\n With this PR, anyone using Ubuntu 24.04 should be able to `apt install clang llvm lld`, and then cross-compile for macOS using:\n ```bash\n # clang --version\n Ubuntu clang version 18.1.3 (1)\n make -C depends HOST=arm64-apple-darwin FORCE_USE_SYSTEM_CLANG=1\n ./autogen.sh\n CONFIG_SITE=/path/to/depends/arm64-apple-darwin/share/config.site ./configure\n make\n # file src/qt/bitcoin-qt\n src/qt/bitcoin-qt: Mach-O 64-bit arm64 executable, flags:\n ```\n\nACKs for top commit:\n TheCharlatan:\n ACK 0a3631fc352eda849290db940844e5ef723436df\n theuni:\n utACK 0a3631fc352eda849290db940844e5ef723436df\n hebasto:\n ACK 0a3631fc352eda849290db940844e5ef723436df, a new patch indeed fixes cross-compiling on Ubuntu 24.04 with `FORCE_USE_SYSTEM_CLANG=1`.\n\nTree-SHA512: 711d321b1efbb1aeef802d1d7e72fff8f4e28aa2420d19df9db6f4449fc7d281e1d08ba242ce20122dfe21129e713bd59e7e6ade0b67d7271eea18b39ceb9283","shortMessageHtmlLink":"Merge #30198: depends: qt 5.15.14 and fix macOS build with Clang 18"}},{"before":"0a7c650fcd322a46dac7239b421046a61a6a5a20","after":"62f7f59ff495fbcbfc10c25e97bb0dc032647abf","ref":"refs/heads/master","pushedAt":"2024-05-30T14:32:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30199: clang-tidy: Add `bugprone-move-forwarding-reference` check\n\n88cdb5967f093cf96e9184a48c0d9e34cea9d341 clang-tidy: Add `bugprone-move-forwarding-reference` check (Hennadii Stepanov)\n\nPull request description:\n\n This PR adds [`bugprone-move-forwarding-reference`](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/move-forwarding-reference.html) to the clang-tidy checks.\n\nACKs for top commit:\n maflcko:\n utACK 88cdb5967f093cf96e9184a48c0d9e34cea9d341\n\nTree-SHA512: 8366c895085d0656a4491035aa8863c9dca12885c2bdf0392bebc63d6f6f5473ec263594e5fde70a3c211e95d19b9cd98e2c574ced91b4c970cce0edce40bceb","shortMessageHtmlLink":"Merge #30199: clang-tidy: Add bugprone-move-forwarding-reference check"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEX9OsDgA","startCursor":null,"endCursor":null}},"title":"Activity · bitcoin/bitcoin"}