{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":23096959,"defaultBranch":"master","name":"go","ownerLogin":"golang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-08-19T04:33:40.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4314092?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716572565.0","currentOid":""},"activityList":{"items":[{"before":"00b8071a12e298303b2f4bd0e9f641ef3e54772a","after":"9b43bfbc51c469ec13fca24960834a75b2bf66eb","ref":"refs/heads/master","pushedAt":"2024-05-31T19:49:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/vendor: update github.com/google/pprof\n\nBrings in the latest github.com/google/pprof.\n\nFixes #67626\n\nChange-Id: Id8faef20f0a9bf81dd117110bf540aca852db6be\nCq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest\nReviewed-on: https://go-review.googlesource.com/c/go/+/588655\nReviewed-by: Carlos Amedee \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"cmd/vendor: update github.com/google/pprof"}},{"before":"639cc0dcc0948dd02c9d5fc12fbed730a21ebebc","after":"00b8071a12e298303b2f4bd0e9f641ef3e54772a","ref":"refs/heads/master","pushedAt":"2024-05-31T19:16:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"net/netip: cover IPv4Unspecified in TestAddrWellKnown\n\nLike IPv6Unspecified which is already covered in that test.\n\nChange-Id: I2bac4c50577c4c2c91cea26b9fbed88327cef516\nReviewed-on: https://go-review.googlesource.com/c/go/+/589595\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor \nReviewed-by: Carlos Amedee \nAuto-Submit: Tobias Klauser ","shortMessageHtmlLink":"net/netip: cover IPv4Unspecified in TestAddrWellKnown"}},{"before":"5bf8c0cf09ee5c7e5a37ab90afcce154ab716a97","after":"639cc0dcc0948dd02c9d5fc12fbed730a21ebebc","ref":"refs/heads/master","pushedAt":"2024-05-31T14:32:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"runtime: remove zhangyunhao116/fastrand from cheaprand linkname comment\n\nAs of version 0.5.0 and Go 1.22 it no longer linknames cheaprand.\n\nFixes #67709\n\nChange-Id: Ie00900e6428244fa1506bc509c265c10dc322f7a\nReviewed-on: https://go-review.googlesource.com/c/go/+/589555\nAuto-Submit: Ian Lance Taylor \nReviewed-by: Michael Knyszek \nReviewed-by: Than McIntosh \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"runtime: remove zhangyunhao116/fastrand from cheaprand linkname comment"}},{"before":"09e5bab8c1310aa1a9860c40c9e4babacffb13d8","after":"5bf8c0cf09ee5c7e5a37ab90afcce154ab716a97","ref":"refs/heads/master","pushedAt":"2024-05-31T04:10:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/poll: update WaitWrite comment\n\nChange-Id: Id2999d95f344b3e30d98682aac5da630d808ce2d\nGitHub-Last-Rev: 69c207f51c63349ee1cf34f0b96bcd03a1e33e2c\nGitHub-Pull-Request: golang/go#67732\nReviewed-on: https://go-review.googlesource.com/c/go/+/589396\nAuto-Submit: Ian Lance Taylor \nCommit-Queue: Ian Lance Taylor \nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Pratt ","shortMessageHtmlLink":"internal/poll: update WaitWrite comment"}},{"before":"1ed81661926c026b122f3a355a811a40ecd2f8f6","after":"09e5bab8c1310aa1a9860c40c9e4babacffb13d8","ref":"refs/heads/master","pushedAt":"2024-05-31T00:12:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/cgo/internal/testsanitizers: make the libfuzzer tests all short\n\nCL 589295 only made one of the two tests short, because the other one\nseemed to be passing consistently in short mode. On the builders, it\nseems to still fail maybe 30% of the time by taking too long. Disable\nthese tests in short mode.\n\nFor #67698.\n\nChange-Id: I9fd047f834f7493b608dd1fee5b9b6dfabbea03d\nCq-Include-Trybots: luci.golang.try:gotip-linux-amd64-clang15,gotip-linux-386-clang15\nReviewed-on: https://go-review.googlesource.com/c/go/+/589495\nAuto-Submit: Michael Knyszek \nReviewed-by: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI \nCommit-Queue: Michael Knyszek ","shortMessageHtmlLink":"cmd/cgo/internal/testsanitizers: make the libfuzzer tests all short"}},{"before":"44d06616b51a8a750c36bba3d4ee8630d2bddef8","after":"1ed81661926c026b122f3a355a811a40ecd2f8f6","ref":"refs/heads/master","pushedAt":"2024-05-30T22:15:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/trace: actually add experimental data to map\n\naddExperimentalData was missing actually placing the data into the map,\nleaving ExperimentalEvent.Data always nil.\n\nChange-Id: I1715ab11eb7cfcdb982b56be28378521a357ca2d\nReviewed-on: https://go-review.googlesource.com/c/go/+/588955\nReviewed-by: Carlos Amedee \nReviewed-by: Michael Knyszek \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"internal/trace: actually add experimental data to map"}},{"before":"cc95d85fe452e2556efe29631421bac4c13f0160","after":"44d06616b51a8a750c36bba3d4ee8630d2bddef8","ref":"refs/heads/master","pushedAt":"2024-05-30T19:26:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"doc/next: preannounce a new Linux kernel version requirement\n\nThis change adds a preannouncement to the release notes. Go 1.24\nwill require the Linux kernel to be at version 3.17 or later,\nwith an exception that systems running 3.10 or later will\ncontinue to be supported if the kernel has been patched to\nsupport the getrandom system call.\n\nFor #65614\nFor #67001\n\nChange-Id: I61a3838b9ce4f48eb9f94830aa03372d589afdcd\nReviewed-on: https://go-review.googlesource.com/c/go/+/589015\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"doc/next: preannounce a new Linux kernel version requirement"}},{"before":"f1039180bd9613bd23dbf47b240f3801172d2706","after":"cc95d85fe452e2556efe29631421bac4c13f0160","ref":"refs/heads/master","pushedAt":"2024-05-30T19:20:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/compile: remove quoting in favor of clearer prose in error messages\n\nIn an attempt to address issue #65790 (confusing error messages),\nquoting of names was introduced for some (but not all) names used\nin error messages.\n\nThat CL solved the issue at hand at the cost of extra punctuation\n(the quotes) plus some inconsistency (not all names were quoted).\n\nThis CL removes the quoting again in favor or adding a qualifying noun\n(such as \"name\", \"label\", \"package\", \"built-in\" etc.) before a user-\nspecified name where needed.\n\nFor instance, instead of\n\n invalid argument to `max'\n\nwe now say\n\n invalid argument to built-in max\n\nThere's still a chance for confusion. For instance, before an error\nmight have been\n\n `sadly' not exported by package X\n\nand now it would be\n\n name sadly not exported by package X\n\nbut adverbs (such as \"sadly\") seem unlikely names in programs.\n\nThis change touches a lot of files but only affects error messages.\n\nFixes #67685.\n\nChange-Id: I95435b388f92cade316e2844d59ecf6953b178bc\nReviewed-on: https://go-review.googlesource.com/c/go/+/589118\nAuto-Submit: Robert Griesemer \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley \nReviewed-by: Robert Griesemer ","shortMessageHtmlLink":"cmd/compile: remove quoting in favor of clearer prose in error messages"}},{"before":"c8cb31a36e58f552697735da0d559b977aa639f2","after":"f1039180bd9613bd23dbf47b240f3801172d2706","ref":"refs/heads/master","pushedAt":"2024-05-30T19:19:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/compile/internal/types2: enable Alias types for TestStdlib\n\nThis is expected to eliminate a potential race condition\nwhich is causing a flaky test.\n\nFixes #67260.\n\nChange-Id: I3fd76047136e2d4659a1c551491e371b67e8a7ce\nReviewed-on: https://go-review.googlesource.com/c/go/+/589236\nAuto-Submit: Robert Griesemer \nReviewed-by: Robert Findley \nReviewed-by: Robert Griesemer \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/compile/internal/types2: enable Alias types for TestStdlib"}},{"before":"9114c51521c641ff6c33648da03774dc3eb86b79","after":"c8cb31a36e58f552697735da0d559b977aa639f2","ref":"refs/heads/master","pushedAt":"2024-05-30T18:02:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"doc/next: document proposal 62518 as not relevant\n\nFor #65614.\n\nChange-Id: I03dc3a46052f1e55dc1ab46b45c886c96c4a1b39\nReviewed-on: https://go-review.googlesource.com/c/go/+/589216\nTryBot-Bypass: Dmitri Shuralyov \nReviewed-by: Matthew Dempsky \nAuto-Submit: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"doc/next: document proposal 62518 as not relevant"}},{"before":"afbbc2894b4af076d7f171fd6e83541d35b7b5a3","after":"9114c51521c641ff6c33648da03774dc3eb86b79","ref":"refs/heads/master","pushedAt":"2024-05-30T17:57:45.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"Revert \"runtime: prepare for extensions to waiting M list\"\n\nThis reverts commit be0b569caa0eab1a7f30edf64e550bbf5f6ff235 (CL 585635).\n\nReason for revert: This is part of a patch series that changed the\nhandling of contended lock2/unlock2 calls, reducing the maximum\nthroughput of contended runtime.mutex values, and causing a performance\nregression on applications where that is (or became) the bottleneck.\n\nUpdates #66999\nUpdates #67585\n\nChange-Id: I7843ccaecbd273b7ceacfa0f420dd993b4b15a0a\nReviewed-on: https://go-review.googlesource.com/c/go/+/589117\nAuto-Submit: Rhys Hiltner \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh \nReviewed-by: Michael Pratt ","shortMessageHtmlLink":"Revert \"runtime: prepare for extensions to waiting M list\""}},{"before":"ca7d300509626e2071f3f5babc2e9c121d806fec","after":"afbbc2894b4af076d7f171fd6e83541d35b7b5a3","ref":"refs/heads/master","pushedAt":"2024-05-30T17:57:10.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"Revert \"runtime: double-link list of waiting Ms\"\n\nThis reverts commit d881ed6384ae58154d99682f1e20160c64e7c3c2 (CL 585637).\n\nReason for revert: This is part of a patch series that changed the\nhandling of contended lock2/unlock2 calls, reducing the maximum\nthroughput of contended runtime.mutex values, and causing a performance\nregression on applications where that is (or became) the bottleneck.\n\nUpdates #66999\nUpdates #67585\n\nChange-Id: I70d8d0b74f73be95c43d664f584e8d98519aba26\nReviewed-on: https://go-review.googlesource.com/c/go/+/589116\nAuto-Submit: Rhys Hiltner \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh \nReviewed-by: Michael Pratt ","shortMessageHtmlLink":"Revert \"runtime: double-link list of waiting Ms\""}},{"before":"e6b8b2f3e236e8646962c68e172c304e11e9a8f0","after":"ca7d300509626e2071f3f5babc2e9c121d806fec","ref":"refs/heads/master","pushedAt":"2024-05-30T17:52:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"Revert \"runtime: remove GODEBUG=runtimecontentionstacks\"\n\nThis reverts commit 87e930f7289136fad1310d4b63dd4127e409bac5 (CL 585639)\n\nReason for revert: This is part of a patch series that changed the\nhandling of contended lock2/unlock2 calls, reducing the maximum\nthroughput of contended runtime.mutex values, and causing a performance\nregression on applications where that is (or became) the bottleneck.\n\nUpdates #66999\nUpdates #67585\n\nChange-Id: I1e286d2a16d16e4af202cd5dc04b2d9c4ee71b32\nReviewed-on: https://go-review.googlesource.com/c/go/+/589097\nReviewed-by: Than McIntosh \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Pratt \nAuto-Submit: Rhys Hiltner ","shortMessageHtmlLink":"Revert \"runtime: remove GODEBUG=runtimecontentionstacks\""}},{"before":"1be701a344d1f1819dc08d78259684de1da6f923","after":"e6b8b2f3e236e8646962c68e172c304e11e9a8f0","ref":"refs/heads/master","pushedAt":"2024-05-30T17:51:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"Revert \"runtime: improve runtime-internal mutex profile tests\"\n\nThis reverts commit f9ba2cff2286d378eca28c841bea8488c69fc30e (CL 586237)\n\nReason for revert: This is part of a patch series that changed the\nhandling of contended lock2/unlock2 calls, reducing the maximum\nthroughput of contended runtime.mutex values, and causing a performance\nregression on applications where that is (or became) the bottleneck.\n\nThis test verifies that the semantics of the mutex profile for\nruntime.mutex values matches that of sync.Mutex values. Without the rest\nof the patch series, this test would correctly identify that Go 1.22's\nsemantics are incorrect (issue #66999).\n\nUpdates #66999\nUpdates #67585\n\nChange-Id: Id06ae01d7bc91c94054c80d273e6530cb2d59d10\nReviewed-on: https://go-review.googlesource.com/c/go/+/589096\nReviewed-by: Michael Pratt \nReviewed-by: Than McIntosh \nAuto-Submit: Rhys Hiltner \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"Revert \"runtime: improve runtime-internal mutex profile tests\""}},{"before":"e6504ce671afcf0a165be02f9e04f6a99ca08020","after":"1be701a344d1f1819dc08d78259684de1da6f923","ref":"refs/heads/master","pushedAt":"2024-05-30T17:49:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"Revert \"runtime: split mutex profile clocks\"\n\nThis reverts commit 8ab131fb1256a4a795c610e145c022e22e2d1567 (CL 586796)\n\nReason for revert: This is part of a patch series that changed the\nhandling of contended lock2/unlock2 calls, reducing the maximum\nthroughput of contended runtime.mutex values, and causing a performance\nregression on applications where that is (or became) the bottleneck.\n\nUpdates #66999\nUpdates #67585\n\nChange-Id: I54711691e86e072081482102019d168292b5150a\nReviewed-on: https://go-review.googlesource.com/c/go/+/589095\nReviewed-by: Michael Pratt \nAuto-Submit: Rhys Hiltner \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"Revert \"runtime: split mutex profile clocks\""}},{"before":"81d424ee9a7ea39dd42292edceb52ec5ebb71d1b","after":"e6504ce671afcf0a165be02f9e04f6a99ca08020","ref":"refs/heads/master","pushedAt":"2024-05-30T14:57:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/go: add compatibility tests for go mod tidy -diff\n\nFor #27005\nCq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest,gotip-windows-amd64-longtest\nChange-Id: I90ab8c21222ac2189abb40e8c8e7549e2d940dd2\nReviewed-on: https://go-review.googlesource.com/c/go/+/587941\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Matloob ","shortMessageHtmlLink":"cmd/go: add compatibility tests for go mod tidy -diff"}},{"before":"787414ca488dbb819b1ec82ff5d620b32e79de37","after":"81d424ee9a7ea39dd42292edceb52ec5ebb71d1b","ref":"refs/heads/master","pushedAt":"2024-05-30T12:39:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/trace: fix off-by-one error in arguments for exp events\n\nThere's an off-by-one error in computing the Args field for experimental\nevents, resulting in confusing output. This wasn't caught because no\ntest actually checks to make sure the experimental arguments make sense\nyet.\n\nChange-Id: I339677a80bee6319407fced20d5e0f9c2fd235b3\nReviewed-on: https://go-review.googlesource.com/c/go/+/589055\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Carlos Amedee \nAuto-Submit: Michael Knyszek \nReviewed-by: Michael Pratt ","shortMessageHtmlLink":"internal/trace: fix off-by-one error in arguments for exp events"}},{"before":"1cf862e66c6e65217c1254a7bfac6f3e77f4ae23","after":"787414ca488dbb819b1ec82ff5d620b32e79de37","ref":"refs/heads/master","pushedAt":"2024-05-30T12:38:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/cgo/internal/swig: force use of lld for LTO tests on the builders\n\nFor whatever reason, on the builders, when using /usr/bin/ld (the\ndefault linker) with -flto we end up with problems. Specifically, the\nlinker seems to require LLVMgold.so and can't find it. I'm not really\nsure why, but what definitely seems to work is forcing use of lld, which\nships with our clang installation on the builders.\n\nJust enforce this on the builders for now; I've actually had very few\nproblems running this locally (and I think I'm also mixing and matching\nlinkers and toolchains too...), so it may be related to the version of\nclang we're testing with.\n\nThis change, along with CL 589295, should fully fix the clang builders.\n\nFixes #67698.\n\nChange-Id: I3bfbcd609e7d0fd70e52ac7e2a0817db95664f20\nCq-Include-Trybots: luci.golang.try:gotip-linux-amd64-clang15,gotip-linux-386-clang15\nReviewed-on: https://go-review.googlesource.com/c/go/+/589296\nAuto-Submit: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"cmd/cgo/internal/swig: force use of lld for LTO tests on the builders"}},{"before":"cad3ed207fc428bdca60ce16793ee154893e79df","after":"1cf862e66c6e65217c1254a7bfac6f3e77f4ae23","ref":"refs/heads/master","pushedAt":"2024-05-30T12:32:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/cgo/internal/testsanitizers: skip some libfuzzer tests in short mode\n\nThese tests are newly-running now that we have installed a C++ toolchain\non the clang builders, but one of them doesn't actually complete in short\nmode.\n\nFor #67698.\n\nChange-Id: Id1ff4c05e380426d920277c13495f30e23561a4e\nReviewed-on: https://go-review.googlesource.com/c/go/+/589295\nAuto-Submit: Michael Knyszek \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"cmd/cgo/internal/testsanitizers: skip some libfuzzer tests in short mode"}},{"before":"fa08befb25e6f4993021429aa222dad71a27ed07","after":"cad3ed207fc428bdca60ce16793ee154893e79df","ref":"refs/heads/master","pushedAt":"2024-05-30T04:04:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/cgo/internal/swig,cmd/go: reenable swig tests on 386\n\nCL 588938 skipped the tests because they were broken to unblock the\nbuilders, but we're fairly certain the reason they were failing is\nbecause we're missing g++-multilib. This change is intended to land once\nCL 589175 is deployed.\n\nFixes #67698.\n\nChange-Id: I5bb679290ae9ba9ab3bda9499cdf1eec649bc066\nReviewed-on: https://go-review.googlesource.com/c/go/+/589195\nReviewed-by: Ian Lance Taylor \nReviewed-by: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Michael Knyszek \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"cmd/cgo/internal/swig,cmd/go: reenable swig tests on 386"}},{"before":"95389d3d9d403f6a408258524556db0c629da049","after":"745657509e0598cc883f63900910ed847d84dfbb","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-05-30T01:15:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] os: RemoveAll: fix symlink race for unix\n\nSince all the platforms now support O_DIRECTORY flag for open, it can be\nused to (together with O_NOFOLLOW) to ensure we open a directory, thus\neliminating the need to call stat before open. This fixes the symlink race,\nwhen a directory is replaced by a symlink in between stat and open calls.\n\nWhile at it, rename openFdAt to openDirAt, because this function is (and was)\nmeant for directories only.\n\nNOTE Solaris supports O_DIRECTORY since before Solaris 11 (which is the\nonly version Go supports since supported version now), and Illumos\nalways had it. The only missing piece was O_DIRECTORY flag value, which\nis taken from golang.org/x/sys/unix.\n\nFixes #67696.\n\nChange-Id: Ic1111d688eebc8804a87d39d3261c2a6eb33f176\nReviewed-on: https://go-review.googlesource.com/c/go/+/589056\nAuto-Submit: Matthew Dempsky \nReviewed-by: Carlos Amedee \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Matthew Dempsky ","shortMessageHtmlLink":"[release-branch.go1.22] os: RemoveAll: fix symlink race for unix"}},{"before":"c8e40338cf00f3c1d86c8fb23863ad67a4c72bcc","after":"9488a444d9c752f4e1da19907945c4cc740a6c14","ref":"refs/heads/release-branch.go1.21","pushedAt":"2024-05-30T00:12:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.21] os: RemoveAll: fix symlink race for unix\n\nSince all the platforms now support O_DIRECTORY flag for open, it can be\nused to (together with O_NOFOLLOW) to ensure we open a directory, thus\neliminating the need to call stat before open. This fixes the symlink race,\nwhen a directory is replaced by a symlink in between stat and open calls.\n\nWhile at it, rename openFdAt to openDirAt, because this function is (and was)\nmeant for directories only.\n\nNOTE Solaris supports O_DIRECTORY since before Solaris 11 (which is the\nonly version Go supports since supported version now), and Illumos\nalways had it. The only missing piece was O_DIRECTORY flag value, which\nis taken from golang.org/x/sys/unix.\n\nFixes #67695.\n\nChange-Id: Ic1111d688eebc8804a87d39d3261c2a6eb33f176\nReviewed-on: https://go-review.googlesource.com/c/go/+/589057\nReviewed-by: Matthew Dempsky \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Matthew Dempsky \nReviewed-by: Carlos Amedee ","shortMessageHtmlLink":"[release-branch.go1.21] os: RemoveAll: fix symlink race for unix"}},{"before":"cf501ac0c5fe351a8582d20b43562027927906e7","after":"95389d3d9d403f6a408258524556db0c629da049","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-05-29T23:45:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] runtime: x_cgo_getstackbound: initialize pthread attr\n\nIn glibc versions older than 2.32 (before commit 4721f95058),\npthread_getattr_np does not always initialize the `attr` argument,\nand when it fails, it results in a NULL pointer dereference in\npthread_attr_destroy down the road.\n\nThis is the simplest way to avoid this, and an alternative to CL 585019.\n\nFixes #67650.\n\nChange-Id: If490fd37020b03eb084ebbdbf9ae0248916426d0\nReviewed-on: https://go-review.googlesource.com/c/go/+/587919\nAuto-Submit: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor \nReviewed-by: Cherry Mui \nTryBot-Result: Gopher Robot \nRun-TryBot: Cherry Mui \nReviewed-on: https://go-review.googlesource.com/c/go/+/587979\nReviewed-by: Carlos Amedee \nAuto-Submit: Matthew Dempsky \nReviewed-by: Matthew Dempsky \nCommit-Queue: Matthew Dempsky ","shortMessageHtmlLink":"[release-branch.go1.22] runtime: x_cgo_getstackbound: initialize pthr…"}},{"before":"54c4745d7ca6650c4fe31be980277c85f97004ce","after":"c8e40338cf00f3c1d86c8fb23863ad67a4c72bcc","ref":"refs/heads/release-branch.go1.21","pushedAt":"2024-05-29T23:39:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.21] archive/zip: treat truncated EOCDR comment as an error\n\nWhen scanning for an end of central directory record,\ntreat an EOCDR signature with a record containing a truncated\ncomment as an error. Previously, we would skip over the invalid\nrecord and look for another one. Other implementations do not\ndo this (they either consider this a hard error, or just ignore\nthe truncated comment). This parser misalignment allowed\npresenting entirely different archive contents to Go programs\nand other zip decoders.\n\nFor #66869\nFixes #67553\n\nChange-Id: I94e5cb028534bb5704588b8af27f1e22ea49c7c6\nReviewed-on: https://go-review.googlesource.com/c/go/+/585397\nReviewed-by: Joseph Tsai \nReviewed-by: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI \n(cherry picked from commit 33d725e5758bf1fea62e6c77fc70b57a828a49f5)\nReviewed-on: https://go-review.googlesource.com/c/go/+/588795\nReviewed-by: Matthew Dempsky ","shortMessageHtmlLink":"[release-branch.go1.21] archive/zip: treat truncated EOCDR comment as…"}},{"before":"cb55d1a0c8e37c4e5c3c45dc6e8fed8d76a18b90","after":"cf501ac0c5fe351a8582d20b43562027927906e7","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-05-29T23:39:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] archive/zip: treat truncated EOCDR comment as an error\n\nWhen scanning for an end of central directory record,\ntreat an EOCDR signature with a record containing a truncated\ncomment as an error. Previously, we would skip over the invalid\nrecord and look for another one. Other implementations do not\ndo this (they either consider this a hard error, or just ignore\nthe truncated comment). This parser misalignment allowed\npresenting entirely different archive contents to Go programs\nand other zip decoders.\n\nFor #66869\nFixes #67554\n\nChange-Id: I94e5cb028534bb5704588b8af27f1e22ea49c7c6\nReviewed-on: https://go-review.googlesource.com/c/go/+/585397\nReviewed-by: Joseph Tsai \nReviewed-by: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI \n(cherry picked from commit 33d725e5758bf1fea62e6c77fc70b57a828a49f5)\nReviewed-on: https://go-review.googlesource.com/c/go/+/588796\nReviewed-by: Matthew Dempsky ","shortMessageHtmlLink":"[release-branch.go1.22] archive/zip: treat truncated EOCDR comment as…"}},{"before":"2a7ca156b8189c68c0a29b4c66194a42c5ce3c9b","after":"fa08befb25e6f4993021429aa222dad71a27ed07","ref":"refs/heads/master","pushedAt":"2024-05-29T19:59:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/cgo/internal/swig,cmd/go: skip swig tests on 386\n\nWe recently added a C++ toolchain to the image, and this is causing\nproblems on 386 and clang builders. The likely culprit is that we're\nmissing 32-bit C++ libraries on the builders.\n\nEven if this theory is wrong, these tests *never* ran (always skipped,\nor truly never ran) on these platforms, so just skip them for now. We\ncan look into getting the libraries installed later, but skip for now\nto unblock the builders.\n\nThere are also problems with clang, but I believe they'll be resolved by\nsetting CXX to clang++ in golangbuild.\n\nFor #67698.\n\nChange-Id: I20fc1c5fa1285001ff86a4226771c30cf2e7f92d\nCq-Include-Trybots: luci.golang.try:gotip-linux-386-clang15,gotip-linux-386\nReviewed-on: https://go-review.googlesource.com/c/go/+/588938\nReviewed-by: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/cgo/internal/swig,cmd/go: skip swig tests on 386"}},{"before":"5121b45d7426687076c20ae0f4fcae1238f3ed47","after":"2a7ca156b8189c68c0a29b4c66194a42c5ce3c9b","ref":"refs/heads/master","pushedAt":"2024-05-29T17:59:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"all: document legacy //go:linkname for final round of modules\n\nAdd linknames for most modules with ≥50 dependents.\nAdd linknames for a few other modules that we know\nare important but are below 50.\n\nRemove linknames from badlinkname.go that do not merit\ninclusion (very small number of dependents).\nWe can add them back later if the need arises.\n\nFixes #67401. (For now.)\n\nChange-Id: I1e49fec0292265256044d64b1841d366c4106002\nReviewed-on: https://go-review.googlesource.com/c/go/+/587756\nAuto-Submit: Russ Cox \nTryBot-Bypass: Russ Cox \nReviewed-by: Cherry Mui ","shortMessageHtmlLink":"all: document legacy //go:linkname for final round of modules"}},{"before":"a3a584e4abad776f4b8e5cab5b5923724fdf75d9","after":"5121b45d7426687076c20ae0f4fcae1238f3ed47","ref":"refs/heads/master","pushedAt":"2024-05-29T16:25:50.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"crypto/tls: add linkname comments dropped from CL 587220\n\nA bad merge syncing before the submit of CL 587220 dropped these.\n(I forgot to write the file out.)\n\nFor #67401.\n\nChange-Id: I6f2ba69f388907f3d24eeef55c80cbb2cf51f580\nReviewed-on: https://go-review.googlesource.com/c/go/+/587755\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Cherry Mui \nReviewed-by: Marten Seemann ","shortMessageHtmlLink":"crypto/tls: add linkname comments dropped from CL 587220"}},{"before":"3dcb9623dfe412761fc3aa6fa654649d7139f056","after":"a3a584e4abad776f4b8e5cab5b5923724fdf75d9","ref":"refs/heads/master","pushedAt":"2024-05-29T13:52:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"os: RemoveAll: fix symlink race for unix\n\nSince all the platforms now support O_DIRECTORY flag for open, it can be\nused to (together with O_NOFOLLOW) to ensure we open a directory, thus\neliminating the need to call stat before open. This fixes the symlink race,\nwhen a directory is replaced by a symlink in between stat and open calls.\n\nWhile at it, rename openFdAt to openDirAt, because this function is (and was)\nmeant for directories only.\n\nNOTE Solaris supports O_DIRECTORY since before Solaris 11 (which is the\nonly version Go supports since supported version now), and Illumos\nalways had it. The only missing piece was O_DIRECTORY flag value, which\nis taken from golang.org/x/sys/unix.\n\nUpdates #52745.\n\nChange-Id: Ic1111d688eebc8804a87d39d3261c2a6eb33f176\nReviewed-on: https://go-review.googlesource.com/c/go/+/588495\nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Aleksa Sarai \nReviewed-by: Than McIntosh \nAuto-Submit: Ian Lance Taylor ","shortMessageHtmlLink":"os: RemoveAll: fix symlink race for unix"}},{"before":"78eadc87df453c2a325fd9762d57e3232179b631","after":"3dcb9623dfe412761fc3aa6fa654649d7139f056","ref":"refs/heads/master","pushedAt":"2024-05-29T13:51:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"syscall: add Setuid for aix\n\nFixes #67651\n\nChange-Id: I8128433ddd040c8b91d7b6264200e19433d7a7dc\nGitHub-Last-Rev: 7557a88cf5a52a99e7689b604964cd4ec8e6bfec\nGitHub-Pull-Request: golang/go#67656\nReviewed-on: https://go-review.googlesource.com/c/go/+/588119\nReviewed-by: Than McIntosh \nLUCI-TryBot-Result: Go LUCI \nRun-TryBot: Mauri de Souza Meneguzzo \nTryBot-Bypass: Ian Lance Taylor \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"syscall: add Setuid for aix"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWVnv9AA","startCursor":null,"endCursor":null}},"title":"Activity · golang/go"}