Cleaned up empty default constructors.

AdventurePHP · Jun 27, 2014 · b415f86 · b415f86
1 parent fe83b2d
commit b415f86
Show file tree

Hide file tree

Showing 22 changed files with 15 additions and 102 deletions.
diff --git a/core/pagecontroller/AddTaglibTag.php b/core/pagecontroller/AddTaglibTag.php
@@ -35,10 +35,6 @@
  */
 class AddTaglibTag extends Document {
 
-   public function __construct() {
-      // do nothing, especially not initialize tag libs
-   }
-
    /**
     * @public
     *

diff --git a/core/pagecontroller/AppendNodeTag.php b/core/pagecontroller/AppendNodeTag.php
@@ -49,19 +49,6 @@ class AppendNodeTag extends Document {
     */
    protected static $INCLUDE_STATIC_CONTENT_ATTRIBUTE_NAME = 'includestatic';
 
-   /**
-    * @public
-    *
-    *  Initializes the known taglib list.
-    *
-    * @author Christian Achatz
-    * @version
-    * Version 0.1, 16.11.2008<br />
-    */
-   public function __construct() {
-      parent::__construct();
-   }
-
    /**
     * @public
     *

diff --git a/core/pagecontroller/Document.php b/core/pagecontroller/Document.php
@@ -118,6 +118,21 @@ class Document extends APFObject {
     */
    public static $maxParserLoops = 500;
 
+   /**
+    * @public
+    *
+    * Default constructor of an APF document. The APF DOM tree is constructed by objects derived from this class.
+    *
+    * @author Christian Schäfer
+    * @version
+    * Version 0.1, 28.12.2006<br />
+    * Version 0.2, 03.03.2007 (Removed the "&" in front of "new")<br />
+    * Version 0.3, 11.02.2012 (Added html:getstring tag as known tag (refactoring!))<br />
+    * Version 0.4, 27.06.2014 (Removed constructor content due to new APF parser allows static tag registration)<br />
+    */
+   public function __construct() {
+   }
+
    /**
     * @public
     *

diff --git a/core/pagecontroller/ImportTemplateTag.php b/core/pagecontroller/ImportTemplateTag.php
@@ -35,19 +35,6 @@
  */
 class ImportTemplateTag extends Document {
 
-   /**
-    * @public
-    *
-    * Constructor of the class. Sets the known taglibs.
-    *
-    * @author Christian Schäfer
-    * @version
-    * Version 0.1, 28.12.2006<br />
-    */
-   public function __construct() {
-      parent::__construct();
-   }
-
    /**
     * @public
     *

diff --git a/core/pagecontroller/LanguageLabelTag.php b/core/pagecontroller/LanguageLabelTag.php
@@ -54,10 +54,6 @@ class LanguageLabelTag extends Document {
     */
    private $placeHolders = array();
 
-   public function __construct() {
-      // do nothing, especially not initialize tag libs
-   }
-
    /**
     * @public
     *

diff --git a/core/pagecontroller/PlaceHolderTag.php b/core/pagecontroller/PlaceHolderTag.php
@@ -41,10 +41,6 @@ class PlaceHolderTag extends Document {
     */
    protected $stringReplacement = array();
 
-   public function __construct() {
-      // do nothing, especially not initialize tag libs
-   }
-
    /**
     * @public
     *

diff --git a/core/pagecontroller/TemplateTag.php b/core/pagecontroller/TemplateTag.php
@@ -46,10 +46,6 @@ class TemplateTag extends Document {
     */
    protected $transformOnPlace = false;
 
-   public function __construct() {
-      // nothing to do here, especially not generate document id as it is generated by the APF parser.
-   }
-
    /**
     * @public
     *

diff --git a/extensions/form/client/taglib/ClientValidationListenerTag.php b/extensions/form/client/taglib/ClientValidationListenerTag.php
@@ -35,10 +35,6 @@
  */
 class ClientValidationListenerTag extends AbstractFormControl {
 
-   public function __construct() {
-      // nothing to do here, especially not generate document id as it is generated by the APF parser.
-   }
-
    /**
     * Overwrite the parent's method.
     *

diff --git a/extensions/form/client/taglib/FormClientErrorDisplayTag.php b/extensions/form/client/taglib/FormClientErrorDisplayTag.php
@@ -34,10 +34,6 @@
  */
 class FormClientErrorDisplayTag extends AbstractFormControl {
 
-   public function __construct() {
-      // nothing to do here, especially not generate document id as it is generated by the APF parser.
-   }
-
    /**
     * Overwrite the parent's method.
     *

diff --git a/extensions/forwardmessage/pres/taglib/AddForwardMessageTag.php b/extensions/forwardmessage/pres/taglib/AddForwardMessageTag.php
@@ -38,10 +38,6 @@
  */
 class AddForwardMessageTag extends Document {
 
-   public function __construct() {
-      // nothing to do here, especially not generate document id as it is generated by the APF parser.
-   }
-
    public function onParseTime() {
 
       if (!$name = $this->getAttribute('name')) {

diff --git a/extensions/htmlheader/pres/taglib/HtmlHeaderAddTitleTag.php b/extensions/htmlheader/pres/taglib/HtmlHeaderAddTitleTag.php
@@ -48,10 +48,6 @@
  */
 class HtmlHeaderAddTitleTag extends Document {
 
-   public function __construct() {
-      // nothing to do here, especially not generate document id as it is generated by the APF parser.
-   }
-
    public function onParseTime() {
       $this->extractTagLibTags();
    }

diff --git a/extensions/htmllist/taglib/ListDefinitionTag.php b/extensions/htmllist/taglib/ListDefinitionTag.php
@@ -32,10 +32,6 @@
  */
 class ListDefinitionTag extends AbstractListTag {
 
-   public function __construct() {
-      // nothing to do here, especially not generate document id as it is generated by the APF parser.
-   }
-
    /**
     * Adds a definition term element.
     *

diff --git a/extensions/htmllist/taglib/OrderedListTag.php b/extensions/htmllist/taglib/OrderedListTag.php
@@ -32,10 +32,6 @@
  */
 class OrderedListTag extends AbstractListTag {
 
-   public function __construct() {
-      // nothing to do here, especially not generate document id as it is generated by the APF parser.
-   }
-
    /**
     * Adds a list element.
     *

diff --git a/extensions/htmllist/taglib/UnorderedListTag.php b/extensions/htmllist/taglib/UnorderedListTag.php
@@ -32,10 +32,6 @@
  */
 class UnorderedListTag extends AbstractListTag {
 
-   public function __construct() {
-      // nothing to do here, especially not generate document id as it is generated by the APF parser.
-   }
-
    /**
     * Adds a list element
     *

diff --git a/modules/recaptcha/pres/taglib/ReCaptchaTag.php b/modules/recaptcha/pres/taglib/ReCaptchaTag.php
@@ -63,10 +63,6 @@ class ReCaptchaTag extends AbstractFormControl {
     */
    private $errorMessageKey;
 
-   public function __construct() {
-      // nothing to do here, especially not generate document id as it is generated by the APF parser.
-   }
-
    /**
     * @public
     *

diff --git a/modules/usermanagement/pres/taglib/UmgtMediaInclusionTag.php b/modules/usermanagement/pres/taglib/UmgtMediaInclusionTag.php
@@ -34,10 +34,6 @@
  */
 class UmgtMediaInclusionTag extends MediaInclusionTag {
 
-   public function __construct() {
-      // nothing to do here, especially not generate document id as it is generated by the APF parser.
-   }
-
    /**
     * @public
     *

diff --git a/tools/form/taglib/FormErrorDisplayTag.php b/tools/form/taglib/FormErrorDisplayTag.php
@@ -43,10 +43,6 @@
  */
 class FormErrorDisplayTag extends AbstractFormControl {
 
-   public function __construct() {
-      // nothing to do here, especially not generate document id as it is generated by the APF parser.
-   }
-
    /**
     * @public
     *

diff --git a/tools/form/taglib/FormSuccessDisplayTag.php b/tools/form/taglib/FormSuccessDisplayTag.php
@@ -43,10 +43,6 @@
  */
 class FormSuccessDisplayTag extends AbstractFormControl {
 
-   public function __construct() {
-      // nothing to do here, especially not generate document id as it is generated by the APF parser.
-   }
-
    /**
     * @public
     *

diff --git a/tools/form/taglib/ValidationListenerTag.php b/tools/form/taglib/ValidationListenerTag.php
@@ -57,10 +57,6 @@ class ValidationListenerTag extends AbstractFormControl {
     */
    protected $isNotified = false;
 
-   public function __construct() {
-      // nothing to do here, especially not generate document id as it is generated by the APF parser.
-   }
-
    /**
     * @public
     *

diff --git a/tools/html/taglib/HtmlIteratorItemTag.php b/tools/html/taglib/HtmlIteratorItemTag.php
@@ -36,10 +36,6 @@
  */
 class HtmlIteratorItemTag extends Document {
 
-   public function __construct() {
-      // nothing to do here, especially not generate document id as it is generated by the APF parser.
-   }
-
    public function onParseTime() {
       $this->extractTagLibTags();
    }

diff --git a/tools/html/taglib/HtmlIteratorTag.php b/tools/html/taglib/HtmlIteratorTag.php
@@ -94,10 +94,6 @@ class HtmlIteratorTag extends Document {
     */
    protected $iterationNumber = 0;
 
-   public function __construct() {
-      // nothing to do here, especially not generate document id as it is generated by the APF parser.
-   }
-
    public function onParseTime() {
       $this->extractTagLibTags();
    }

diff --git a/tools/link/taglib/HtmlLinkTag.php b/tools/link/taglib/HtmlLinkTag.php
@@ -67,10 +67,6 @@ class HtmlLinkTag extends LinkGenerationTag {
          'shape',
          'target');
 
-   public function __construct() {
-      // nothing to do here, especially not generate document id as it is generated by the APF parser.
-   }
-
    public function onParseTime() {
 
       // generate URL using our parent implementation