Allow use of an INI-file instead of the Registry #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the `-conf` switch which, if specified, will use an INI-file instead of the Windows Registry. This addresses AppleWin#709 and AppleWin#446.
|
@taeber - this PR looks simple and neat, so I don't see any issues in accepting it(*). Before I merge it in, I want to give it some testing. I'll try to find some time this week. Thanks! (*) MSDN says that GetPrivateProfileString() and WritePrivateProfileString() are intended for Win16 compatiblity... so I wonder for how much longer Microsoft will keep them for? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
-confswitch which, if specified, will use an INI-file instead of the Windows Registry.This affects #709 and #446.
Testing
I tested this using VS2019 on Windows 10.
AppleWin.exe.AppleWin.exe -conf config.ini, whereconfig.iniis a non-existing file.config.ini. Also note that no values in the Registry should be changed (this is easy to test if you remove the AppleWin group first so you can see that nothing is created).AppleWin.exenormally (without-conf). Change some settings. Notice that the Registry is used and theconfig.iniis unaffected.