@@ -1,5 +1,6 @@ = ActiveMerchant CHANGELOG +* Update gateway templates [cody] * Fix Authorize.net test where authorize() was being called instead of purchase(). Perform some cleanup of the tests [ianlotin...@hotmail.com, cody] * Improve Authorize.net documentation based on the DataCashGateway docs [patrick.t.joyce] * Update EfsnetGateway to support avs and cvv data. Remove test_result_from_cc_number. [cody] CHANGELOG @@ -46,10 +46,6 @@ module ActiveMerchant #:nodoc: commit('capture', money, post) end - def self.supported_cardtypes - [:visa, :master, :american_express] - end - private def add_customer_data(post, options) generators/gateway/templates/gateway.rb @@ -1,44 +1,49 @@ require File.dirname(__FILE__) + '/../../test_helper' class <%= class_name %>Test < Test::Unit::TestCase - AMOUNT = 100 - def setup @gateway = <%= class_name %>Gateway.new( :login => 'login', :password => 'password' ) - @creditcard = credit_card('4242424242424242') - - @address = { :address1 => '1234 My Street', - :address2 => 'Apt 1', - :company => 'Widgets Inc', - :city => 'Ottawa', - :state => 'ON', - :zip => 'K1C2N6', - :country => 'Canada', - :phone => '(555)555-5555' - } + @credit_card = credit_card + @amount = 100 + + @options = { + :order_id => '1', + :billing_address => address, + :description => 'Store Purchase' + } end - def test_successful_request - @creditcard.number = 1 - assert response = @gateway.purchase(AMOUNT, @creditcard, {}) + def test_successful_purchase + @gateway.expects(:ssl_post).returns(successful_purchase_response) + + assert response = @gateway.purchase(@amount, @credit_card, @options) + assert_instance_of assert_success response - assert_equal '5555', response.authorization + + # Replace with authorization number from the successful response + assert_equal '', response.authorization assert response.test? end def test_unsuccessful_request - @creditcard.number = 2 - assert response = @gateway.purchase(AMOUNT, @creditcard, {}) + @gateway.expects(:ssl_post).returns(failed_purchase_response) + + assert response = @gateway.purchase(@amount, @credit_card, @options) assert_failure response assert response.test? end - def test_request_error - @creditcard.number = 3 - assert_raise(Error){ @gateway.purchase(AMOUNT, @creditcard, {}) } + private + + # Place raw successful response from gateway here + def successful_purchase_response + end + + # Place raw failed response from gateway here + def failed_purcahse_response end end generators/gateway/templates/gateway_test.rb @@ -1,36 +1,37 @@ require File.dirname(__FILE__) + '/../test_helper' class Remote<%= class_name %>Test < Test::Unit::TestCase - AMOUNT = 100 + def setup @gateway = <%= class_name %>Gateway.new(fixtures(:<%= class_name.underscore %>)) - - @creditcard = credit_card('4000100011112224') - + + @amount = 100 + @credit_card = credit_card('4000100011112224') @declined_card = credit_card('4000300011112220') - - @options = { :address => { :address1 => '1234 Shady Brook Lane', - :zip => '90210' - } - } + + @options = { + :order_id => '1', + :billing_address => address, + :description => 'Store Purchase' + } end def test_successful_purchase - assert response = @gateway.purchase(AMOUNT, @creditcard, @options) - assert_equal 'REPLACE WITH SUCCESS MESSAGE', response.message + assert response = @gateway.purchase(@amount, @credit_card, @options) assert_success response + assert_equal 'REPLACE WITH SUCCESS MESSAGE', response.message end def test_unsuccessful_purchase - assert response = @gateway.purchase(AMOUNT, @declined_card, @options) - assert_equal 'REPLACE WITH FAILED PURCHASE MESSAGE', response.message + assert response = @gateway.purchase(@amount, @declined_card, @options) assert_failure response + assert_equal 'REPLACE WITH FAILED PURCHASE MESSAGE', response.message end def test_authorize_and_capture - amount = AMOUNT - assert auth = @gateway.authorize(amount, @creditcard, @options) + amount = @amount + assert auth = @gateway.authorize(amount, @credit_card, @options) assert_success auth assert_equal 'Success', auth.message assert auth.authorization @@ -39,18 +40,18 @@ class Remote<%= class_name %>Test < Test::Unit::TestCase end def test_failed_capture - assert response = @gateway.capture(AMOUNT, '') + assert response = @gateway.capture(@amount, '') assert_failure response assert_equal 'REPLACE WITH GATEWAY FAILURE MESSAGE', response.message end def test_invalid_login - gateway = <%= class_name %>Gateway.new({ - :login => '', - :password => '' - }) - assert response = gateway.purchase(AMOUNT, @creditcard, @options) - assert_equal 'REPLACE WITH FAILURE MESSAGE', response.message + gateway = <%= class_name %>Gateway.new( + :login => '', + :password => '' + ) + assert response = gateway.purchase(@amount, @credit_card, @options) assert_failure response + assert_equal 'REPLACE WITH FAILURE MESSAGE', response.message end end generators/gateway/templates/remote_gateway_test.rb @@ -126,9 +126,9 @@ module Test md5.hexdigest end - def credit_card(number = nil, options = {}) + def credit_card(number = '4242424242424242', options = {}) defaults = { - :number => (number || '4242424242424242'), + :number => number, :month => 9, :year => Time.now.year + 1, :first_name => 'Longbob', test/test_helper.rb f410edc61cc5466459c2862697b5c13513254017 codyfauser codyfauser@6513ea26-6c20-0410-8a68-89cd7235086d http://github.com/BDQ/active_merchant/commit/7098f41a9b9d6f0680e208c3c72fe5b03f30fc05 7098f41a9b9d6f0680e208c3c72fe5b03f30fc05 2008-01-18T13:46:11-08:00 2008-01-18T13:46:11-08:00 Update gateway templates git-svn-id: https://activemerchant.googlecode.com/svn/trunk/active_merchant@561 6513ea26-6c20-0410-8a68-89cd7235086d 9653c444d9f6bb80c3e616afeb6b0b99934d01bb codyfauser codyfauser@6513ea26-6c20-0410-8a68-89cd7235086d