Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ExportToSpreadsheet saves Experiment.csv to default output folder #1110

Closed
dlogan opened this issue Apr 18, 2014 · 11 comments
Closed
Assignees

Comments

@dlogan
Copy link
Member

dlogan commented Apr 18, 2014

If ExportToSpreadsheet saves to a subfolder of the Default Output folder, and that folder uses Metadata tags, then the Experiment.csv is saved to the DOF, and not the specified subfolder. All the other CSV files are put in the correct folder.

(Note: I used the Welcome Screen Fly images to test this.)

Attachments:
http://cellprofiler.org/issues/uploaded/cBQc5K/project_Experiment_CSV.cpproj

@dlogan dlogan added this to the CellProfiler 2.1.1 patch release milestone Apr 18, 2014
@LeeKamentsky
Copy link

It's a little tricky. For all csv's other than Experiment, each row is tied to a particular imageset and that imageset has a definition for each metadata tag. Experiment is different - if there are two plates, and consequently two directories with the two different plate names embedded in them, which directory do I use?

Several choices:

  • Give up and use the default output folder (current)
  • Use the metadata from the first image set
  • Use a placeholder ("Experiment", "Plate" ?) instead of one of the possible values
  • Display a second folder location box for Experiment.csv if the user uses metadata tags in their folder names.

Let me know and I'll fix it that way.

@braymp
Copy link
Contributor

braymp commented May 27, 2014

I think I like the current behavior of using the DOF. Either that or the last option.

@dlogan
Copy link
Member Author

dlogan commented May 27, 2014

I see. In the case in which there are multiple different tags used (e.g. "Plate") then I can see the issue, however the example I used had only a single plate, though I still wanted the metadata name substituted. In that case, it seems less intuitive that the Experiment CSV would be saved in a different location (e.g. DOF). So to be explicit, I prefer the last choice. If it's annoying to code for whatever reason, the DOF is a reasonable choice though too.

Either way, we should be explicit about the location in the Help (I didn't see it immediately).

@0x00b1 0x00b1 removed this from the CellProfiler 2.1.1 patch release milestone Mar 30, 2016
@AnneCarpenter
Copy link
Member

Given that at least one reputable person in the world likes the current behavior, let's just document the behavior in the help and be done with it.

@AnneCarpenter
Copy link
Member

(Could I ask @dlogan or @braymp to do this, if either of you still has an understanding of the issue?)

@AnneCarpenter AnneCarpenter self-assigned this Sep 2, 2016
@dlogan
Copy link
Member Author

dlogan commented Oct 12, 2016

Yes, I can add a little Help clarification for this soon.

@dlogan dlogan self-assigned this Oct 12, 2016
@mcquin mcquin changed the title ExportToSpreadsheet can save Experiment.csv to incorrect folder Document ExportToSpreadsheet saves Experiment.csv to default output folder Jan 6, 2017
@AnneCarpenter
Copy link
Member

Hey @dlogan if you can just type the correct text in a comment I'm happy to put it in properly as a pull request.

@AnneCarpenter
Copy link
Member

I will do this (as best I can)

AnneCarpenter added a commit to AnneCarpenter/CellProfiler that referenced this issue Sep 19, 2017
Solves CellProfiler#1110
I'm flying blind so I've no idea if I rendered the URL properly. Please check it in the GUI!
@AnneCarpenter
Copy link
Member

Strangely, I don't seem to have the power to close this issue @mcquin

@mcquin
Copy link
Contributor

mcquin commented Sep 20, 2017

Closed #3232

@mcquin mcquin closed this as completed Sep 20, 2017
@dlogan
Copy link
Member Author

dlogan commented Oct 5, 2017

sorry @AnneCarpenter I lost track of this. Your text edits read fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants