Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hmolar, smolar etc. are incorrect for HEOS backend with PD inputs #273

Closed
mayersre opened this issue Dec 3, 2014 · 6 comments
Closed

hmolar, smolar etc. are incorrect for HEOS backend with PD inputs #273

mayersre opened this issue Dec 3, 2014 · 6 comments
Milestone

Comments

@mayersre
Copy link

mayersre commented Dec 3, 2014

The two examples with result show the problem
Coolprop 5.0.2/Python 3.4/Windows 8

cp.PropsSI('H','P',50000,'D',2.22,'R407C')
result = 2527963510.2319546

cp.PropsSI('H','P',50000,'D',2.22,'REFPROP::R407C')
result = 392821.67054645496

@ibell ibell added this to the v5.0.1 milestone Dec 3, 2014
@ibell
Copy link
Contributor

ibell commented Dec 3, 2014

In any case, its a bug and we will fix it in 5.0.1

@ibell
Copy link
Contributor

ibell commented Dec 3, 2014

Off the top of your head - any idea which one is right?

On Wed, Dec 3, 2014 at 1:15 PM, mayersre notifications@github.com wrote:

The two examples with result show the problem
Coolprop 5.0.2/Python 3.4/Windows 8

cp.PropsSI('H','P',50000,'D',2.22,'R407C')
result = 2527963510.2319546

cp.PropsSI('H','P',50000,'D',2.22,'REFPROP::R407C')
result = 392821.67054645496


Reply to this email directly or view it on GitHub
#273.

@ibell ibell removed this from the v5.0.3 milestone Dec 3, 2014
@ibell
Copy link
Contributor

ibell commented Dec 3, 2014

Sounds like we are getting the liquid solution instead of the vapor solution

Interestingly, we get the same temperature:

In [1]: import CoolProp

In [2]: CoolProp.CoolProp.PropsSI('H','P',50000,'D',2.22,'R407C')
Out[2]: 2527963510.2319517

In [3]: CoolProp.CoolProp.PropsSI('H','P',50000,'D',2.22,'REFPROP::R407C')
Out[3]: 392821.6705464548

In [4]: CoolProp.CoolProp.PropsSI('T','P',50000,'D',2.22,'R407C')
Out[4]: 238.05110549432456

In [5]: CoolProp.CoolProp.PropsSI('T','P',50000,'D',2.22,'REFPROP::R407C')
Out[5]: 238.05110553305806

@ibell
Copy link
Contributor

ibell commented Dec 3, 2014

Looks like it is only a question of reference state:

In [7]: CoolProp.CoolProp.PropsSI('P','T',T,'D',2.22,'REFPROP::R407C')
Out[7]: 50000.0

In [8]: CoolProp.CoolProp.PropsSI('P','T',T,'D',2.22,'R407C')
Out[8]: 50000.00000863266

@ibell
Copy link
Contributor

ibell commented Dec 3, 2014

Need to add a test for reference state for enthalpy for pseudo-pure as well: #276

@ibell ibell closed this as completed Dec 3, 2014
@ibell ibell reopened this Dec 4, 2014
@ibell ibell added this to the v5.0.2 milestone Dec 4, 2014
@ibell ibell changed the title Coolprop vs refprop same call, different output hmolar, smolar etc. are incorrect for REFPROP backend Dec 4, 2014
@ibell
Copy link
Contributor

ibell commented Dec 4, 2014

Hmm. Now I am confused.

@ibell ibell changed the title hmolar, smolar etc. are incorrect for REFPROP backend hmolar, smolar etc. are incorrect for HEOS backend Dec 4, 2014
@ibell ibell changed the title hmolar, smolar etc. are incorrect for HEOS backend hmolar, smolar etc. are incorrect for HEOS backend with PD inputs Dec 4, 2014
@ibell ibell closed this as completed in 74a1816 Dec 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants