Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D-P is far slower than it should be #751

Closed
ibell opened this issue Jul 27, 2015 · 2 comments
Closed

D-P is far slower than it should be #751

ibell opened this issue Jul 27, 2015 · 2 comments
Milestone

Comments

@ibell
Copy link
Contributor

ibell commented Jul 27, 2015

See also #411

HEOS
T D 4.40697642479
T P 8.64431444199
P S 51.391382067
P H 59.1938432728
P U 59.8328548544
D P 69.4174248829
T S 109.0744776
D H 114.137972773
H S 1329.19389459
REFPROP
T D 3.30372308009
T P 4.875142208
D P 7.79551870867
D H 46.6686729477
P U 51.4656366013
P H 52.0720486313
T S 61.3970296375
P S 91.1085024762
H S 486.036072611
@ibell ibell added this to the v5.1.2 milestone Jul 28, 2015
@thorade
Copy link
Contributor

thorade commented Jul 28, 2015

You do of course know the Span 2000 book, and I assume you are aware of his suggestion to solve the van der Waals EoS for T to obtain a start value. Without looking at your code/implementation (and just because I like posting links), here is a link to page 52 of the book:
https://books.google.de/books?id=dd410GGw8wUC&pg=PA52

@ibell
Copy link
Contributor Author

ibell commented Jul 29, 2015

Yup, I am aware of that method, I'm not sure why I didn't implement it, its
not too complex, and I think I was just lazy.

On Tue, Jul 28, 2015 at 1:27 AM, Matthis Thorade notifications@github.com
wrote:

You do of course know the Span 2000 book, and I assume you are aware of
his suggestion to solve the van der Waals EoS for T to obtain a start
value. Without looking at your code/implementation (and just because I like
posting links), here is a link to page 52 of the book:
https://books.google.de/books?id=dd410GGw8wUC&pg=PA52


Reply to this email directly or view it on GitHub
#751 (comment).

@ibell ibell closed this as completed in 39cb120 Aug 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants