{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":446400041,"defaultBranch":"dev/1.6","name":"architectury-loom","ownerLogin":"EssentialGG","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2022-01-10T11:43:50.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/103071002?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714471008.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"880530369435f0e9bec9bb1a8732db5c774ac45e","ref":"refs/heads/dev/1.6","pushedAt":"2024-04-30T09:56:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Johni0702","name":"Jonas Herzig","path":"/Johni0702","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/818778?s=80&v=4"},"commit":{"message":"Merge branch 'dev/1.5' into dev/1.6","shortMessageHtmlLink":"Merge branch 'dev/1.5' into dev/1.6"}},{"before":"15039924d1d1726d3325fa2a4a010001aeb55234","after":"16098c9754e323241a81534155bb587e31f67ad3","ref":"refs/heads/tmp/dj/1.6","pushedAt":"2024-04-30T00:51:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"DJtheRedstoner","name":null,"path":"/DJtheRedstoner","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52044242?s=80&v=4"},"commit":{"message":"fix OfflineModeTest","shortMessageHtmlLink":"fix OfflineModeTest"}},{"before":null,"after":"15039924d1d1726d3325fa2a4a010001aeb55234","ref":"refs/heads/tmp/dj/1.6","pushedAt":"2024-04-30T00:11:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"DJtheRedstoner","name":null,"path":"/DJtheRedstoner","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52044242?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'refs/remotes/upstream/dev/1.6' into tmp/1.6\n\n# Conflicts:\n#\tbuild.gradle\n#\tgradle/test.libs.versions.toml\n#\tsrc/main/java/net/fabricmc/loom/configuration/CompileConfiguration.java\n#\tsrc/main/java/net/fabricmc/loom/configuration/providers/forge/minecraft/MergedForgeMinecraftProvider.java\n#\tsrc/main/java/net/fabricmc/loom/util/Constants.java\n#\tsrc/main/java/net/fabricmc/loom/util/fmj/FabricModJsonFactory.java\n#\tsrc/test/resources/projects/kotlin/build.gradle.kts","shortMessageHtmlLink":"Merge remote-tracking branch 'refs/remotes/upstream/dev/1.6' into tmp…"}},{"before":"eec703d31decbe6799df6f79eb1a8587502d2f03","after":null,"ref":"refs/heads/tmp/1.5","pushedAt":"2024-04-29T14:09:14.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Johni0702","name":"Jonas Herzig","path":"/Johni0702","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/818778?s=80&v=4"}},{"before":null,"after":"eec703d31decbe6799df6f79eb1a8587502d2f03","ref":"refs/heads/dev/1.5","pushedAt":"2024-04-29T14:08:40.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Johni0702","name":"Jonas Herzig","path":"/Johni0702","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/818778?s=80&v=4"},"commit":{"message":"Merge branch 'dev/1.4' into dev/1.5","shortMessageHtmlLink":"Merge branch 'dev/1.4' into dev/1.5"}},{"before":null,"after":"eec703d31decbe6799df6f79eb1a8587502d2f03","ref":"refs/heads/tmp/1.5","pushedAt":"2024-04-29T13:16:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Johni0702","name":"Jonas Herzig","path":"/Johni0702","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/818778?s=80&v=4"},"commit":{"message":"Merge branch 'dev/1.4' into dev/1.5","shortMessageHtmlLink":"Merge branch 'dev/1.4' into dev/1.5"}},{"before":"f4361aaf7ee00447ead25f169f2e5c500d40f482","after":"ac64aa8d6bdad0c2585482e75d63133e6455d8e0","ref":"refs/heads/dev/1.4","pushedAt":"2024-03-25T13:25:39.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"Johni0702","name":"Jonas Herzig","path":"/Johni0702","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/818778?s=80&v=4"},"commit":{"message":"Update path used to get generated sources during tests","shortMessageHtmlLink":"Update path used to get generated sources during tests"}},{"before":null,"after":"f4361aaf7ee00447ead25f169f2e5c500d40f482","ref":"refs/heads/dev/1.4","pushedAt":"2024-03-25T11:57:27.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Johni0702","name":"Jonas Herzig","path":"/Johni0702","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/818778?s=80&v=4"},"commit":{"message":"Merge branch 'dev/1.3' into dev/1.4","shortMessageHtmlLink":"Merge branch 'dev/1.3' into dev/1.4"}},{"before":"23378588ad3824feeb4339f0965ac3e75321b001","after":"21bfc0f7049e47214dba97cd36d9cc5cf236c2c7","ref":"refs/heads/dev/1.3","pushedAt":"2023-10-30T20:10:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"DJtheRedstoner","name":null,"path":"/DJtheRedstoner","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52044242?s=80&v=4"},"commit":{"message":"update readme [skip ci]","shortMessageHtmlLink":"update readme [skip ci]"}},{"before":"02a5f3a70125aed4207cf52b2935b2f823442714","after":null,"ref":"refs/heads/fix/buildsharedservicemanager-memory-leak","pushedAt":"2023-09-27T07:03:26.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Johni0702","name":"Jonas Herzig","path":"/Johni0702","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/818778?s=80&v=4"}},{"before":"273c9c4531c1fb5fa36f361ea8ae3aa04945e25f","after":"23378588ad3824feeb4339f0965ac3e75321b001","ref":"refs/heads/dev/1.3","pushedAt":"2023-09-27T07:03:22.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Johni0702","name":"Jonas Herzig","path":"/Johni0702","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/818778?s=80&v=4"},"commit":{"message":"Fix BuildSharedServiceManager not releasing memory during build\n\nThe `BuildSharedServiceManager` is used by `RemapJarTask` and\r\n`RemapSourcesJarTask` to prevent having to load mappings and potentially\r\nTinyRemapper multiple times.\r\nAnd while it does seemingly have a reference counter, only the thing as a whole\r\nis reference counted, not the individual services. As such, if a build contains\r\nmany projects on different MC versions, even if the mappings for one of those\r\nversions will no longer be used during the rest of the build, the manager will\r\nstill hold onto them, slowly but surely consuming more and more memory as the\r\nbuild progresses.\r\n\r\nThis commit works around the issue by creating a separate\r\n`BuildSharedServiceManager` per project (unless multiProjectOptimisation is\r\nenabled), such that once all tasks of one project have completed, that whole\r\nmanager can be released.\r\nFor a proper fix one would likely want to do reference counting on the\r\nSharedService level and/or use SoftReferences so cached data can be disposed of\r\nif memory becomes scarce.\r\n\r\nThis workaround isn't ideal in that:\r\n- Gradle is not required to run all tasks of one project before it goes to the\r\nnext one; in the worst case it could run `remapJar` of all projects before\r\nrunning any `remapSourcesJar` tasks, effectively voiding this workaround. In\r\npractice it seems to behave quite well though.\r\n- Projects that used to be able to share services will now need to initialize\r\nthem multiple times. Given our Loom fork is primarily used to develop\r\nmulti-version-heavy, not multi-project-heavy projects, this seems like an\r\nacceptable trade-off (e.g. none of our libs are able to make use of the\r\nsharing to begin with).\r\n\r\nGitHub: #9","shortMessageHtmlLink":"Fix BuildSharedServiceManager not releasing memory during build"}},{"before":null,"after":"02a5f3a70125aed4207cf52b2935b2f823442714","ref":"refs/heads/fix/buildsharedservicemanager-memory-leak","pushedAt":"2023-09-26T14:20:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Johni0702","name":"Jonas Herzig","path":"/Johni0702","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/818778?s=80&v=4"},"commit":{"message":"Fix BuildSharedServiceManager not releasing memory during build\n\nThe `BuildSharedServiceManager` is used by `RemapJarTask` and\n`RemapSourcesJarTask` to prevent having to load mappings and potentially\nTinyRemapper multiple times.\nAnd while it does seemingly have a reference counter, only the thing as a whole\nis reference counted, not the individual services. As such, if a build contains\nmany projects on different MC versions, even if the mappings for one of those\nversions will no longer be used during the rest of the build, the manager will\nstill hold onto them, slowly but surely consuming more and more memory as the\nbuild progresses.\n\nThis commit works around the issue by creating a separate\n`BuildSharedServiceManager` per project (unless multiProjectOptimisation is\nenabled), such that once all tasks of one project have completed, that whole\nmanager can be released.\nFor a proper fix one would likely want to do reference counting on the\nSharedService level and/or use SoftReferences so cached data can be disposed of\nif memory becomes scarce.\n\nThis workaround isn't ideal in that:\n- Gradle is not required to run all tasks of one project before it goes to the\nnext one; in the worst case it could run `remapJar` of all projects before\nrunning any `remapSourcesJar` tasks, effectively voiding this workaround. In\npractice it seems to behave quite well though.\n- Projects that used to be able to share services will now need to initialize\nthem multiple times. Given our Loom fork is primarily mainly used to develop\nmulti-version-heavy, not multi-project-heavy projects, this seems like an\nacceptable trade-off (e.g. none of our libs are able to make use of the\nsharing to begin with).","shortMessageHtmlLink":"Fix BuildSharedServiceManager not releasing memory during build"}},{"before":"d2c8a1441ba0d98c90fa7fb09fe9285cc825661f","after":"273c9c4531c1fb5fa36f361ea8ae3aa04945e25f","ref":"refs/heads/dev/1.3","pushedAt":"2023-08-14T08:58:13.000Z","pushType":"push","commitsCount":9,"pusher":{"login":"Johni0702","name":"Jonas Herzig","path":"/Johni0702","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/818778?s=80&v=4"},"commit":{"message":"Fix reproducible timestamps depending on timezone\n\nSee https://github.com/FabricMC/fabric-loom/issues/942","shortMessageHtmlLink":"Fix reproducible timestamps depending on timezone"}},{"before":"6c1d1fff68a1cc5345e2654f12a770a47153febd","after":"d2c8a1441ba0d98c90fa7fb09fe9285cc825661f","ref":"refs/heads/dev/1.3","pushedAt":"2023-08-10T08:57:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Johni0702","name":"Jonas Herzig","path":"/Johni0702","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/818778?s=80&v=4"},"commit":{"message":"Fix non-reproducible build due to HashSet iteration order","shortMessageHtmlLink":"Fix non-reproducible build due to HashSet iteration order"}},{"before":null,"after":"6c1d1fff68a1cc5345e2654f12a770a47153febd","ref":"refs/heads/dev/1.3","pushedAt":"2023-08-08T09:46:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Johni0702","name":"Jonas Herzig","path":"/Johni0702","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/818778?s=80&v=4"},"commit":{"message":"Merge branch 'dev/1.2' into dev/1.3","shortMessageHtmlLink":"Merge branch 'dev/1.2' into dev/1.3"}},{"before":"1ea242d430fd86df486b3bb4be961813ca143e61","after":"fac5c9f39f34406ab08f3e1bdbd62060472f187a","ref":"refs/heads/dev/1.2","pushedAt":"2023-07-27T18:52:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"DJtheRedstoner","name":null,"path":"/DJtheRedstoner","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52044242?s=80&v=4"},"commit":{"message":"Fix NPE","shortMessageHtmlLink":"Fix NPE"}},{"before":"a3f299cdaf7ed2b828bbe8a95c9ac76a48b5cafe","after":"1ea242d430fd86df486b3bb4be961813ca143e61","ref":"refs/heads/dev/1.2","pushedAt":"2023-07-27T18:25:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"DJtheRedstoner","name":null,"path":"/DJtheRedstoner","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52044242?s=80&v=4"},"commit":{"message":"testing456","shortMessageHtmlLink":"testing456"}},{"before":"15b41b6c7acd99d8113ba11d13e64bc6394a170c","after":"a3f299cdaf7ed2b828bbe8a95c9ac76a48b5cafe","ref":"refs/heads/dev/1.2","pushedAt":"2023-07-27T18:18:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"DJtheRedstoner","name":null,"path":"/DJtheRedstoner","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52044242?s=80&v=4"},"commit":{"message":"testing123","shortMessageHtmlLink":"testing123"}},{"before":"70d36e69781096f5e1037c47456781766b123a20","after":"15b41b6c7acd99d8113ba11d13e64bc6394a170c","ref":"refs/heads/dev/1.2","pushedAt":"2023-07-27T16:25:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"DJtheRedstoner","name":null,"path":"/DJtheRedstoner","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52044242?s=80&v=4"},"commit":{"message":"lets try this again","shortMessageHtmlLink":"lets try this again"}},{"before":"152a7e35921d73eab24dc2f5f845b70af523c299","after":"70d36e69781096f5e1037c47456781766b123a20","ref":"refs/heads/dev/1.2","pushedAt":"2023-07-27T16:23:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"DJtheRedstoner","name":null,"path":"/DJtheRedstoner","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52044242?s=80&v=4"},"commit":{"message":"Use environment variables for secrets","shortMessageHtmlLink":"Use environment variables for secrets"}},{"before":"e5a16fda4924ae9877faa838f945d810b34b580c","after":null,"ref":"refs/heads/misc-fixes","pushedAt":"2023-07-26T11:34:54.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Johni0702","name":"Jonas Herzig","path":"/Johni0702","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/818778?s=80&v=4"}},{"before":"e22afc076f539496476da7f3845f3e6ad01e467b","after":"152a7e35921d73eab24dc2f5f845b70af523c299","ref":"refs/heads/dev/1.2","pushedAt":"2023-07-26T11:34:44.000Z","pushType":"pr_merge","commitsCount":6,"pusher":{"login":"Johni0702","name":"Jonas Herzig","path":"/Johni0702","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/818778?s=80&v=4"},"commit":{"message":"Merge pull request #5 from EssentialGG/misc-fixes\n\nMiscellaneous fixes","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1772987212\" data-permission-text=\"Title is private\" data-url=\"https://github.com/EssentialGG/architectury-loom/issues/5\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/EssentialGG/architectury-loom/pull/5/hovercard\" href=\"https://github.com/EssentialGG/architectury-loom/pull/5\">#5</a> from EssentialGG/misc-fixes"}},{"before":"e238cb481a5232aa284d62105f504fad2bd92cd4","after":"e5a16fda4924ae9877faa838f945d810b34b580c","ref":"refs/heads/misc-fixes","pushedAt":"2023-07-07T12:01:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"DJtheRedstoner","name":null,"path":"/DJtheRedstoner","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52044242?s=80&v=4"},"commit":{"message":"Disable the genForgePatchedSources task on legacy forge","shortMessageHtmlLink":"Disable the genForgePatchedSources task on legacy forge"}},{"before":"04141610c8eeb1681fb407ea166a808b6cda8c70","after":"e238cb481a5232aa284d62105f504fad2bd92cd4","ref":"refs/heads/misc-fixes","pushedAt":"2023-06-25T00:56:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"DJtheRedstoner","name":null,"path":"/DJtheRedstoner","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52044242?s=80&v=4"},"commit":{"message":"Update plugin ID in new tests","shortMessageHtmlLink":"Update plugin ID in new tests"}},{"before":null,"after":"04141610c8eeb1681fb407ea166a808b6cda8c70","ref":"refs/heads/misc-fixes","pushedAt":"2023-06-25T00:42:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"DJtheRedstoner","name":null,"path":"/DJtheRedstoner","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52044242?s=80&v=4"},"commit":{"message":"Configure publishing for Essential maven","shortMessageHtmlLink":"Configure publishing for Essential maven"}},{"before":"e7b3ef407c28e9589bda28569dc5538ad9f74d68","after":"e22afc076f539496476da7f3845f3e6ad01e467b","ref":"refs/heads/dev/1.2","pushedAt":"2023-06-21T13:49:30.262Z","pushType":"push","commitsCount":4,"pusher":{"login":"Johni0702","name":"Jonas Herzig","path":"/Johni0702","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/818778?s=80&v=4"},"commit":{"message":"Disable publication of snapshot version","shortMessageHtmlLink":"Disable publication of snapshot version"}},{"before":null,"after":"e7b3ef407c28e9589bda28569dc5538ad9f74d68","ref":"refs/heads/dev/1.2","pushedAt":"2023-06-19T08:28:32.373Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Johni0702","name":"Jonas Herzig","path":"/Johni0702","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/818778?s=80&v=4"},"commit":{"message":"Please checkstyle","shortMessageHtmlLink":"Please checkstyle"}},{"before":null,"after":"c6407aebd2133da78927c0bd56b06003e21f45ee","ref":"refs/heads/tmp/1.2","pushedAt":"2023-06-13T11:18:21.320Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Johni0702","name":"Jonas Herzig","path":"/Johni0702","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/818778?s=80&v=4"},"commit":{"message":"fixup","shortMessageHtmlLink":"fixup"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEPdj0iQA","startCursor":null,"endCursor":null}},"title":"Activity · EssentialGG/architectury-loom"}