Skip to content

Commit

Permalink
fix typos & whitespaces
Browse files Browse the repository at this point in the history
  • Loading branch information
wwmayer committed Dec 21, 2016
1 parent 7fd367a commit 1a20ead
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 14 deletions.
17 changes: 9 additions & 8 deletions src/Gui/ViewProvider.cpp
Expand Up @@ -397,9 +397,8 @@ void ViewProvider::setModeSwitch()
{
if (viewOverrideMode == -1)
pcModeSwitch->whichChild = _iActualMode;
else
if (viewOverrideMode < pcModeSwitch->getNumChildren())
pcModeSwitch->whichChild = viewOverrideMode;
else if (viewOverrideMode < pcModeSwitch->getNumChildren())
pcModeSwitch->whichChild = viewOverrideMode;
}

void ViewProvider::setDefaultMode(int val)
Expand Down Expand Up @@ -533,7 +532,7 @@ bool ViewProvider::mouseButtonPressed(int button, bool pressed,
(void)cursorPos;
(void)viewer;
return false;
}
}

bool ViewProvider::onDelete(const vector< string >& subNames) {
bool del = true;
Expand All @@ -547,19 +546,21 @@ bool ViewProvider::onDelete(const vector< string >& subNames) {
bool ViewProvider::canDragObject(App::DocumentObject* obj) const {

auto vector = getExtensionsDerivedFromType<Gui::ViewProviderExtension>();
for(Gui::ViewProviderExtension* ext : vector)
for(Gui::ViewProviderExtension* ext : vector) {
if(ext->extensionCanDragObject(obj))
return true;
}

return false;
}

bool ViewProvider::canDragObjects() const {

auto vector = getExtensionsDerivedFromType<Gui::ViewProviderExtension>();
for(Gui::ViewProviderExtension* ext : vector)
for(Gui::ViewProviderExtension* ext : vector) {
if(ext->extensionCanDragObjects())
return true;
}

return false;
}
Expand All @@ -574,7 +575,7 @@ void ViewProvider::dragObject(App::DocumentObject* obj) {
}
}

throw Base::Exception("ViewProvider::dragObject: no extension for draging given object available.");
throw Base::Exception("ViewProvider::dragObject: no extension for dragging given object available.");
}


Expand Down Expand Up @@ -615,7 +616,7 @@ void ViewProvider::dropObject(App::DocumentObject* obj) {
}
}

throw Base::Exception("ViewProvider::dropObject: no extension for droping given object available.");
throw Base::Exception("ViewProvider::dropObject: no extension for dropping given object available.");
}

void ViewProvider::Restore(Base::XMLReader& reader) {
Expand Down
14 changes: 8 additions & 6 deletions src/Gui/ViewProviderGroupExtension.cpp
Expand Up @@ -46,7 +46,6 @@ EXTENSION_PROPERTY_SOURCE(Gui::ViewProviderGroupExtension, Gui::ViewProviderExte
ViewProviderGroupExtension::ViewProviderGroupExtension() : visible(false)
{
initExtension(ViewProviderGroupExtension::getExtensionClassTypeId());

}

ViewProviderGroupExtension::~ViewProviderGroupExtension()
Expand Down Expand Up @@ -77,7 +76,9 @@ bool ViewProviderGroupExtension::extensionCanDropObjects() const {

bool ViewProviderGroupExtension::extensionCanDropObject(App::DocumentObject* obj) const {

Base::Console().Message("Check ViewProviderGroupExtension");
#ifdef FC_DEBUG
Base::Console().Log("Check ViewProviderGroupExtension");
#endif

auto* group = getExtendedViewProvider()->getObject()->getExtensionByType<App::GroupExtension>();

Expand All @@ -86,12 +87,13 @@ bool ViewProviderGroupExtension::extensionCanDropObject(App::DocumentObject* obj
return false;

//group into group?
if (obj->hasExtension(App::GroupExtension::getExtensionClassTypeId()))
if (group->isChildOf(obj->getExtensionByType<App::GroupExtension>()))
return false;
if (obj->hasExtension(App::GroupExtension::getExtensionClassTypeId())) {
if (group->isChildOf(obj->getExtensionByType<App::GroupExtension>()))
return false;
}

//We need to find the correct App extension to ask if this is a supported type, there should only be one
if(group->allowObject(obj))
if (group->allowObject(obj))
return true;

return false;
Expand Down

0 comments on commit 1a20ead

Please sign in to comment.