Skip to content

Commit

Permalink
fix OSX build failure due to outdated Coin3d version
Browse files Browse the repository at this point in the history
  • Loading branch information
@wwmayer
wwmayer committed Feb 10, 2017
1 parent 79d7f3e commit 40abcf5
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/Mod/PartDesign/Gui/CommandBody.cpp
View file
Expand Up @@ -216,6 +216,9 @@ void CmdPartDesignBody::activated(int iMsg)
actPart->getNameInDocument(), bodyName.c_str());
}

// The method 'SoCamera::viewBoundingBox' is still declared as protected in the Coin3d version
// for OSX. But since version 4.0 it should be public.
#if !defined(Q_OS_MAC)
// if no part feature was there then auto-adjust the camera
if (viewAll) {
Gui::Document* doc = Gui::Application::Instance->getDocument(getDocument());
Expand All @@ -231,6 +234,7 @@ void CmdPartDesignBody::activated(int iMsg)
camera->viewBoundingBox(bbox, aspectratio, 1.0f);
}
}
#endif

updateActive();
}
Expand Down

8 comments on commit 40abcf5

@bblacey
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wwmayer - do you know where I can download the source for coin3D 4? My prior searches have not turned up anything useful. If you can, or someone else, can provide a download URL, I will upgrade our coin3d formula to build with 4.x vs. 3.1.3

@sgrogan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peterl94 used this for win https://github.com/peterl94/clbundler-freecad/blob/master/freecad/win/coin.py
In the same repo he used 3.1.3 for mac

@bblacey
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgrogan - I don't see a 4.0.0a in https://bitbucket.org/Coin3D/coin/downloads or under tags here https://bitbucket.org/Coin3D/coin/src/035e53e53730c5cc96bfdb5ea9131ce57bffb2d3/?at=tip

Do you have an actual download url for either Windows or Linux? Perhaps @peterl94's formula downloading tip and simply calling it 4.0.0.a?

@sgrogan
Copy link
Contributor

@sgrogan sgrogan commented on 40abcf5 Feb 10, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bblacey , I don't know the significance of the "hg" (HEAD?) type. The download script is here I think : https://github.com/peterl94/CLbundler/blob/master/clbundler/downloaders.py

@bblacey
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hg is a DCVS system known as Mercurial akin to git. This means that @peterl94 is downloading the source directly from the hg repo... Thanks for all the pointers.

@peterlama
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coin 4 was never released, that is why you don't find packages of it anywhere. I seem to remember some discussion somewhere about skipping 4 and releasing as version 5 after the cmake stuff was finished, but I can't find it now.

@Karsten-Merkle
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yippie-Ya-Yeah found a hint for release 4.0.0:
https://bitbucket.org/Coin3D/coin/src/10d8002bcf0df2ac8327b40435215b1a112fef8e/docs/releases.dox?at=default&fileviewer=file-view-default

@bblacey
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, we have been using Coin 4.0.0a SHA 035e53e on macOS since 15-Feb.

It is the "cmake" version but requires a slight work-around to generate the coin-config file needed by pivy until such time the coin team supports it.

Please sign in to comment.