PartDesign: [skip ci] fixes #4494: Error "Result is empty" for Pads a…

…nd Pockets with non zero Offset
FreeCAD · Nov 16, 2020 · 42ccdb8 · 42ccdb8
1 parent bff3117
commit 42ccdb8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/Mod/PartDesign/App/FeaturePad.cpp b/src/Mod/PartDesign/App/FeaturePad.cpp
@@ -273,7 +273,8 @@ App::DocumentObjectExecReturn *Pad::execute(void)
                     return new App::DocumentObjectExecReturn("Pad: Up to face: Could not extrude the sketch!");
                 prism = PrismMaker.Shape();
 #else
-                generatePrism(prism, method, base, sketchshape, supportface, upToFace, dir, 2, 1);
+                Standard_Integer fuse = fabs(Offset.getValue()) > Precision::Confusion() ? 1 : 2;
+                generatePrism(prism, method, base, sketchshape, supportface, upToFace, dir, fuse, Standard_True);
 #endif
                 base.Nullify();
             } else {
@@ -298,7 +299,8 @@ App::DocumentObjectExecReturn *Pad::execute(void)
                     return new App::DocumentObjectExecReturn("Pad: Up to face: Could not extrude the sketch!");
                 prism = PrismMaker.Shape();
 #else
-                generatePrism(prism, method, base, sketchshape, supportface, upToFace, dir, 2, 1);
+                Standard_Integer fuse = fabs(Offset.getValue()) > Precision::Confusion() ? 1 : 2;
+                generatePrism(prism, method, base, sketchshape, supportface, upToFace, dir, fuse, Standard_True);
 #endif
             }
         } else {

diff --git a/src/Mod/PartDesign/App/FeaturePocket.cpp b/src/Mod/PartDesign/App/FeaturePocket.cpp
@@ -188,7 +188,7 @@ App::DocumentObjectExecReturn *Pocket::execute(void)
             TopoDS_Shape prism = PrismMaker.Shape();
 #else
             TopoDS_Shape prism;
-            generatePrism(prism, method, base, profileshape, supportface, upToFace, dir, 0, 1);
+            generatePrism(prism, method, base, profileshape, supportface, upToFace, dir, 0, Standard_True);
 #endif
 
             // And the really expensive way to get the SubShape...