App: Removed VariableExpression::setName(), and replace call by setPa…

…th(); it's use caused a crash (#2352).
FreeCAD · Dec 9, 2015 · 4b5ae54 · 4b5ae54
1 parent c67b2be
commit 4b5ae54
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/src/App/Expression.h b/src/App/Expression.h
@@ -349,8 +349,6 @@ class AppExport VariableExpression : public UnitExpression {
 
     void setPath(const ObjectIdentifier & path);
 
-    void setName(const std::string & name) { assert(0); }
-
     void renameDocumentObject(const std::string & oldName, const std::string & newName);
 
     void renameDocument(const std::string &oldName, const std::string &newName);

diff --git a/src/Mod/Spreadsheet/App/PropertySheet.cpp b/src/Mod/Spreadsheet/App/PropertySheet.cpp
@@ -579,7 +579,7 @@ class RewriteExpressionVisitor : public ExpressionVisitor {
                 if (thisRow >= mRow || thisCol >= mCol) {
                     thisRow += mRowCount;
                     thisCol += mColCount;
-                    varExpr->setName(columnName(thisCol) + rowName(thisRow));
+                    varExpr->setPath(ObjectIdentifier(varExpr->getOwner(), columnName(thisCol) + rowName(thisRow)));
                     mChanged = true;
                 }
             }