Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Add /Library/Frameworks/ to known system libraries
Fixes issue where the 3Dconnexion drivers weren't found in relocateable
mac application bundles.
  • Loading branch information
ianrrees committed Jan 23, 2016
1 parent 45d343e commit ada6ad5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Tools/MakeMacBundleRelocatable.py
Expand Up @@ -4,7 +4,7 @@
import pprint
import re

SYS_PATHS = ["/System/", "/usr/lib/"]
SYS_PATHS = ["/System/", "/usr/lib/", "/Library/Frameworks/"]

class LibraryNotFound(Exception):
pass
Expand Down

2 comments on commit ada6ad5

@bblacey
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ian, Peterl94 had recommended restricting the additional search path to /Library/Frameworks/3DconnexionClient.framework which is a bit less aggressive... In my tests, I used the more limited 3Dconnexion framework path successfully. Thoughts?

@ianrrees
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the safest default assumption is that libraries in /Libraries/Frameworks shouldn't be packaged in with FreeCAD, but adding a warning message couldn't hurt:

ianrrees@ada6ad5#commitcomment-15631895

Will be submitting a pull request.

Please sign in to comment.