Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
adding Part_BoxSelection.svg icon
  • Loading branch information
easyw authored and WandererFan committed May 21, 2019
1 parent 95cac52 commit eafe889
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/Mod/Part/Gui/Resources/Part.qrc
Expand Up @@ -22,6 +22,7 @@
<file>icons/Part_Fuse.svg</file>
<file>icons/Part_Import.svg</file>
<file>icons/Part_Export.svg</file>
<file>icons/Part_BoxSelection.svg</file>
<file>icons/Part_Loft.svg</file>
<file>icons/Part_Mirror.svg</file>
<file>icons/Part_MirrorPNG.png</file>
Expand Down

6 comments on commit eafe889

@easyw
Copy link
Contributor Author

@easyw easyw commented on eafe889 May 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WandererFan
thank you for merging it... Could you please check if the Part_BoxSelection icon is present on Part BoxSelection Menu?
I've checked with this release 'FreeCAD_0.19.16817_x64_LP_12.1.2_PY3QT5-WinVS2015' which should include that, but I cannot find the icon. Is there something I missed to add to the code to allowing the icon to be displayed?
Thanks

@WandererFan
Copy link
Contributor

@WandererFan WandererFan commented on eafe889 May 22, 2019 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@easyw
Copy link
Contributor Author

@easyw easyw commented on eafe889 May 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to make an additional change in ...Part/Gui/Command.cpp:

thanks a lot, I will make a small PR then...

Did you want this command to appear in the toolbars? If so, we need to make changes in Workbench.cpp also.

The menu is just fine form me, because if I have an icon there, I can add my own Toolbar buttons pointing this button.
Thanks again
Maurice

@easyw
Copy link
Contributor Author

@easyw easyw commented on eafe889 May 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WandererFan
is that correct to use:
* sPixmap = "Part_BoxSelection.svg";
or instead:
sPixmap = "Part_BoxSelection";
as written for the other commands?
Thanks again for support.

@WandererFan
Copy link
Contributor

@WandererFan WandererFan commented on eafe889 May 23, 2019 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@easyw
Copy link
Contributor Author

@easyw easyw commented on eafe889 May 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks @WandererFan
I also made my building chain to test it...
PR 2197 done 😄
Thanks again

Please sign in to comment.