Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
adding Part_BoxSelection.svg icon
- Loading branch information
1 parent
95cac52
commit eafe889
Showing
1 changed file
with
1 addition
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eafe889
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WandererFan
thank you for merging it... Could you please check if the Part_BoxSelection icon is present on Part BoxSelection Menu?
I've checked with this release 'FreeCAD_0.19.16817_x64_LP_12.1.2_PY3QT5-WinVS2015' which should include that, but I cannot find the icon. Is there something I missed to add to the code to allowing the icon to be displayed?
Thanks
eafe889
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eafe889
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot, I will make a small PR then...
The menu is just fine form me, because if I have an icon there, I can add my own Toolbar buttons pointing this button.
Thanks again
Maurice
eafe889
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WandererFan
is that correct to use:
* sPixmap = "Part_BoxSelection.svg";
or instead:
sPixmap = "Part_BoxSelection";
as written for the other commands?
Thanks again for support.
eafe889
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eafe889
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks @WandererFan
I also made my building chain to test it...
PR 2197 done 😄
Thanks again