[Gui] Issue #3923 - Add arbitrary Tree View item ordering #4626

pavltom · 2021-03-16T20:34:02Z

This pull request gives the user a possibility to reorder the document tree view items.

For more implementation details please see my contribution to the dedicated forum topic:

Ticket #3923 - change order in tree view

adrianinsaval · 2021-03-17T06:03:39Z

Compiles and runs but there are issues with the implementation I have commented here: https://forum.freecadweb.org/viewtopic.php?f=3&t=35316&p=488236#p488236

ickby · 2021-03-17T09:38:35Z

The viewprovider tree rank is not readable, writable or observable from python. As it is a defining attribute for the viewprovider this needs to change.
Maybe implementing it as hidden property makes it easier and more consistent within freecad?

thebravoman · 2021-04-17T13:08:35Z

For what it is worth, I've been in the CAD/Engineering world for decade, I installed FreeCAD and the first thing I did is add two parts and tried to reorder the parts in the tree viewer.

Looking forward to this PR

ickby · 2021-04-24T09:03:43Z

Thanks for the changes, looks fine for me! Two minor things that could be improved:

Use the new functionality for App::Group and App::Part as those are most likely the two candidate objects for the new API
Write a test for the functionality to check if reordering works and is prevented correctly if it should not work

pavltom · 2021-06-03T18:13:31Z

Hi, I have used the possibility to disable children movement for basic document objects like Body (and all OriginGroupExtensions), Origin document object, Part Boolean object, Loft, Sweep (Pipe) and Thickness features both in Part and PartDesign. For the App::DocumentObjectGroup object, movement remains allowed, I do not see any reason why it should be restricted. Nevertheless, I am pretty much sure there are lots of other places, where moving children is not desirable, however I would let apply this to their respective maintainers.
As for the tests, I have added a TreeView.py test, which tests the functionality both for items allowing and restricting child item movement. I believe this test is sufficient, but for sure it can be expanded to other item types or different scenarios.

berndhahnebach · 2021-09-24T11:50:18Z

Following a link to the branch on the CI-repository:

https://gitlab.com/freecad/FreeCAD-CI/-/commits/PR_4626

The CI-status is available on the latest commit of the branch.
If there is no status available the PR should be rebased on latest master.
Check pipeline branches to see if your PR has been run by the CI.

https://gitlab.com/freecad/FreeCAD-CI/-/pipelines?scope=branches

chennes

Nice addition! Thanks especially for adding the test cases. I left a couple tiny comments on the code (which overall looks really solid), and some feedback on the overall behavior.

When I move an expanded group up the list, it stays open, but when I move it down, it collapses. This is also true if I move another object "across" the open group: it collapses if the motion is upward, but stays open if the motion is down. I personally prefer the stay-open behavior, but at the least I think it should be the same in all cases.

I also think that the multiple-selection behavior is counter-intuitive. When I have multiple objects selected and ask them to move, I felt like I was asking ALL of them to move, and then only one of them did.

Otherwise it looks to me like this is pretty much ready to merge. Thanks!

chennes · 2021-10-01T17:06:49Z

src/Gui/CommandView.cpp

+  : Command("Std_GroupMoveUp")
+{
+    sGroup       = QT_TR_NOOP("TreeView");
+    sMenuText    = QT_TR_NOOP("Move Up in Group");


Suggested change

sMenuText = QT_TR_NOOP("Move Up in Group");

sMenuText = QT_TR_NOOP("Move up in group");

chennes · 2021-10-01T17:08:57Z

src/Gui/CommandView.cpp

+  : Command("Std_GroupMoveDown")
+{
+    sGroup       = QT_TR_NOOP("TreeView");
+    sMenuText    = QT_TR_NOOP("Move Down in Group");


Suggested change

sMenuText = QT_TR_NOOP("Move Down in Group");

sMenuText = QT_TR_NOOP("Move down in group");

freecadci · 2021-10-25T13:20:38Z

for feature branch PR_4626. Pipeline #394851880 was triggered at 214972f. All CI branch pipelines.

AjinkyaDahale · 2021-10-25T17:43:15Z

For what it is worth, I've been in the CAD/Engineering world for decade, I installed FreeCAD and the first thing I did is add two parts and tried to reorder the parts in the tree viewer.

Looking forward to this PR

I wouldn't me surprised if 90% of first contributions come from using other CAD software and finding a missing feature. I know most of my contribs are such.

pavltom · 2021-10-26T17:18:44Z

I have reworked the functionality a bit, so now moving multiple siblings in a single step is possible. Also Undo/Redo shall be now fully supported. Finally, I have added one more Python test to cover the new item order survives closing the document once it was saved. However keeping the "historical" commits would be quite misleading, thus I decided to rebase the branch. Should there be any issues, please let me know.

freecadci · 2021-10-26T20:28:56Z

for feature branch PR_4626. Pipeline 396028972 was triggered at 345dcd5. All CI branches and pipelines.

HakanSeven12 · 2021-10-28T13:17:55Z

That is nice 👍 can you expose this functions to Python too?

pavltom · 2021-10-28T15:35:04Z

@HakanSeven12 You can use Python to select the objects to be reordered and then run command "Std_GroupMoveUp"/"Std_GroupMoveDown". For working examples please see the Python tests in "src/Mod/Test/TreeView.py" which are a part of this pull request.

chennes · 2021-10-31T00:53:43Z

Thanks for the changes -- I will re-review shortly.

chennes · 2021-11-19T18:04:50Z

@pavltom It appears this is causing some problems, can you please have a look at https://forum.freecadweb.org/viewtopic.php?f=3&t=63744 ? Thanks.

…ing" This reverts commit c62239d, reversing changes made to bef1df4. See forums discussion: https://forum.freecadweb.org/viewtopic.php?p=549120

luzpaz added Translation Translation and localization related and removed Translation Translation and localization related labels Mar 16, 2021

berndhahnebach added the Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label Aug 3, 2021

chennes self-requested a review September 24, 2021 16:00

pavltom force-pushed the GUI_TreeView_Item_Ordering branch from 88ecff4 to 2a707d2 Compare September 30, 2021 22:00

chennes requested changes Oct 1, 2021

View reviewed changes

[Gui] Issue FreeCAD#3923 - Arbitrary Tree item ordering + tests

345dcd5

pavltom force-pushed the GUI_TreeView_Item_Ordering branch from 214972f to 345dcd5 Compare October 26, 2021 17:09

FreeCAD deleted a comment from freecadci Oct 26, 2021

chennes self-assigned this Oct 31, 2021

chennes self-requested a review October 31, 2021 00:53

bambukouk mentioned this pull request Nov 8, 2021

question (not an issue) - order of things in tree view realthunder/FreeCAD#203

Closed

chennes merged commit c62239d into FreeCAD:master Nov 11, 2021

chennes mentioned this pull request Nov 22, 2021

Gui: Revert PR #4626 (c62239d0b) Tree View Reorder #5192

Closed

luzpaz mentioned this pull request Feb 9, 2022

TreeView widget, reorder the object in tree view by user #5907

Closed

pavltom deleted the GUI_TreeView_Item_Ordering branch October 26, 2023 13:03

PaddleStroke mentioned this pull request Feb 8, 2024

Tree: Enable sorting when drag&drop. #12293

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Gui] Issue #3923 - Add arbitrary Tree View item ordering #4626

[Gui] Issue #3923 - Add arbitrary Tree View item ordering #4626

pavltom commented Mar 16, 2021

adrianinsaval commented Mar 17, 2021

ickby commented Mar 17, 2021 •

edited

thebravoman commented Apr 17, 2021

ickby commented Apr 24, 2021

pavltom commented Jun 3, 2021

berndhahnebach commented Sep 24, 2021 •

edited

chennes left a comment

chennes Oct 1, 2021

chennes Oct 1, 2021

freecadci commented Oct 25, 2021

AjinkyaDahale commented Oct 25, 2021

pavltom commented Oct 26, 2021

freecadci commented Oct 26, 2021

HakanSeven12 commented Oct 28, 2021

pavltom commented Oct 28, 2021

chennes commented Oct 31, 2021

chennes commented Nov 19, 2021

	sMenuText = QT_TR_NOOP("Move Up in Group");
	sMenuText = QT_TR_NOOP("Move up in group");

	sMenuText = QT_TR_NOOP("Move Down in Group");
	sMenuText = QT_TR_NOOP("Move down in group");

[Gui] Issue #3923 - Add arbitrary Tree View item ordering #4626

[Gui] Issue #3923 - Add arbitrary Tree View item ordering #4626

Conversation

pavltom commented Mar 16, 2021

adrianinsaval commented Mar 17, 2021

ickby commented Mar 17, 2021 • edited

thebravoman commented Apr 17, 2021

ickby commented Apr 24, 2021

pavltom commented Jun 3, 2021

berndhahnebach commented Sep 24, 2021 • edited

chennes left a comment

Choose a reason for hiding this comment

chennes Oct 1, 2021

Choose a reason for hiding this comment

chennes Oct 1, 2021

Choose a reason for hiding this comment

freecadci commented Oct 25, 2021

AjinkyaDahale commented Oct 25, 2021

pavltom commented Oct 26, 2021

freecadci commented Oct 26, 2021

HakanSeven12 commented Oct 28, 2021

pavltom commented Oct 28, 2021

chennes commented Oct 31, 2021

chennes commented Nov 19, 2021

ickby commented Mar 17, 2021 •

edited

berndhahnebach commented Sep 24, 2021 •

edited