Path fixes #821
Closed
Path fixes #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 16, 2017 12:49
Independent of scale, use only mm/min or in/min because it is compatible with GCODE feed rate units. (My use case is definition os feed-rates in PathLoadTool.py).
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request addresses 3 issues:
0003088: ToolTable crashes after changing the units in the settings
commit fcb5667
I chose to use the default unit conversion of the current schema. It may be a pain to see a "59.055 thou" tool but this is a common problem with UnitsSchema::schemaTranslate that do not allow customization for each use.
0003089: Spindle speed is limited to only 100 RPM
commit 8ed7e13
The default maximum of 99.99 is too small. I Just set the maximum to 100,000 RPM (Is that enough?)
0003090: There is no default Units schema translation for Unit::Velocity
commit ecc762c
IMHO this is only used for feed-rates in the Path module tool control. It is very important to me to use the same units that I use in G-CODE (mm/min).
It would be better if any property could override the default conversion of the current unit schema. Then one could use imperial units on drawings and still see mm/min on the feed-rates.