Do Not Merge, #945

berndhahnebach · 2017-08-25T04:45:28Z

We are in bug fixing for GSoC project FEM elmer and would like to run the Travis tests ...

cheers bernd

berndhahnebach · 2017-08-30T19:37:03Z

Does someone know why it does not load the modules on linux?

test_pyimport_all_FEM_modules (TestFem.FemTest) ... /usr/local/Mod/Fem/ 
/usr/local/Mod/Fem/PyObjects/ 
Try importing FemConstraint ... 
ERROR

it works on my local machine ?!

luzpaz · 2017-08-31T09:33:31Z

src/Mod/Fem/Gui/DlgSettingsFemCcx.ui

+               <string>sdfsdfsdfds</string>
+              </property>
+              <property name="text">
+               <string>Depreciated</string>


Shouldn't this be Deprecated ?

drhooves · 2017-08-31T09:46:43Z

======================================================================
ERROR: test_pyimport_all_FEM_modules (TestFem.FemTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/Mod/Fem/TestFem.py", line 381, in test_pyimport_all_FEM_modules
    __import__('{0}'.format(mod))  # to get an error message what was going wrong
  File "/usr/local/Mod/Fem/FemConstraint.py", line 29, in <module>
    from pivy import coin
ImportError: No module named 'pivy'

----------------------------------------------------------------------

Could it be that travis doesn't have pivy installed? It's only required by the GUI, not for the app tests. If so we have to guard the import with if App.GuiUp.

======================================================================
ERROR: test_static_freq_analysis (TestFem.FemCcxAnalysisTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/Mod/Fem/TestFem.py", line 572, in test_static_freq_analysis
    solver_ccx2_object = ObjectsFem.makeSolverCalculix('CalculiX')
  File "/usr/local/Mod/Fem/ObjectsFem.py", line 347, in makeSolverCalculix
    import FemCalculix.SolverObject
  File "/usr/local/Mod/Fem/FemCalculix/SolverObject.py", line 177
    print pattern
                ^
SyntaxError: Missing parentheses in call to 'print'

Looks like a python3 error?!

berndhahnebach · 2017-08-31T10:19:49Z

Could it be that travis doesn't have pivy installed? It's only required by the GUI, not for the app tests. If so we have to guard the import with if App.GuiUp.

ATM in Fem Gui modules are seperated from App modules, thus I did not need to guide it by a GuiUp test.

Python3 needs print('hello')

berndhahnebach · 2017-08-31T10:21:03Z

fixed al above ...

berndhahnebach · 2017-08-31T10:53:58Z

damn I just guarded the imports, but we would need to guard the whole ViewProviderClass ?! To not have such problems was one of the reason for splitting all Python modules in GUI and nonGUI part in FEM.

I would guard the whole viewprovider for now ?!

bernd

berndhahnebach · 2017-08-31T11:29:01Z

57c1985

I do not really like it but I'm curious if it passes the tests thus I just implemented it.

bernd

drhooves · 2017-09-01T07:49:03Z

No we don't need to guard the whole view provider proxy. The arch workbench does it the same way, can't tell which way is better but splitting generates alot of modules with just 3-4 lines of code.

berndhahnebach · 2017-09-01T09:11:45Z

No we don't need to guard the whole view provider proxy. The arch workbench does it the same way, can't tell which way is better but splitting generates alot of modules with just 3-4 lines of code.

IT was my misstake. The import FreeCAD was missing. It is all in here: See 63d38cb

ATM py3 seams to fail here: https://github.com/berndhahnebach/FreeCAD_bhb/blob/d01289fa75383f1794d388a6563f4792c2e1f057/src/Mod/Fem/ObjectsFem.py#L348

do not know why?

drhooves · 2017-09-02T17:43:53Z

It's because in python3 print is a function, is it not? We could put from __future__ import print_function at the beginning of the file. That would make python2 support the new syntax too.

berndhahnebach · 2017-09-05T13:08:06Z

sure, if there are prints without brackets py3 fails. But AFAIK I fixed all prints. Is there still an old print without brackets somewhere in your code?

bernd

berndhahnebach · 2017-09-10T22:40:49Z

passes py2 and py3 on linux :-) https://travis-ci.org/FreeCAD/FreeCAD/builds/273963271?utm_source=github_status&utm_medium=notification

berndhahnebach@78470fd

berndhahnebach · 2017-09-16T06:27:50Z

:-)

sasobadovinac · 2017-09-16T12:40:13Z

👍 is it ready to merge?

luzpaz · 2017-10-06T11:49:12Z

src/Mod/Fem/ObjectsFem.py

@@ -303,7 +303,7 @@ def makeMeshNetgen(doc, name="FEMMeshNetgen"):


 def makeMeshRegion(doc, base_mesh, element_length=0.0, name="FEMMeshRegion"):
-    '''makeMeshRegion(document, base_mesh, [element_length] [name]): creates a  FEM mesh region object to define properties for a regon of a FEM mesh'''
+    '''makeMeshRegion(document, base_mesh, [element_length], [name]): creates a  FEM mesh region object to define properties for a regon of a FEM mesh'''


@berndhahnebach regon->region

… change this

…th objects fem modul

…t flux icon

some aren't really typos but are more cosmetic.

…called twice

berndhahnebach · 2017-11-07T16:53:07Z

continues here: #1076

due to commit ce68094 a rebase makes no sence anymore ...

luzpaz reviewed Aug 31, 2017

View reviewed changes

berndhahnebach force-pushed the femnewsolver branch from 28a09e2 to fab58e9 Compare August 31, 2017 10:27

berndhahnebach force-pushed the femnewsolver branch 3 times, most recently from c1e3647 to 9b15382 Compare August 31, 2017 21:23

berndhahnebach force-pushed the femnewsolver branch 4 times, most recently from c95c0e5 to 78470fd Compare September 10, 2017 22:00

berndhahnebach force-pushed the femnewsolver branch from 531d9f9 to 74b3272 Compare September 14, 2017 04:45

berndhahnebach force-pushed the femnewsolver branch 2 times, most recently from 587dcb7 to f55628b Compare September 20, 2017 11:42

berndhahnebach force-pushed the femnewsolver branch from e5192ec to eeae296 Compare October 2, 2017 16:10

luzpaz reviewed Oct 6, 2017

View reviewed changes

berndhahnebach force-pushed the femnewsolver branch 2 times, most recently from c47ec30 to a207bb8 Compare October 7, 2017 19:20

berndhahnebach mentioned this pull request Oct 7, 2017

typos berndhahnebach/FreeCAD_bhb#17

Closed

berndhahnebach and others added 22 commits October 22, 2017 23:24

FEM: use z88 command from FreeCAD master, because there is no need to…

8ce81ec

… change this

FEM: code formating, trailing white spaces

eba66b2

FEM: equations elmer, use same modul names system as for solver modules

5009809

FEM: objects fem module, fix comments

ca1e21e

FEM: commands, get rid of duplicate code and fix boudary obj creation

6666d33

FEM: command solver run, delete unused import

14cf1d4

FEM: code formating, add new line

6651650

FEM: elmer equations, add posibility to easy create them by python wi…

07d369f

…th objects fem modul

FEM: code formating

855c534

FEM: set back some rebase changes

ad5b78e

FEM: set back changes lost on rebase

6239a2d

FEM: typo

03246b3

FEM: remove constraint heatsource icon since it is only a copy of hea…

8dc6699

…t flux icon

FEM: code formating, trailing whitespaces and flake8

65b2da6

FEM: elmer writer, fix density for self weight on edges

5347386

FEM: solver run command, fix FreeCAD freeze on new frame work

f7f658e

FEM: elmer, implement Potential-boundary and flux-solver

0d65ae0

FEM: elmer, implement Potential-boundary and flux-solver

14d7e02

FEM: elmer, update last FemMisc to FemUtils in writer

a9ed701

FEM: elmer, repair restore of values considering locales

88b8a8c

Typos

7d67f64

some aren't really typos but are more cosmetic.

FEM: code formating, flake8

e6f97d3

berndhahnebach force-pushed the femnewsolver branch from dccb89b to e6f97d3 Compare October 22, 2017 21:25

drhooves and others added 3 commits November 6, 2017 23:01

FEM: elmer sifio, write case file entries in same order if module is …

881beb1

…called twice

FEM: unit tests, elmer sifio and geo writing

495fe53

FEM: unit test and elmer, add a testmode to solver framework

19f2bbb

berndhahnebach mentioned this pull request Nov 7, 2017

Do Not Merge, Not yet :-) GSoC FEM Elmer project #1076

Closed

berndhahnebach closed this Nov 7, 2017

berndhahnebach deleted the femnewsolver branch November 14, 2017 06:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do Not Merge, #945

Do Not Merge, #945

berndhahnebach commented Aug 25, 2017

berndhahnebach commented Aug 30, 2017

luzpaz Aug 31, 2017

drhooves commented Aug 31, 2017

berndhahnebach commented Aug 31, 2017

berndhahnebach commented Aug 31, 2017

berndhahnebach commented Aug 31, 2017 •

edited

berndhahnebach commented Aug 31, 2017

drhooves commented Sep 1, 2017

berndhahnebach commented Sep 1, 2017

drhooves commented Sep 2, 2017 •

edited

berndhahnebach commented Sep 5, 2017

berndhahnebach commented Sep 10, 2017 •

edited

berndhahnebach commented Sep 16, 2017

sasobadovinac commented Sep 16, 2017

luzpaz Oct 6, 2017

berndhahnebach Oct 7, 2017

berndhahnebach commented Nov 7, 2017

Do Not Merge, #945

Do Not Merge, #945

Conversation

berndhahnebach commented Aug 25, 2017

berndhahnebach commented Aug 30, 2017

luzpaz Aug 31, 2017

Choose a reason for hiding this comment

drhooves commented Aug 31, 2017

berndhahnebach commented Aug 31, 2017

berndhahnebach commented Aug 31, 2017

berndhahnebach commented Aug 31, 2017 • edited

berndhahnebach commented Aug 31, 2017

drhooves commented Sep 1, 2017

berndhahnebach commented Sep 1, 2017

drhooves commented Sep 2, 2017 • edited

berndhahnebach commented Sep 5, 2017

berndhahnebach commented Sep 10, 2017 • edited

berndhahnebach commented Sep 16, 2017

sasobadovinac commented Sep 16, 2017

luzpaz Oct 6, 2017

Choose a reason for hiding this comment

berndhahnebach Oct 7, 2017

Choose a reason for hiding this comment

berndhahnebach commented Nov 7, 2017

berndhahnebach commented Aug 31, 2017 •

edited

drhooves commented Sep 2, 2017 •

edited

berndhahnebach commented Sep 10, 2017 •

edited