GarrettS (Garrett Smith)

Name
Garrett Smith
Email
Location
San Francisco
Member Since
Feb 19, 2009 (10 months)

Following 4 githubbers and watching 7 repositories view all →

Public Repositories (2)

  • ape-javascript-library

    Minimal JavaScript library for writing and developing widgets.

    legend

    Last updated Thu Dec 17 10:03:45 -0800 2009

  • yui2

    YUI 2.x Source Tree

    legend

    Forked from yui/yui2 Fri Oct 02 23:26:10 -0700 2009

    Last updated Tue Oct 06 23:14:10 -0700 2009

Public Activity feed

GarrettS commented on kangax/jstests Thu Dec 17 23:48:35 -0800 2009
Comment in 2e4898f:

Why == and not === ?

GarrettS started watching kangax/jstests Thu Dec 17 23:47:22 -0800 2009
jstests was created Tue Dec 01 09:29:59 -0800 2009
GarrettS started watching kangax/jstests Thu Dec 17 23:42:44 -0800 2009
jstests was created Tue Dec 01 09:29:59 -0800 2009
GarrettS pushed to master at GarrettS/ape-javascript-library Thu Dec 17 10:03:45 -0800 2009
HEAD is d2a0dc2dc4405ee5e852e4674635698f31dcd214
  • GarrettS committed d2a0dc2d:
    Have to ignore some added tests where Calendar.IS_NATIVE is true (Opera has native support).
GarrettS pushed to master at GarrettS/ape-javascript-library Thu Dec 17 09:20:52 -0800 2009
HEAD is 2ba1b93f3fb55499569b00f132639fab5fc11e6b
GarrettS commented on GarrettS/ape-javascript-library Thu Dec 17 09:13:07 -0800 2009
Comment in c027b78:

Correction:
3) An element ID should not have a special char like ".".

Pseudo-code example in previous comment had a syntax error. A new file keys.js has a new APE.dom.key object. This adds to the overall size and will be less efficient than a literal number. In this case added code clarity seemed to be a fair trade for the costs of size and efficiency.

GarrettS pushed to master at GarrettS/ape-javascript-library Thu Dec 17 09:09:45 -0800 2009
HEAD is a4a5a861029eb7fb4d42da02faf527f6d3f45cde
  • GarrettS committed a4a5a861:
    keys.js - Missed a few files in "/build" in last checkin.
GarrettS pushed to master at GarrettS/ape-javascript-library Wed Dec 16 23:30:36 -0800 2009
HEAD is fb58ec6ca3cfe5650f4f8bb2731cc4a59db818cc
  • GarrettS committed fb58ec6c:
    Calendar-test.html IE window.event was null in onfocusout event, causing a plethora of errors!
GarrettS pushed to master at GarrettS/ape-javascript-library Wed Dec 16 17:14:04 -0800 2009
HEAD is 71aa11df3d1b7a20aa95e357983b2753073b5032
GarrettS commented on GarrettS/ape-javascript-library Tue Dec 15 11:59:51 -0800 2009
Comment in c027b78:

1) No textContent on BB9k, so it's gonna fail there, but OK everywhere else. It seemed not so urgent to write a wrapper for that.
2) The keyCode matching 137, 139, etc is a bug - fixing...
3) An element ID should have a special char like ".". calendarID matches the INPUT's ID.
4) Replace magic numbers with psuedo-constants. That could help code clarity. I have used key stuff in other places, too, so it might make sense to put it all in one place. Maybe a small, simple DOM.key file for ESC, ENTER, UP, DOWN, LEFT, RIGHT, TAB, maybe even, an isArrowKey(keyCode), so the program coud use:

var dom = APE.dom,
     key = dom.key;

function handleKeyPress(ev) {
  ev = ev || event,
  keyCode = ev.keyCode;
  if(isArrowKey(keyCode) {
    // ...
  }
}

It adds a little complexity but could make widget coe a little easier to follow.

GarrettS pushed to master at GarrettS/ape-javascript-library Tue Dec 15 11:37:46 -0800 2009
HEAD is 5464a7efd5b163a68c276b80b54f1d786e202ffd
  • GarrettS committed 5464a7ef:
    Calendar - keyboard a11y. Tested in Saf 2.0+, Seamonkey 1, FF 3.5, IE6-8, Opera 10 (Native input type="date").
GarrettS pushed to master at GarrettS/ape-javascript-library Mon Dec 14 23:14:43 -0800 2009
HEAD is 0de547a45b335bda83a0100808677c280725925d
  • GarrettS committed 0de547a4:
    Traversal - added includeEl to dom.contains(a, b, includeEl) to allow same element to pass.
GarrettS pushed to master at GarrettS/ape-javascript-library Sat Dec 12 16:43:18 -0800 2009
HEAD is ff4c13b851391c30ef34408e1468c0902e5b6541
GarrettS pushed to master at GarrettS/ape-javascript-library Sat Dec 12 01:06:10 -0800 2009
HEAD is c027b780eff02d317618f5503f7e3fd74d9168cb
  • GarrettS committed c027b780:
    Event.js - Delegated Focus and Blur events. Tested passing in:
GarrettS pushed to master at GarrettS/ape-javascript-library Thu Dec 03 23:08:38 -0800 2009
HEAD is 58005eda0b9411a4d511529186e84f5fcf799f07
GarrettS pushed to master at GarrettS/ape-javascript-library Thu Dec 03 16:11:18 -0800 2009
HEAD is 56b29901b71bf5ae2d2063b9425979fa50ec6ef0
GarrettS pushed to master at GarrettS/ape-javascript-library Sat Nov 21 23:54:28 -0800 2009
HEAD is 420dd351af6919d49eef886b183491508ca36941
GarrettS commented on GarrettS/ape-javascript-library Thu Nov 19 13:16:32 -0800 2009
Comment in cf5851e:

Agreed. The number of arguments is obscene.

I need to clean that up. Any suggestion on that?

GarrettS pushed to master at GarrettS/ape-javascript-library Thu Nov 19 13:14:10 -0800 2009
HEAD is 066b89b3f0607a1d423c1b18abbb9dd30556eaa0
  • GarrettS committed 066b89b3:
    A proxy, if not dragged was shown even in mouseup.
GarrettS pushed to master at GarrettS/ape-javascript-library Sat Nov 14 12:01:13 -0800 2009
HEAD is 390e071daf3af4c02159f6b321bfcd666db95156
  • GarrettS committed 390e071d:
    Draggable.js - attach mousemove in dragObjGrabbed, remove after dragging is complete,
GarrettS pushed to master at GarrettS/ape-javascript-library Thu Nov 12 00:03:35 -0800 2009
HEAD is cf5851e18673e81b409456640cfb64c82a16cc5f
  • GarrettS committed cf5851e1:
    testOndragOnce - to ensure that ondrag does not fire when object
GarrettS commented on GarrettS/ape-javascript-library Mon Nov 09 23:24:10 -0800 2009
Comment in f56a50e:

Those were temporary variables to determine userSelectType. I moved that to a method: initGuardUserSelection

GarrettS pushed to master at GarrettS/ape-javascript-library Mon Nov 09 23:22:58 -0800 2009
HEAD is 8a73c99835a9f4e24ae0b0294a879346f9bedb5d
  • GarrettS committed 8a73c998:
    Restructure internal event order for dragEnd, new function applyGroupAction.
GarrettS pushed to master at GarrettS/ape-javascript-library Sat Nov 07 13:33:13 -0800 2009
HEAD is f741bc288fdfeda59e6ff24d39ac4376c9e1fba2
  • GarrettS committed f741bc28:
    temp fix for glideend firing twice. TODO: Event order needs to reevaluation
GarrettS pushed to master at GarrettS/ape-javascript-library Sat Nov 07 11:22:55 -0800 2009
HEAD is 462c67f1b5d2849fcb7486c479ddbbb5110dc997
  • GarrettS committed 462c67f1:
    Clean up, set enclosingDropTarget to null on ondragstart.
GarrettS pushed to master at GarrettS/ape-javascript-library Sat Nov 07 10:46:25 -0800 2009
HEAD is 0bc519da329e75f1b86a85275f3f3445d19060b4
  • GarrettS committed 0bc519da:
    A little cleanup. Still need to resolve dragEnd event with glideEnd.
GarrettS pushed to master at GarrettS/ape-javascript-library Sat Nov 07 02:00:07 -0800 2009
HEAD is f56a50e5a32d14cdf00aba567c7e04aac2cee9a1
  • GarrettS committed f56a50e5:
    TODO: Need to fix the double onglideend - testGlideEndOnce.
GarrettS commented on GarrettS/ape-javascript-library Fri Nov 06 18:36:19 -0800 2009
Comment in 8fde5b9:

[[Construct]] fails in IE, even IE8.

new Function.prototype.

Fails.

[[Call]] works though. Desirable to have a globally accessible noop function with global scope.

GarrettS pushed to master at GarrettS/ape-javascript-library Fri Nov 06 18:33:36 -0800 2009
HEAD is ee37ae2efb3eac46f9912c75ad3093ac4584978d
  • GarrettS committed ee37ae2e:
    dynamic dispatch for drag constraint, used for dragCopy && proxyId.
GarrettS pushed to master at GarrettS/ape-javascript-library Fri Nov 06 18:26:31 -0800 2009
HEAD is b24e204392d587d234ce1f685353445666e95328
  • GarrettS committed b24e2043:
    dynamic dispatch for drag constraint, used for dragCopy && proxyId.
GarrettS pushed to master at GarrettS/ape-javascript-library Fri Nov 06 17:56:42 -0800 2009
HEAD is 024643890982630b9e11efb4850046346588d86b
  • GarrettS committed 02464389:
    dynamic dispatch for drag constraint, used for dragCopy && proxyId.
GarrettS pushed to master at GarrettS/ape-javascript-library Thu Nov 05 20:39:05 -0800 2009
HEAD is d8e09e7994ffe31a08d051c76a5f6a0a15b87b95
  • GarrettS committed d8e09e79:
    Updated viewport-f to not account for Opera < 9.25 bug.
GarrettS commented on girliemac/PREtty-Cute-Suite Thu Nov 05 12:43:49 -0800 2009
Comment in 23c5aed: 
function ContentAssistant(index,feedList, db) {
this.index = index;
this.feedList = feedList
this.feed = feedList[index];
this.db = db;
var str;
}

What is var str; doing there?

GarrettS started watching girliemac/PREtty-Cute-Suite Thu Nov 05 12:41:04 -0800 2009
PREtty-Cute-Suite's description:
Palm Pre (WebOS) application
GarrettS pushed to master at GarrettS/ape-javascript-library Thu Nov 05 11:47:34 -0800 2009
HEAD is 590e0b6026d2985c744618996b8c3c18ca2996f6
  • GarrettS committed 590e0b60:
    Updated viewport-f to not account for Opera < 9.25 bug.