Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for gcloud 0.9.54 #6270

Merged
merged 1 commit into from Apr 2, 2015
Merged

Conversation

j3ffml
Copy link
Contributor

@j3ffml j3ffml commented Apr 1, 2015

Updates gke provider and e2e driver for breaking changes in gcloud 0.9.54.

cc @zmerlynn

@j3ffml j3ffml added area/test area/provider/gcp Issues or PRs related to gcp provider labels Apr 1, 2015
@@ -91,6 +91,7 @@ function verify-prereqs() {
gcloud_prompt="-q"
fi
gcloud ${gcloud_prompt:-} components update preview || true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the update preview line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need the preview component for instance-groups and managed-instance-groups, which were not moved to alpha.

@roberthbailey roberthbailey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2015
@roberthbailey
Copy link
Contributor

LGTM. Assigning to @zmerlynn to merge once the Jenkins box is updated to the next release of gcloud.

@j3ffml
Copy link
Contributor Author

j3ffml commented Apr 1, 2015

Gcloud 0.9.54 is now live. e2e test in progress.

@zmerlynn
Copy link
Member

zmerlynn commented Apr 2, 2015

@jlowdermilk and I talked about this. The e2es are passing as well in GKE on the new gcloud as the old. I'm merging this slightly outside the merge window because it's when I'm available to do the Jenkins maintenance and watch it for a bit longer (and it's a quiet period otherwise).

zmerlynn added a commit that referenced this pull request Apr 2, 2015
@zmerlynn zmerlynn merged commit 1ff0a1e into kubernetes:master Apr 2, 2015
@j3ffml j3ffml deleted the gcloud-updates branch April 9, 2015 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/gcp Issues or PRs related to gcp provider area/test lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants