pkg/proxy: panic if run out of fd #6727

xiang90 · 2015-04-11T15:50:12Z

When proxy runs out of fd, it fills the logs with error message.
From #6716, it is better to just panic().

Manually tested

panic: Accept failed: accept tcp [::]:64676: too many open files

goroutine 10 [running]:
github.com/GoogleCloudPlatform/kubernetes/pkg/proxy.(*tcpProxySocket).ProxyLoop(0xc20802be50, 0x485fb0, 0xd, 0x461db0, 0x4, 0x465af0, 0x1, 0xc208068680, 0xc20809dce0)

..

thockin · 2015-04-11T19:55:46Z

pkg/proxy/proxier.go

@@ -79,6 +79,9 @@ func tryConnect(service ServicePortName, srcAddr net.Addr, protocol string, prox
 		// and keep accepting inbound traffic.
 		outConn, err := net.DialTimeout(protocol, endpoint, retryTimeout*time.Second)
 		if err != nil {
+			if isTooManyFDsError(err) {
+				panic("Dail failed: " + err.Error())


When proxy runs out of fd, it fills the logs with error message. From #6716, it is better to just panic().

xiang90 · 2015-04-11T20:09:44Z

@thockin Fixed typo. PTAL.

thockin · 2015-04-11T20:13:41Z

LGTM

pkg/proxy: panic if run out of fd

lavalamp · 2015-04-13T19:45:48Z

Thanks!

googlebot added the cla: yes label Apr 11, 2015

thockin reviewed Apr 11, 2015
View reviewed changes

thockin self-assigned this Apr 11, 2015

pkg/proxy: panic if run out of fd

4b29947

When proxy runs out of fd, it fills the logs with error message. From #6716, it is better to just panic().

thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2015

wojtek-t added a commit that referenced this pull request Apr 13, 2015

Merge pull request #6727 from xiang90/panic_fds

a531a46

pkg/proxy: panic if run out of fd

wojtek-t merged commit a531a46 into kubernetes:master Apr 13, 2015

xiang90 deleted the panic_fds branch April 13, 2015 14:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pkg/proxy: panic if run out of fd #6727

pkg/proxy: panic if run out of fd #6727

xiang90 commented Apr 11, 2015

thockin Apr 11, 2015

xiang90 commented Apr 11, 2015

thockin commented Apr 11, 2015

lavalamp commented Apr 13, 2015

pkg/proxy: panic if run out of fd #6727

pkg/proxy: panic if run out of fd #6727

Conversation

xiang90 commented Apr 11, 2015

thockin Apr 11, 2015

Choose a reason for hiding this comment

xiang90 commented Apr 11, 2015

thockin commented Apr 11, 2015

lavalamp commented Apr 13, 2015