kubelet: Refactor prober. #7009
Conversation
Decompose the health check prober from the kubelet.
|
|
||
| // NewProber creates a Prober, it takes a command runner and | ||
| // several container info managers. | ||
| func NewProber( |
There was a problem hiding this comment.
Do we expect the function to be called outside of this package? Why capitalized the name?
There was a problem hiding this comment.
@yujuhong Yes, I am expecting to move it to kubelet/prober, otherwise container runtime cannot import it.
There was a problem hiding this comment.
Or move it to kubelet/container...
Actually this function does feel to belong to kubelet in some sense... Hopefully if kubelet someday does not import dockertools or rkt directly, we can move them back...
There was a problem hiding this comment.
Another way to work around this is to define an interface in kubelet/container:
type prober interface {
Probe()
}And then we can pass the kubelet as this interface to the runtime without the circular import problem.
But I feel it's cleaner to just move it to kubelet/prober. What's your opinion?
|
I am fine with it being in kubelet/prober :) |
Decompose the health check prober from the kubelet.
@yujuhong @dchen1107 @vmarmol