New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes UI with Dashboard component #7056
Kubernetes UI with Dashboard component #7056
Conversation
@lavalamp was thinking that doing something like: |
Please see #7073 |
@lavalamp I'm trying a build with that fix now. |
I'm not really sure why the kubernetes.svg isn't appearing. It's accessible on my test cluster at: https://130.211.155.227/static/app/assets/img/kubernetes.svg |
@roberthbailey any ideas about why the logo wouldn't be appearing? This is now fixed with: #7083 |
Looks like the SVG issue is now fixed: |
#### End-to-end testing via Protractor | ||
To run the existing Protractor tests: | ||
* Install the CLIs: `sudo npm install -g protractor`. | ||
* Start the webdriver server: `sudo webdriver-manager start` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do I need to install to get this command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lavalamp Unittests via Karma
To run the existing Karma tests:
Install the Karma CLI: sudo npm install -g karma-cli (it needs to be installed globally, hence the sudo may be needed). Note that the other Karma packages (such as karma, karma-jasmine, and karma-chrome-launcher should be automatically installed when running npm start).
Go to the www/master directory, and run karma start karma.conf.js. The Karma configuration is defined in karma.config.js. The console should show the test results.
remove node modules make new data file for web ui initial commit of dashboard switch back to non SSL request move port splitting to common place; add to node resource location Signed-off-by: Patrick Reilly <patrick@kismatic.io> various path fixes make svg path relative work around missing mime type Signed-off-by: Patrick Reilly <patrick@kismatic.io> fix paths fix karma path remove bad protractor test
There are a number of things in this change that I don't think are up to production grade yet, however instead of bogging this down and asking for fixes for all of them, I've filed #7122. Please tag me in future UI PRs. |
Kubernetes UI with Dashboard component
👍 |
1 similar comment
👍 |
Adding the Kubernetes UI dashboard component.