Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes UI with Dashboard component #7056

Merged
merged 1 commit into from Apr 21, 2015
Merged

Kubernetes UI with Dashboard component #7056

merged 1 commit into from Apr 21, 2015

Conversation

yllierop
Copy link
Contributor

Adding the Kubernetes UI dashboard component.

@yllierop
Copy link
Contributor Author

@lavalamp was thinking that doing something like: strings.Contains("kubernetes-minion-7jpp.c.shared-kraken.internal:4194", ":") and host, port, _ := net.SplitHostPort(u.Host) with the proxy in https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/apiserver/proxy.go#L53 so the goal is for something like https://104.197.21.127/api/v1beta3/proxy/nodes/kubernetes-minion-7jpp.c.shared-kraken.internal:4194/api/v1.1/containers/ to work as it does directly at http://104.197.33.84:4194/api/v1.1/containers/

@lavalamp
Copy link
Member

Please see #7073

@yllierop
Copy link
Contributor Author

@lavalamp I'm trying a build with that fix now.

@yllierop
Copy link
Contributor Author

pr 1

I'm not really sure why the kubernetes.svg isn't appearing. It's accessible on my test cluster at: https://130.211.155.227/static/app/assets/img/kubernetes.svg

@yllierop
Copy link
Contributor Author

@roberthbailey any ideas about why the logo wouldn't be appearing? This is now fixed with: #7083

@lavalamp lavalamp self-assigned this Apr 21, 2015
@yllierop
Copy link
Contributor Author

Looks like the SVG issue is now fixed:
7083_1 with the changes in #7083

@yllierop yllierop changed the title WIP: Kubernetes UI Dashboard Kubernetes UI with Dashboard component Apr 21, 2015
#### End-to-end testing via Protractor
To run the existing Protractor tests:
* Install the CLIs: `sudo npm install -g protractor`.
* Start the webdriver server: `sudo webdriver-manager start`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do I need to install to get this command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lavalamp Unittests via Karma

To run the existing Karma tests:

Install the Karma CLI: sudo npm install -g karma-cli (it needs to be installed globally, hence the sudo may be needed). Note that the other Karma packages (such as karma, karma-jasmine, and karma-chrome-launcher should be automatically installed when running npm start).
Go to the www/master directory, and run karma start karma.conf.js. The Karma configuration is defined in karma.config.js. The console should show the test results.

@lavalamp lavalamp mentioned this pull request Apr 21, 2015
remove node modules

make new data file for web ui

initial commit of dashboard

switch back to non SSL request

move port splitting to common place; add to node resource location

Signed-off-by: Patrick Reilly <patrick@kismatic.io>

various path fixes

make svg path relative

work around missing mime type

Signed-off-by: Patrick Reilly <patrick@kismatic.io>

fix paths

fix karma path

remove bad protractor test
@lavalamp lavalamp mentioned this pull request Apr 21, 2015
12 tasks
@lavalamp
Copy link
Member

There are a number of things in this change that I don't think are up to production grade yet, however instead of bogging this down and asking for fixes for all of them, I've filed #7122. Please tag me in future UI PRs.

lavalamp added a commit that referenced this pull request Apr 21, 2015
@lavalamp lavalamp merged commit 1ebe994 into kubernetes:master Apr 21, 2015
@yllierop
Copy link
Contributor Author

👍

1 similar comment
@jackgr
Copy link
Contributor

jackgr commented Apr 21, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants