Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing more references to v1beta1 from pkg/ #7128

Merged
merged 1 commit into from Apr 24, 2015
Merged

Removing more references to v1beta1 from pkg/ #7128

merged 1 commit into from Apr 24, 2015

Conversation

nikhiljindal
Copy link
Contributor

For #6584

@nikhiljindal nikhiljindal force-pushed the fixbeta1tests branch 3 times, most recently from 9a98ea0 to 1143f9e Compare April 21, 2015 20:32
@nikhiljindal
Copy link
Contributor Author

@bgrant0607

@nikhiljindal nikhiljindal mentioned this pull request Apr 21, 2015
Closed
24 tasks
bgrant0607
bgrant0607 reviewed Apr 21, 2015
View reviewed changes
pkg/apiserver/handlers_test.go
{"GET", getPath("pods", "", ""), "list", testapi.Version(), api.NamespaceAll, "pods", "", "Pod", "", []string{"pods"}},
{"POST", getPath("pods", "", ""), "create", testapi.Version(), api.NamespaceDefault, "pods", "", "Pod", "", []string{"pods"}},
{"GET", getPath("pods", "", "foo"), "get", testapi.Version(), api.NamespaceDefault, "pods", "", "Pod", "foo", []string{"pods", "foo"}},
{"GET", pathWithPrefix("proxy", "pods", "", "foo"), "proxy", testapi.Version(), api.NamespaceDefault, "pods", "", "Pod", "foo", []string{"pods", "foo"}},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you drop redirect intentionally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch, proxy and redirect are all same.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is effectively our only reasonably comprehensive API validation test. I'd prefer not to drop redirect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it back.

@nikhiljindal nikhiljindal force-pushed the fixbeta1tests branch 2 times, most recently from e62f531 to 7269738 Compare April 22, 2015 08:05
@nikhiljindal
Copy link
Contributor Author

Updated code as per comments

@bgrant0607
Copy link
Member

Thanks. LGTM, but tests failed due to the name change:

_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/integration/auth_test.go:82: undefined: testapi.ResourcePathWithQueryParams
_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/integration/auth_test.go:94: undefined: testapi.ResourcePathWithQueryParams
FAIL    github.com/GoogleCloudPlatform/kubernetes/test/integration [build failed]

@nikhiljindal
Copy link
Contributor Author

Fixed it. Travis is green now.

@bgrant0607
Copy link
Member

LGTM

bgrant0607 added a commit that referenced this pull request Apr 24, 2015
@bgrant0607
Merge pull request #7128 from nikhiljindal/fixbeta1tests
60d7bad 
Removing more references to v1beta1 from pkg/
@bgrant0607 bgrant0607 merged commit 60d7bad into kubernetes:master Apr 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bgrant0607 bgrant0607

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nikhiljindal @bgrant0607 @googlebot