AWS: Set hostname_override for minions, back to fully-qualified name #7182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a stop-gap fix; we'd really like to use EC2 instance ids, but that is blocked by kubernetes#7092 or changing that health-check to not assume that the node name is resolvable. This stop-gap essentially reverts kubernetes#7072 for AWS
|
LGTM. Can't say I understand the AWS stuff, but seems contained. Will merge on green. |
cjcullen
added a commit
that referenced
this pull request
Apr 22, 2015
AWS: Set hostname_override for minions, back to fully-qualified name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stop-gap fix; we'd really like to use EC2 instance ids,
but that is blocked by #7092 or changing that health-check to not
assume that the node name is resolvable.
This stop-gap essentially reverts #7072 for AWS