update examples/cassandra to api v1beta3 #7258
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
LGTM, thanks! |
nikhiljindal
added
the
lgtm
update examples/cassandra to api v1beta3
| @@ -64,7 +64,7 @@ public KubernetesSeedProvider(Map<String, String> params) { | |||
|
|
|||
| String host = protocol + "://" + hostName + ":" + hostPort; | |||
| String serviceName = getEnvOrDefault("CASSANDRA_SERVICE", "cassandra"); | |||
| String path = "/api/v1beta1/endpoints/"; | |||
| String path = "/api/v1beta3/endpoints/"; | |||
There was a problem hiding this comment.
This is buggy. I ran across it looking at something else. You can't just change the API version and not the calling code. Look 7 lines down - it is trying to decode this object into a v1beta1 structure.
Please audit this and other v1beta3 conversions for this same problem.
There was a problem hiding this comment.
@caesarxuchao Did you run the example to ensure that it worked?
There was a problem hiding this comment.
The only other URL I found was in rethinkdb, which hasn't been converted yet.
Good catch, thanks.
There was a problem hiding this comment.
I ran through the tutorial, but I didn't check if Cassandra worked properly. I submitted a PR for rethinkdb before I left today. I will ask @nikhiljindal to hold that PR.
related: #6584