Move ComputePodChanges to the Docker runtime #7480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarmol
force-pushed
the
runtime-syncpod
branch
from
4df9fb1
to
c0ceaf1
Compare
|
Correct me if I am wrong. Prober is only used in dockertools/manager, so eventually we will create the prober there, instead of in the kubelet? |
|
The Prober will be used by other runtimes too so it will probably be created by Kubelet and injected into the runtimes. |
vmarmol
force-pushed
the
runtime-syncpod
branch
from
c0ceaf1
to
db12804
Compare
|
I was thinking that each runtime can create its own prober, so that kubelet doesn't have to create and pass the runner. Since kubelet uses runner for other purposes, this seems fine to me. Thanks for clarifying. |
This logic is specific to the Docker runtime. This move is the first step towards making syncPod() runtime-agnostic.
vmarmol
force-pushed
the
runtime-syncpod
branch
from
db12804
to
fe4600b
Compare
|
Yes, Travis is green finally :) |
|
LGTM! Thanks @vmarmol ! |
yujuhong
added a commit
that referenced
this pull request
Apr 29, 2015
Move ComputePodChanges to the Docker runtime
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on the refactoring in #7479. Split into two PRs for ease of review.
/cc @yujuhong @dchen1107 @yifan-gu