kubelet/rkt: Add RunPod() for rkt. #7589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // Save the unit file under systemd's service directory. | ||
| // TODO(yifan) Garbage collect 'dead' serivce files. |
|
Looks good, we should wait for the deps to go in first though :) |
This was referenced Apr 30, 2015
|
@vmarmol Rebased. Think still will conflict with others (for the import path) |
|
LGTM, it may be okay alongside #7553 |
|
I feel it will conflict on the kubecontainer import :( |
vmarmol
added a commit
that referenced
this pull request
May 1, 2015
kubelet/rkt: Add RunPod() for rkt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vmarmol @dchen1107 @jonboulle @bakins
This has a dependency on some previous PR, (makePodServiceFileName).
Thanks you!