New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build github.com/onsi/ginkgo/ginkgo as a part of the release #7593
Conversation
I have no idea how to test this besides hoping for the best. |
I'm still confused. Is there nowhere to put this in the build system that makes any sense? I'm against this because it's another step before you can run e2es. (Jenkins is just mimicking the dev e2e flow, with some extras.) |
Other alternatives I can see:
I'm guessing option 1 is your preference? |
We build other test artifacts as part of "make release" and package them with the test tar. I don't see this as that different, unless the license would prohibit it. |
I guess the main difference here is that the rest of the test artifacts are under the |
I think I'd still rather go that route. If we had a real set of packages (rpms, debs, etc.), this would be different, but we don't. The tars are basically all the binaries you need to run the server, client and tests. |
We should seriously consider building rpms, debs etc packages for Q On Fri, May 1, 2015 at 5:49 AM, Zach Loafman notifications@github.com
|
Additionally, add hack/lib to the testing tarball.
OK, I've reworked this PR so that it builds ginkgo as a part of the release process (and copies the binary into the appropriate output directories, tarballs, etc). Can you take a look? I'm not sure if we want to include someone familiar with the build scripts as well. I've tested with |
I'm actually pretty familiar with the build scripts, too. :) |
In that case, we're already set. :) I just wasn't sure who is familiar with them. |
You might try |
|
Well, damn the torpedoes? |
LGTM |
Build github.com/onsi/ginkgo/ginkgo as a part of the release
Builds the ginkgo test runner as a part of the release process. After this is merged, we can try using the native ginkgo runner again.
@quinton-hoole @zmerlynn