Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build github.com/onsi/ginkgo/ginkgo as a part of the release #7593

Merged
merged 1 commit into from May 1, 2015

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Apr 30, 2015

Builds the ginkgo test runner as a part of the release process. After this is merged, we can try using the native ginkgo runner again.

@quinton-hoole @zmerlynn

@ixdy
Copy link
Member Author

ixdy commented Apr 30, 2015

I have no idea how to test this besides hoping for the best.

@zmerlynn
Copy link
Member

I'm still confused. Is there nowhere to put this in the build system that makes any sense? I'm against this because it's another step before you can run e2es. (Jenkins is just mimicking the dev e2e flow, with some extras.)

@ixdy
Copy link
Member Author

ixdy commented Apr 30, 2015

Other alternatives I can see:

  1. build github.com/onsi/ginkgo/ginkgo as part of build/release.sh (seems a little weird, especially if one isn't going to run e2e tests, but there's really no other place to put it?)
  2. run ginkgo from hack/ginkgo-e2e.sh with go run ... rather than calling the binary directly (not even sure if this would work, but maybe?)
  3. as currently implemented: install godep and then build/install ginkgo using godep

I'm guessing option 1 is your preference?

@zmerlynn
Copy link
Member

We build other test artifacts as part of "make release" and package them with the test tar. I don't see this as that different, unless the license would prohibit it.

@ixdy
Copy link
Member Author

ixdy commented Apr 30, 2015

I guess the main difference here is that the rest of the test artifacts are under the github.com/GoogleCloudPlatform/kubernetes package. Ginkgo would not be. It's doable, it'll just require a bit of refactoring of the build scripts to support.

@zmerlynn
Copy link
Member

zmerlynn commented May 1, 2015

I think I'd still rather go that route. If we had a real set of packages (rpms, debs, etc.), this would be different, but we don't. The tars are basically all the binaries you need to run the server, client and tests.

@ghost
Copy link

ghost commented May 1, 2015

We should seriously consider building rpms, debs etc packages for
distribution. Has anyone considered this? Does anyone have strong
opinions either way?

Q

On Fri, May 1, 2015 at 5:49 AM, Zach Loafman notifications@github.com
wrote:

I think I'd still rather go that route. If we had a real set of packages
(rpms, debs, etc.), this would be different, but we don't. The tars are
basically all the binaries you need to run the server, client and tests.


Reply to this email directly or view it on GitHub
#7593 (comment)
.

Additionally, add hack/lib to the testing tarball.
@ixdy
Copy link
Member Author

ixdy commented May 1, 2015

OK, I've reworked this PR so that it builds ginkgo as a part of the release process (and copies the binary into the appropriate output directories, tarballs, etc). Can you take a look?

I'm not sure if we want to include someone familiar with the build scripts as well.

I've tested with make and build/release.sh - what else should I do?

@ixdy ixdy changed the title Install godep as part of the Jenkins e2e job. Build github.com/onsi/ginkgo/ginkgo as a part of the release May 1, 2015
@zmerlynn
Copy link
Member

zmerlynn commented May 1, 2015

I'm actually pretty familiar with the build scripts, too. :)

@ixdy
Copy link
Member Author

ixdy commented May 1, 2015

In that case, we're already set. :) I just wasn't sure who is familiar with them.

@zmerlynn
Copy link
Member

zmerlynn commented May 1, 2015

You might try hack/e2e-from-release.sh to make sure the binary release is sane.

@ixdy
Copy link
Member Author

ixdy commented May 1, 2015

hack/e2e-from-release.sh appears to have worked as well, I think.

@zmerlynn
Copy link
Member

zmerlynn commented May 1, 2015

Well, damn the torpedoes?

@zmerlynn
Copy link
Member

zmerlynn commented May 1, 2015

LGTM

zmerlynn added a commit that referenced this pull request May 1, 2015
Build github.com/onsi/ginkgo/ginkgo as a part of the release
@zmerlynn zmerlynn merged commit 230449f into kubernetes:master May 1, 2015
@ixdy ixdy deleted the jenkins-godep branch August 21, 2015 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants