Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in runtime_cache.go #7725

Merged
merged 1 commit into from May 5, 2015
Merged

Conversation

pmorie
Copy link
Member

@pmorie pmorie commented May 4, 2015

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@roberthbailey
Copy link
Contributor

@pmorie I've noticed that most of the RedHat folks aren't getting the CLA bot warning any longer but you still seem to be. Any ideas why you aren't passing the automated checks?

@roberthbailey roberthbailey self-assigned this May 4, 2015
@roberthbailey
Copy link
Contributor

Code LGTM. Will merge on green.

@pmorie
Copy link
Member Author

pmorie commented May 4, 2015

@roberthbailey I believe it's because I hadn't switched my public email on my gh account over to my redhat.com email address. Let's see what happens now.

@roberthbailey
Copy link
Contributor

@pmorie that would explain it.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 4, 2015
@pmorie
Copy link
Member Author

pmorie commented May 4, 2015

@roberthbailey Fixed

@roberthbailey
Copy link
Contributor

Thanks! (now just waiting for a green dot...)

@pmorie
Copy link
Member Author

pmorie commented May 4, 2015

@roberthbailey Presumably the travis build will run at some point.

@roberthbailey
Copy link
Contributor

I think it's actually next in line!

@pmorie
Copy link
Member Author

pmorie commented May 4, 2015

I should have gotten a low number from the scalper

roberthbailey added a commit that referenced this pull request May 5, 2015
Fix typo in runtime_cache.go
@roberthbailey roberthbailey merged commit 5fe07e6 into kubernetes:master May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants