Kubelet: Add rkt as a runtime option #7743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarmol
changed the title
vmarmol
force-pushed
the
runtime-switch
branch
2 times, most recently
from
9e39fc8
to
bbe1982
Compare
|
This is now ready for review, PTAL @yujuhong @dchen1107 |
|
LGTM |
dchen1107
added
the
lgtm
|
LGTM. |
|
LGTM |
|
Filed a bug for the shippable failure: #7788 |
|
Shippable passed. Merging. |
yujuhong
added a commit
that referenced
this pull request
May 5, 2015
Kubelet: Add rkt as a runtime option
|
I believe this broke the standard GCE-Debian build. Or, at least, this or #7343. I'm rolling this one back first, sorry. |
|
No problem @zmerlynn! Let us know when the coast is clear and we'll retry. I'd be surprised if this PR is the cause, but there is always a first :) |
This was referenced May 5, 2015
This was referenced May 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly, as I finished this I realized we need to add built-time labels...so I'm gonna do that :)
/cc @yujuhong @dchen1107 @yifan-gu @jonboulle