skydns: use the etcd-2.x native syntax, enable IANA attributed ports. #7764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. I didn't realize those were deprecated. LGTM. |
|
Sorry I didn't get to it before it needed a rebase. :( |
per https://github.com/coreos/etcd/blob/master/Documentation/backward_compatibility.md (there are no functional changes, we just stop using the legacy flags, for consistency.) Signed-off-by: António Meireles <antonio.meireles@reformi.st>
AntonioMeireles
force-pushed
the
skydns_etcd_deprecatedFlags
branch
from
d114f9c
to
24a0e56
Compare
|
@cjcullen just rebased it, sorry the lag. |
cjcullen
added a commit
that referenced
this pull request
May 6, 2015
…lags skydns: use the etcd-2.x native syntax, enable IANA attributed ports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per https://github.com/coreos/etcd/blob/master/Documentation/backward_compatibility.md
(there are no functional changes, we just stop using the legacy flags, for
consistency.)