Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS: expose 53/TCP #7822

Merged
merged 6 commits into from May 7, 2015
Merged

DNS: expose 53/TCP #7822

merged 6 commits into from May 7, 2015

Conversation

thockin
Copy link
Member

@thockin thockin commented May 6, 2015

Finish v1beta3 conversion, too.

Fixes #7474

@vishh or @cjcullen

Will add e2e coverage of this if I can figure it out.

@mbforbes
Copy link
Contributor

mbforbes commented May 6, 2015

@cjcullen of course feel free to swap around

@thockin
Copy link
Member Author

thockin commented May 6, 2015

e2e is hard - the only tool I know that can do TCP lookups is dig, and busybox !has dig. will keep thinking about this.

In the mean time, manually tested.

@vishh
Copy link
Contributor

vishh commented May 6, 2015

LGTM

@vishh vishh added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2015
@mbforbes mbforbes assigned vishh and unassigned cjcullen May 6, 2015
@mbforbes
Copy link
Contributor

mbforbes commented May 6, 2015

(To @vishh as he's already looked now.) I'll merge on green tomorrow—squash maybe?

@thockin
Copy link
Member Author

thockin commented May 6, 2015

Give me a bit to figure out e2e. I can't figure out how to reproducibly
get a container with dig in it that isn't full-on ubuntu. Grr. I could
get source code and build my own static binary, but that's not really
reproducible.

On Tue, May 5, 2015 at 9:21 PM, Maxwell Forbes notifications@github.com
wrote:

(To @vishh https://github.com/vishh as he's already looked now.) I'll
merge on green tomorrow—squash maybe?


Reply to this email directly or view it on GitHub
#7822 (comment)
.

@mbforbes
Copy link
Contributor

mbforbes commented May 6, 2015

Mmm... wish I knew more about *nix tooling ... @zmerlynn does, I think—thoughts?

@thockin
Copy link
Member Author

thockin commented May 6, 2015

The dig source code is the ISC bind distribution and does not have a
provision for static (the old issue with libresolve being dynamic no matter
what). Still hunting for a good answer.

On Tue, May 5, 2015 at 11:33 PM, Maxwell Forbes notifications@github.com
wrote:

Mmm... wish I knew more about *nix tooling ... @zmerlynn
https://github.com/zmerlynn does, I think—thoughts?


Reply to this email directly or view it on GitHub
#7822 (comment)
.

@zmerlynn
Copy link
Member

zmerlynn commented May 6, 2015

When I had to do this in bring up scripts on our system, I was left with
"getent hosts".
On May 5, 2015 11:42 PM, "Tim Hockin" notifications@github.com wrote:

The dig source code is the ISC bind distribution and does not have a
provision for static (the old issue with libresolve being dynamic no matter
what). Still hunting for a good answer.

On Tue, May 5, 2015 at 11:33 PM, Maxwell Forbes notifications@github.com
wrote:

Mmm... wish I knew more about *nix tooling ... @zmerlynn
https://github.com/zmerlynn does, I think—thoughts?


Reply to this email directly or view it on GitHub
<
#7822 (comment)

.


Reply to this email directly or view it on GitHub
#7822 (comment)
.

@thockin
Copy link
Member Author

thockin commented May 7, 2015

Added e2e, PTAL

@vishh
Copy link
Contributor

vishh commented May 7, 2015

Thanks for the e2e Tim. LGTM

vishh added a commit that referenced this pull request May 7, 2015
@vishh vishh merged commit e25210d into kubernetes:master May 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-dns pod should expose TCP port
6 participants