kubelet/rkt: Remove build label. #7916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we removed the linux specific dependency, now rkt can be built on other platforms as well.
|
Cross build looks good: KUBE_RELEASE_RUN_TESTS=n build/release.sh
+++ [0507 13:41:27] Verifying Prerequisites....
+++ [0507 13:41:27] Building Docker image kube-build:cross.
+++ [0507 13:41:29] Building Docker image kube-build:build-ec74918960.
+++ [0507 13:41:33] Running build command....
+++ [0507 13:41:33] Creating data container
+++ [0507 20:41:34] Building go targets for linux/amd64:
cmd/kube-proxy
cmd/kube-apiserver
cmd/kube-controller-manager
cmd/kubelet
cmd/hyperkube
cmd/kubernetes
plugin/cmd/kube-scheduler
+++ [0507 20:42:21] Multiple platforms requested, but available 7G < threshold 8G, building platforms in serial
+++ [0507 20:42:21] Building go targets for linux/amd64:
cmd/kubectl
cmd/e2e
cmd/integration
cmd/gendocs
cmd/genman
cmd/genbashcomp
examples/k8petstore/web-server
github.com/onsi/ginkgo/ginkgo
+++ [0507 20:42:34] Building go targets for linux/386:
cmd/kubectl
cmd/e2e
cmd/integration
cmd/gendocs
cmd/genman
cmd/genbashcomp
examples/k8petstore/web-server
github.com/onsi/ginkgo/ginkgo
+++ [0507 20:42:58] Building go targets for linux/arm:
cmd/kubectl
cmd/e2e
cmd/integration
cmd/gendocs
cmd/genman
cmd/genbashcomp
examples/k8petstore/web-server
github.com/onsi/ginkgo/ginkgo
+++ [0507 20:43:20] Building go targets for darwin/amd64:
cmd/kubectl
cmd/e2e
cmd/integration
cmd/gendocs
cmd/genman
cmd/genbashcomp
examples/k8petstore/web-server
github.com/onsi/ginkgo/ginkgo
+++ [0507 20:43:45] Building go targets for darwin/386:
cmd/kubectl
cmd/e2e
cmd/integration
cmd/gendocs
cmd/genman
cmd/genbashcomp
examples/k8petstore/web-server
github.com/onsi/ginkgo/ginkgo
+++ [0507 20:44:08] Building go targets for windows/amd64:
cmd/kubectl
cmd/e2e
cmd/integration
cmd/gendocs
cmd/genman
cmd/genbashcomp
examples/k8petstore/web-server
github.com/onsi/ginkgo/ginkgo
+++ [0507 20:44:32] Placing binaries
+++ [0507 13:44:53] Running build command....
+++ [0507 13:44:55] Output directory is local. No need to copy results out.
+++ [0507 13:44:55] Building tarball: salt
+++ [0507 13:44:55] Building tarball: server linux-amd64
+++ [0507 13:44:55] Starting tarball: client darwin-386
+++ [0507 13:44:55] Starting tarball: client darwin-amd64
+++ [0507 13:44:55] Starting tarball: client linux-386
+++ [0507 13:44:55] Starting tarball: client linux-amd64
+++ [0507 13:44:55] Starting tarball: client linux-arm
+++ [0507 13:44:55] Starting tarball: client windows-amd64
+++ [0507 13:44:55] Waiting on tarballs
+++ [0507 13:44:57] Starting Docker build for image: kube-apiserver
+++ [0507 13:44:57] Starting Docker build for image: kube-controller-manager
+++ [0507 13:44:58] Starting Docker build for image: kube-scheduler
+++ [0507 13:45:03] Docker builds done
+++ [0507 13:45:21] Building tarball: test
+++ [0507 13:45:21] Building tarball: full
|
|
LGTM |
vmarmol
added a commit
that referenced
this pull request
May 7, 2015
kubelet/rkt: Remove build label.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we removed the linux specific dependency, now rkt can be built
on other platforms as well.