New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the API server deal with HEAD requests via the service proxy #7950
Conversation
@@ -514,6 +514,7 @@ func (a *APIInstaller) registerResourceHandlers(path string, storage rest.Storag | |||
addProxyRoute(ws, "PUT", a.prefix, action.Path, proxyHandler, kind, resource, action.Params) | |||
addProxyRoute(ws, "POST", a.prefix, action.Path, proxyHandler, kind, resource, action.Params) | |||
addProxyRoute(ws, "DELETE", a.prefix, action.Path, proxyHandler, kind, resource, action.Params) | |||
addProxyRoute(ws, "HEAD", a.prefix, action.Path, proxyHandler, kind, resource, action.Params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome-- how about adding TRACE while you're here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
LGTM, thanks! |
Make the API server deal with HEAD requests via the service proxy
Jenkins went red running a build where this was the only PR merged. |
It looks like the current build is at least running tests though. |
one of the test runs that failed with this merge failed because of a setup issue.. http://kubekins.dls.corp.google.com/job/kubernetes-e2e-gce/5783/console |
@roberthbailey it seems extremely unlikely to me that this actually is the cause. |
I agree. I hadn't dug into the cause of the failure prior to commenting here. |
This addresses issue #7517 and I tested this out on the Elasticsearch and Kibana logging setup. I observed the new Kibana 4 (running with a back-end server) correctly issuing a HEAD request to Elasticsearch.
@lavalamp @brendandburns @ArtfulCoder