Accurately get hardware cpu count in Vagrantfile. #8024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Vagrantfile replace hack that assumed hyper threading was enabled on the host and divided ncpu by 2 with methods of getting the actual hardware core count.
|
I have a pretty fast 4 core intel proc (i5-2500k @ 4.2ghz turbo) without hyperthreading enabled so when I spotted the copy-pasta here assuming hyperthreading I whipped up a quick fix. Tested on Yosemite (on a laptop that does have hyperthreading) and Fedora 21 but should be quite portable, did a little googling to find some methods of getting physical core count. Not sure about the best solution for windows so I left that as is. |
|
LGTM |
zmerlynn
added
the
lgtm
jszczepkowski
added a commit
that referenced
this pull request
May 11, 2015
Accurately get hardware cpu count in Vagrantfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Vagrantfile replace hack that assumed hyper threading was enabled on
the host and divided ncpu by 2 with methods of getting the actual
hardware core count.