Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache with multiple shards to decrease lock contention #8050

Merged
merged 1 commit into from May 11, 2015

Conversation

fgrzadkowski
Copy link
Contributor

This change improves latency of read operations.

@@ -0,0 +1,64 @@
package util
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some unit test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@wojtek-t
Copy link
Member

Generally looks good - please add a unit test for the cache.

@wojtek-t
Copy link
Member

LGTM - will merge on green.

@wojtek-t wojtek-t added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2015
@nikhiljindal
Copy link
Contributor

Travis is green. Merging.

nikhiljindal added a commit that referenced this pull request May 11, 2015
Add cache with multiple shards to decrease lock contention
@nikhiljindal nikhiljindal merged commit 48dfad6 into kubernetes:master May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants