Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing slicing of alert conditions in pagination. #3529

Merged
merged 1 commit into from Feb 23, 2017
Merged

Fixing slicing of alert conditions in pagination. #3529

merged 1 commit into from Feb 23, 2017

Conversation

dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Feb 21, 2017 •
edited

Description

Motivation and Context

Before this change, the slice of alert conditions shown in the paginated
view was calculated incorrectly.

Fixes #3528.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dennisoelkers
Fixing slicing of alert conditions in pagination.
3ef7059 
Before this change, the slice of alert conditions shown in the paginated
view was calculated incorrectly.

Fixes #3528.
@dennisoelkers dennisoelkers added this to the 2.2.2 milestone Feb 21, 2017
joschi
joschi approved these changes Feb 23, 2017
View reviewed changes
Copy link
Contributor

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@joschi joschi self-assigned this Feb 23, 2017
@joschi joschi merged commit 0e25b82 into master Feb 23, 2017
@joschi joschi deleted the issue-3528 branch February 23, 2017 13:39
joschi pushed a commit that referenced this pull request Feb 23, 2017
@dennisoelkers
Fixing slicing of alert conditions in pagination. (#3529)
7f70f15 
Before this change, the slice of alert conditions shown in the paginated
view was calculated incorrectly.

Fixes #3528
(cherry picked from commit 0e25b82)
joschi pushed a commit that referenced this pull request Feb 23, 2017
@dennisoelkers
Fixing slicing of alert conditions in pagination. (#3529)
427fb7e 
Before this change, the slice of alert conditions shown in the paginated
view was calculated incorrectly.

Fixes #3528
(cherry picked from commit 0e25b82)
@joschi joschi modified the milestones: 3.0.0, 2.2.2 Feb 23, 2017
edmundoa pushed a commit that referenced this pull request Feb 23, 2017
@joschi @edmundoa
Fixing slicing of alert conditions in pagination. (#3529) (#3541)
76ede1b 
Before this change, the slice of alert conditions shown in the paginated
view was calculated incorrectly.

Fixes #3528
(cherry picked from commit 0e25b82)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschi joschi joschi approved these changes

Assignees

@joschi joschi

Labels
web
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Pagination on the Manage alert conditions page is not working
2 participants
@dennisoelkers @joschi