Copy Query Button Fix (#3491) #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works perfect on all tested browsers. |
dennisoelkers
approved these changes
Mar 9, 2017
dennisoelkers
pushed a commit
that referenced
this pull request
Mar 9, 2017
(cherry picked from commit a273393)
This was referenced Mar 9, 2017
edmundoa
pushed a commit
that referenced
this pull request
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes behavior of ClipboardButton component to rely on the target instead of passing in text. For some reason, passing in text, does not cause the text to be copied to the clipboard. However, passing in target element does cause ClipBoard to work properly. This is related to bug report #3491.
Motivation and Context
Fixes open issue #3491 which allows queries to be copied to the clipboard.
How Has This Been Tested?
I test changes by running the web interface with the change. The changes worked as expected. I also did in depth troubleshooting on the text portion and do not understand the reason that it is not copying.
Types of changes
Checklist: