Comply with grace condition when repeat alert notifications is enabled #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 29, 2017 17:12
Check the time last notification was sent to ensure we don't repeat notifications too often, complying with the grace period set by the user. Fixes #3579
dennisoelkers
approved these changes
Apr 3, 2017
edmundoa
added a commit
that referenced
this pull request
Apr 3, 2017
#3676) * Remove condition, as it's always true * Comply with grace period when repeating notifications Check the time last notification was sent to ensure we don't repeat notifications too often, complying with the grace period set by the user. Fixes #3579 * Fix ForbiddenAPIs errors * Mock shouldRepeatNotifications method to fix test
dennisoelkers
pushed a commit
that referenced
this pull request
Apr 3, 2017
#3676) (#3686) * Remove condition, as it's always true * Comply with grace period when repeating notifications Check the time last notification was sent to ensure we don't repeat notifications too often, complying with the grace period set by the user. Fixes #3579 * Fix ForbiddenAPIs errors * Mock shouldRepeatNotifications method to fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 2.2.2 we added the possibility to repeat alert notifications, allowing users to keep the old behaviour in their alerts while still having some features of the new stateful alerts.
Unfortunately this option was not taking into account the grace period, so users got notified way too many times, as explained in #3579.
This PR checks the alert history to see when was the last time notifications were send for the alert, and verify that the defined grace period has elapsed before notifying again.
I'm also adding some tests to ensure that all cases (or all I though of) are covered and we don't break any other case by mistake.
Fixes #3579.