This repository has been archived by the owner on Oct 18, 2018. It is now read-only.
A particularly nasty bug that I fixed myself! (all the while learning about GitHub) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Skins/Haackify/Images/bottom.gif)
… an absolute URL
… say, Technorati) by supporting tag URLs without "/default.aspx" on the end
…at it is available to skin controls that want to format the fields differently or show additional fields)
…ial page update (e.g. when custom CAPTCHA control failed validation)
…is running in Medium trust
…de blocks (i.e. "<% ... %>")
…ed by disabling the full text search engine in Web.config
…in.config file (and treat these CSS references as "remote")
…en browsing Subtext pages using HTTPS
… Subtext blog pages using HTTPS
- Error in PROD (i.e. "System.Web.HttpException: The file '/blog/jjameson/Services/Pingback.aspx' does not exist.") - The "pingback" URL specified in the <link> head element should be an absolute URL (not a relative URL) according to the Pingback 1.0 specification (http://www.hixie.ch/specs/pingback/pingback) - According to the current Subtext routing functionality, the "pingback" URL needs to include the ID of the post (e.g. "http://www.technologytoolbox.com/blog/jjameson/Services/Pingback/315.aspx")
|
THANKS!!! I'll review this ASAP. |
| @@ -1126,6 +1126,8 @@ WHERE (c.CategoryID = @CategoryID OR @CategoryID IS NULL) | |||
| AND (c.CategoryType = @CategoryType OR @CategoryType IS NULL) | |||
| AND (c.BlogId = @BlogId OR @BlogId IS NULL) | |||
| AND c.Active <> CASE @IsActive WHEN 0 THEN -1 else 0 END | |||
| ORDER BY | |||
| c.Title | |||
There was a problem hiding this comment.
Let's be explicit about ordering. This should probably be:
ORDER BY
c.Title ASC
… files (per Phil's feedback)
- Includes new AdoNetAppender.ConnectionStringName property - Reference: https://issues.apache.org/jira/browse/LOG4NET-88
- Add NuGet packages for ASP.NET MVC 3 to Framework, Web, and UnitTests projects
…onsistent with other controls, e.g. PostComment)
This reverts commit 3b2702b.
- Fix #3 - This is required to support the new **staging** deployment slot for technologytoolbox.com
This is a prerequisite for installing the latest MSTest.TestFramework NuGet package.
- Update-Package log4net -Reinstall - Update-Package Ninject -Reinstall - Update-Package xmlrpcnet -Reinstall This resolves a warning in Visual Studio after updating test project to .NET 4.5.
- Install-Package MSTest.TestFramework - Install-Package MSTest.TestAdapter - Install-Package Microsoft.NET.Test.Sdk
- While not as "elegant" as the original EmailProvider tests, this is "good enough" for the current test scenarios
jeremy-jameson
force-pushed
the
master
branch
from
f905d9e
to
b761a46
Compare
- This is required to avoid errors when building the solution on Azure DevOps hosted agents
This is necessary to avoid an error when running the tests in specific environments (e.g. EXT-VS2017-DEV3). This assembly is installed in the GAC in some environments (e.g. EXT-VS2013-DEV1) -- presumably due to installing the corresponding version of SQL Server Express.
Convert tests from MbUnit to MSTest
- Issue #8 - These two tests intermittently fail when executed on Azure DevOps hosted agents (but consistently succeed in various local environments). Change the messages to be unique to identify which assertions are actually failing.
- Fix #8 - This prevents intermittent test failures depending on the speed at which the code is executed (i.e. two entries having the same value in subtext_Content.DatePublishedUtc).
Fix intermittent test failures in Azure DevOps build pipeline
- Fixes #10 - Fixing the bug was easy...trying to create a corresponding unit test turned out to be a nightmare (I eventually punted this due to time constraints) - The new test currently throws a NullReferenceException in Transformer.GetLinkFromLinkCategory - TODO: Determine why UrlHelper.GetVirtualPath returns null for category route
- Fixes #11 - Fixing the bug was easy...but creating a corresponding unit test...not so much (similar to previous bug fix for category URLs)
Fix URLs in sitemap.ashx
Bumps [DotNetZip](https://github.com/haf/DotNetZip.Semverd) from 1.9.1.8 to 1.11.0. - [Release notes](https://github.com/haf/DotNetZip.Semverd/releases) - [Commits](https://github.com/haf/DotNetZip.Semverd/commits) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [log4net](https://github.com/apache/logging-log4net) from 1.2.11 to 2.0.10. - [Release notes](https://github.com/apache/logging-log4net/releases) - [Changelog](https://github.com/apache/logging-log4net/blob/master/ReleaseInstructions.txt) - [Commits](apache/logging-log4net@rel/1.2.11...rel/2.0.10) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [log4net](https://github.com/apache/logging-log4net) from 1.2.11 to 2.0.10. - [Release notes](https://github.com/apache/logging-log4net/releases) - [Changelog](https://github.com/apache/logging-log4net/blob/master/ReleaseInstructions.txt) - [Commits](apache/logging-log4net@rel/1.2.11...rel/2.0.10) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [log4net](https://github.com/apache/logging-log4net) from 1.2.11 to 2.0.10. - [Release notes](https://github.com/apache/logging-log4net/releases) - [Changelog](https://github.com/apache/logging-log4net/blob/master/ReleaseInstructions.txt) - [Commits](apache/logging-log4net@rel/1.2.11...rel/2.0.10) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [DotNetZip](https://github.com/haf/DotNetZip.Semverd) from 1.9.1.8 to 1.11.0. - [Release notes](https://github.com/haf/DotNetZip.Semverd/releases) - [Commits](https://github.com/haf/DotNetZip.Semverd/commits) Signed-off-by: dependabot[bot] <support@github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.