@@ -30,8 +30,8 @@ module GChart def initialize(options={}, &block) @data = [] @extras = {} - @width = 300 - @height = 200 + @width ||= 300 + @height ||= 200 options.each { |k, v| send("#{k}=", v) } yield(self) if block_given? lib/gchart/base.rb @@ -6,7 +6,6 @@ module GChart attr_accessor :background def initialize(*args, &block) - super(*args, &block) # Set some sane defaults so that the only requirement is data @area = 'world' #default @background = 'dfdfff' #make it look like water @@ -15,6 +14,7 @@ module GChart # it is also the proper aspect ratio) @width = '440' @height = '220' + super(*args, &block) end # Map data can be in the form {"VA'=>5,'NY'=>1} or [['VA',5],['NY',1]] lib/gchart/map.rb @@ -4,9 +4,9 @@ module GChart # axis lines. Because they are often placed within text, the default # size should be smaller. def initialize(*args, &block) - super(*args, &block) @width = "60" @height = "20" + super(*args, &block) end def render_chart_type #:nodoc: "ls" lib/gchart/sparkline.rb 97119e24de8e49976f8b0de898ca645d1f2edfb9 Jack Danger Canty git@6brand.com http://github.com/JackDanger/gchart/commit/1cbe844a2a0b4bceb2a47b7556343343492f962c 1cbe844a2a0b4bceb2a47b7556343343492f962c 2008-06-13T10:37:09-07:00 2008-06-13T10:37:09-07:00 making default width and height only defaults - not permanent The default width and height for sparkline and map was set after super was called and therefore could not be overridden. d49f5afccafa8fcc1af9248eac5ef2a4108f68a7 Jack Danger Canty git@6brand.com