JackDanger / rails fork watch download tarball
public
Fork of rails/rails
Description: Ruby on Rails
Homepage: http://rubyonrails.org
Clone URL: git://github.com/JackDanger/rails.git

Comments for rails   feed

assaf commented on JackDanger/rails about 1 month ago
Comment in b7529ed:

How about?
<pre>
if_modified do
respond_to do |wants|
. . .
end
end
</pre>
DRY-er and less confusing.

dkubb commented on JackDanger/rails about 1 month ago
Comment on actionpack/lib/action_controller/response.rb L70 in b7529ed:

The Time object doesn’t necessarily need to be in utc format for Time#httpdate. Regardless of the timezone it will be converted into GMT automatically before being converted into HTTP date format.

dkubb commented on JackDanger/rails about 1 month ago
Comment on actionpack/lib/action_controller/request.rb L96 in b7529ed:

Perhaps this should use Time.httpdate() here instead of Time.rfc2822.

yfactorial commented on JackDanger/rails about 1 month ago
Comment in b7529ed:

I have a semantic nit.
In my mind "fresh" implies the request is new and should be processed as opposed to this implementation using it to mean that it’s an old request and should not be processed?
I may not be in on any conditional get specific vocabulary, however.

kamal commented on JackDanger/rails 5 months ago
Comment on activerecord/lib/active_record/base.rb L2209 in 7288652:

Is the `` meant to be there?