Async command support #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pondidum Ugh, I'm sorry. This slipped by me or I totally forgot about it. I'll try to get this reviewed and hopefully out tomorrow. |
|
No worries, I know how busy you are! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OaktonCommand's private implementation ofIOaktonCommandto useTask.FromResult(Execute((T)input)).OaktonAsyncCommand<T>).CancellationTokento the method as I couldn't see a clean way of providing a token, and cancelling it onctrl+cusageOnly thing I am not sure on is what version number to set in the
rakefile, as I changed theIOakonCommand's definition it should be2.0.0I guess? Although from a typical user's perspective,1.4.1would make sense as people only really inheritOaktonCommand<T>.