0005216: Metadata error can skip data when using

dataloader.ignore.missing.tables parameter
JumpMind · Feb 14, 2022 · 19c1d7e · 19c1d7e
1 parent 67318fe
commit 19c1d7e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 15 deletions.
diff --git a/symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/writer/AbstractDatabaseWriter.java b/symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/writer/AbstractDatabaseWriter.java
@@ -102,16 +102,7 @@ public boolean start(Table table) {
         }
         this.lastData = null;
         this.sourceTable = table;
-        try {
-            this.targetTable = lookupTableAtTarget(this.sourceTable);
-        } catch (SqlException sqle) {
-            log.warn("Unable to read target table because {}", sqle.getMessage());
-        }
-        if (this.targetTable == null && this instanceof DynamicDefaultDatabaseWriter) {
-            if (((DynamicDefaultDatabaseWriter) this).isLoadOnly()) {
-                this.targetTable = table;
-            }
-        }
+        this.targetTable = lookupTableAtTarget(this.sourceTable);
         this.sourceTable.copyColumnTypesFrom(this.targetTable);
         if (this.targetTable == null && hasFilterThatHandlesMissingTable(table)) {
             this.targetTable = table;

diff --git a/symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/writer/DefaultDatabaseWriter.java b/symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/writer/DefaultDatabaseWriter.java
@@ -1038,11 +1038,9 @@ protected Table lookupTableAtTarget(Table sourceTable) {
                     targetTables.put(tableNameKey, table);
                 }
             } catch (SqlException sqle) {
-                log.warn("Unable to read target table because {}", sqle.getMessage());
-            }
-            if (table == null && this instanceof DynamicDefaultDatabaseWriter) {
-                if (((DynamicDefaultDatabaseWriter) this).isLoadOnly()) {
-                    table = sourceTable;
+                // TODO: is there really a "does not exist" exception or should this be removed? copied from AbstractJdbcDdlReader.readTable()
+                if (sqle.getMessage() == null || !StringUtils.containsIgnoreCase(sqle.getMessage(), "does not exist")) {
+                    throw sqle;
                 }
             }
         }