From 27736a22a0d8f036a59df72486123603d9cd69af Mon Sep 17 00:00:00 2001 From: erilong Date: Tue, 23 Sep 2014 17:14:11 +0000 Subject: [PATCH] 0001989: Switching cluster locks off causes initialization error --- .../service/impl/ClusterService.java | 44 +++++++++---------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/ClusterService.java b/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/ClusterService.java index 2d3067908a..3812c3b737 100644 --- a/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/ClusterService.java +++ b/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/ClusterService.java @@ -77,11 +77,13 @@ public void init() { sqlTemplate.update(getSql("initLockSql"), new Object[] { getServerId() }); Map allLocks = findLocks(); - for (String action : new String[] { ROUTE, PULL, PUSH, HEARTBEAT, PURGE_INCOMING, PURGE_OUTGOING, PURGE_STATISTICS, SYNCTRIGGERS, - PURGE_DATA_GAPS, STAGE_MANAGEMENT, WATCHDOG, STATISTICS, FILE_SYNC_PULL, FILE_SYNC_PUSH, FILE_SYNC_TRACKER, - INITIAL_LOAD_EXTRACT }) { - if (allLocks.get(action) == null) { - initLockTable(action, TYPE_CLUSTER); + if (isClusteringEnabled()) { + for (String action : new String[] { ROUTE, PULL, PUSH, HEARTBEAT, PURGE_INCOMING, PURGE_OUTGOING, PURGE_STATISTICS, SYNCTRIGGERS, + PURGE_DATA_GAPS, STAGE_MANAGEMENT, WATCHDOG, STATISTICS, FILE_SYNC_PULL, FILE_SYNC_PUSH, FILE_SYNC_TRACKER, + INITIAL_LOAD_EXTRACT }) { + if (allLocks.get(action) == null) { + initLockTable(action, TYPE_CLUSTER); + } } } @@ -188,23 +190,21 @@ protected boolean lockWait(final String action, final String lockType, long wait public Map findLocks() { final Map locks = new HashMap(); - if (isClusteringEnabled()) { - sqlTemplate.query(getSql("findLocksSql"), new ISqlRowMapper() { - public Lock mapRow(Row rs) { - Lock lock = new Lock(); - lock.setLockAction(rs.getString("lock_action")); - lock.setLockType(rs.getString("lock_type")); - lock.setLockingServerId(rs.getString("locking_server_id")); - lock.setLockTime(rs.getDateTime("lock_time")); - lock.setSharedCount(rs.getInt("shared_count")); - lock.setSharedEnable(rs.getBoolean("shared_enable")); - lock.setLastLockingServerId(rs.getString("last_locking_server_id")); - lock.setLastLockTime(rs.getDateTime("last_lock_time")); - locks.put(lock.getLockAction(), lock); - return lock; - } - }); - } + sqlTemplate.query(getSql("findLocksSql"), new ISqlRowMapper() { + public Lock mapRow(Row rs) { + Lock lock = new Lock(); + lock.setLockAction(rs.getString("lock_action")); + lock.setLockType(rs.getString("lock_type")); + lock.setLockingServerId(rs.getString("locking_server_id")); + lock.setLockTime(rs.getDateTime("lock_time")); + lock.setSharedCount(rs.getInt("shared_count")); + lock.setSharedEnable(rs.getBoolean("shared_enable")); + lock.setLastLockingServerId(rs.getString("last_locking_server_id")); + lock.setLastLockTime(rs.getDateTime("last_lock_time")); + locks.put(lock.getLockAction(), lock); + return lock; + } + }); return locks; }