0001877: Process status can be stranded in non-ok or non-error status…

… on pull if an io expection occurs in the uri handler
JumpMind · Aug 6, 2014 · 3ec125c · 3ec125c
1 parent 7dbaac0
commit 3ec125c
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/symmetric-server/src/main/java/org/jumpmind/symmetric/web/PullUriHandler.java b/symmetric-server/src/main/java/org/jumpmind/symmetric/web/PullUriHandler.java
@@ -119,9 +119,10 @@ public void pull(String nodeId, String remoteHost, String remoteAddress,
                         if (processInfo.getStatus() != Status.ERROR) {
                             processInfo.setStatus(Status.OK);
                         }
-                    } catch (RuntimeException ex) {
-                        processInfo.setStatus(Status.ERROR);
-                        throw ex;
+                    } finally {
+                        if (processInfo.getStatus() != Status.OK) {
+                            processInfo.setStatus(Status.ERROR);
+                        }
                     }
                     outgoingTransport.close();
                 }