0003192: Sybase ASE Errors in Metadata Using Reserved Words

JumpMind · Jul 7, 2017 · 79078ae · 79078ae
1 parent c11edb8
commit 79078ae
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/symmetric-jdbc/src/main/java/org/jumpmind/db/platform/AbstractJdbcDdlReader.java b/symmetric-jdbc/src/main/java/org/jumpmind/db/platform/AbstractJdbcDdlReader.java
@@ -1238,7 +1238,7 @@ protected void determineAutoIncrementFromResultSetMetaData(Connection conn, Tabl
                     query.append(",");
                 }
                 query.append("t.");
-                appendIdentifier(query, columnsToCheck[idx].getName());
+                appendColumn(query, columnsToCheck[idx].getName());
             }
             query.append(" FROM ");
 
@@ -1295,7 +1295,7 @@ protected void determineAutoIncrementFromResultSetMetaData(Connection conn, Tabl
         }
     }
 
-    public StringBuilder appendIdentifier(StringBuilder query, String identifier) {
+    private StringBuilder appendIdentifier(StringBuilder query, String identifier) {
         if (getPlatform().getDdlBuilder().isDelimitedIdentifierModeOn()) {
             query.append(getPlatformInfo().getDelimiterToken());
         }
@@ -1305,6 +1305,13 @@ public StringBuilder appendIdentifier(StringBuilder query, String identifier) {
         }
         return query;
     }
+
+    /*
+     * Allow subclasses to override column delimiters
+     */
+    protected StringBuilder appendColumn(StringBuilder query, String identifier) {
+        return appendIdentifier(query, identifier);
+    }
 
     /*
      * Replaces a specific character sequence in the given text with the

diff --git a/symmetric-jdbc/src/main/java/org/jumpmind/db/platform/ase/AseDdlReader.java b/symmetric-jdbc/src/main/java/org/jumpmind/db/platform/ase/AseDdlReader.java
@@ -338,4 +338,12 @@ protected String getTableNamePattern(String tableName) {
         tableName = tableName.replace("%", "\\%");
         return tableName;
     }
+
+    @Override
+    protected StringBuilder appendColumn(StringBuilder query, String identifier) {
+        query.append("\"");
+        query.append(identifier);
+        query.append("\"");
+        return query;
+    }
 }