From 94e7861a8ead4efb27d2d0612de9604027668e5e Mon Sep 17 00:00:00 2001 From: Catherine Quamme Date: Mon, 3 Jul 2023 10:38:43 -0400 Subject: [PATCH] 0005909: Some methods are synchronized unnecessarily in AbstractParameterService --- .../service/impl/AbstractParameterService.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/AbstractParameterService.java b/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/AbstractParameterService.java index 3e998ffb56..1da685305b 100644 --- a/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/AbstractParameterService.java +++ b/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/AbstractParameterService.java @@ -181,7 +181,7 @@ public Date getLastTimeParameterWereCached() { return new Date(lastTimeParameterWereCached); } - public synchronized String getExternalId() { + public String getExternalId() { if (externalId == null) { String value = getString(ParameterConstants.EXTERNAL_ID); value = substituteScripts(value); @@ -193,7 +193,7 @@ public synchronized String getExternalId() { return externalId; } - public synchronized String getSyncUrl() { + public String getSyncUrl() { if (syncUrl == null) { String value = getString(ParameterConstants.SYNC_URL); value = substituteScripts(value); @@ -208,7 +208,7 @@ public synchronized String getSyncUrl() { return syncUrl; } - public synchronized String getNodeGroupId() { + public String getNodeGroupId() { if (nodeGroupId == null) { String value = getString(ParameterConstants.NODE_GROUP_ID); value = substituteScripts(value); @@ -220,7 +220,7 @@ public synchronized String getNodeGroupId() { return nodeGroupId; } - public synchronized String getRegistrationUrl() { + public String getRegistrationUrl() { if (registrationUrl == null) { String value = getString(ParameterConstants.REGISTRATION_URL); value = substituteScripts(value); @@ -235,7 +235,7 @@ public synchronized String getRegistrationUrl() { return registrationUrl; } - public synchronized String getEngineName() { + public String getEngineName() { if (engineName == null) { String value = getString(ParameterConstants.ENGINE_NAME, "SymmetricDS"); value = substituteScripts(value);